tommasoamici

tommasoamici

I’ve got an annoying problem on my hands. I’m open to a different approach as well.

I’m writing a GenServer to store a live auction, when bids are submitted they’re stored in the database with Ash actions and the GenServer picks them up from PubSub.

I want to introduce a recovery mechanism so that if a GenServer crashes it can reload from the database and continue working. My current implementation does this in the GenServer.init/1 callback.

I’m writing tests for this and something that I can’t figure out is: when a GenServer is killed, the DynamicSupervisor will restart it and it will run the init/1 again. So far so good.

However, the new process has a different PID and Ecto.Adapters.SQL.Sandbox doesn’t allow connecting from it. I want to avoid :shared mode so tests can be async.

At this point there’s a race condition: when starting up the GenServer wants to hit the database and it can’t so it crashes.
I can’t allow the new PID because I don’t know what it is and by the time I look it up in the registry, it’s already crashed :confused:

Has anyone managed to instrument tests for this scenario? Ideally without polluting the application code with these implementation details.

Showing Posts 1 to 4

al2o3cr

al2o3cr

An approach I’ve used is passing the test process’s PID along when starting the child in DynamicSupervisor.

The GenServer then calls Ecto.Adapters.SQL.Sandbox.allow(YourRepo, parent_pid, self())

I don’t know if there’s an “official” way to ask the repo “are you sandbox”; there wasn’t when I wrote the code using this feature, so I did it by checking Application.fetch_env!(:your_app_name, YourRepo)[:pool] - if it’s the atom Ecto.Adapters.SQL.Sandbox, then the sandbox is enabled.

While your GenServer is doing that, another useful thing to add is Process.monitor(parent_pid). That allows avoiding two race-for-the-flag scenarios that spam the logs and crash unexpectedly:

  • if the test process exits but the GenServer is still running, subsequent Repo interactions will raise an error. Once you’re monitoring parent_pid, the GenServer can take appropriate action when the :DOWN message arrives. Usually that action is to return :stop, but you may also have cleanup to do.
  • if the GenServer crashes at just the wrong time, the DynamicSupervisor will restart it after the test process has already exited. Again, this will cause any Repo interaction in the GenServer to fail.

One other note: make sure you’ve tuned the restart parameters of DynamicSupervisor correctly, especially when running fast tests in parallel. Nothing more frustrating than trying to figure out why your tests fail randomly, but only when all run together, and only on a fast machine…

martosaur

martosaur

Make your genserver set :$callers key in process dictionary and Ecto sandbox should be able to figure ownership. More info on caller tracking: Task — Elixir v1.20.2

basically, you’ll have something like this:

defmodule MyGenserver do
  use GenServer

  def start_link(arg) do
    callers = Process.get(:"$callers", [])
    GenServer.start_link(__MODULE__, {arg, callers})
  end

  def init({arg, callers}) do
    Process.put(:"$callers", [self() | callers])
    ...
  end
end
jswanner

jswanner

This is my preferred approach as well, and it works for tests because :"$callers" is already set in the test process

tommasoamici

tommasoamici OP

that’s a really elegant solution, thanks!

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews