PavelZX

Ecto.Association.NotLoaded

In Phx 1.3 this code works, but in Phx 1.4 doesn’t want.

  def index(conn, _params) do
    current_user = Guardian.Plug.current_resource(conn)

    owned_board = current_user
      |> assoc(:owned_board)
      |> board_preload_all
      |> Repo.all

    invited_board = current_user
      |> assoc(:board)
      |> not_owned_by(current_user.id)
      |> board_preload_all
      |> Repo.all

    render(conn, "index.json", owned_board: owned_board, invited_board: invited_board)
  end

Errors are obtained.

[error] #PID<0.501.0> running ImconWeb.Endpoint (connection #PID<0.500.0>, stream id 1) terminated
Server: caix.ru:4001 (http)
Request: POST /api/v1/sessions
** (exit) an exception was raised:
    ** (ArgumentError) argument error
        :erlang.apply(%Imcon.Auth.User{__meta__: #Ecto.Schema.Metadata<:loaded, "user">, board: #Ecto.Association.NotLoaded<association :board is not loaded>, email: "john@phoenix-trello.com", encrypted_password: "$2b$12$nn1jeBQwQms.Id2JOeb6..mi8UQQka8dyWNkh0WqmAm/hN0AQX9zW", first_name: "John", id: 1, inserted_at: ~N[2019-01-02 08:36:35.417355], is_admin: false, last_name: "Doe", owned_board: #Ecto.Association.NotLoaded<association :owned_board is not loaded>, password: nil, updated_at: ~N[2019-01-02 08:36:35.426004], user_board: #Ecto.Association.NotLoaded<association :user_board is not loaded>}, :config, [])
        (guardian) lib/guardian.ex:776: Guardian.token_module/1
        (guardian) lib/guardian.ex:576: Guardian.encode_and_sign/4
        (imcon) lib/imcon_web/controllers/api/v1/session_controller.ex:9: ImconWeb.SessionController.create/2

The configuration is such here.

[
  {:phoenix, "~> 1.4.0"},
  {:phoenix_pubsub, "~> 1.1.1"},
  {:phoenix_ecto, ">= 3.2.0 and < 3.5.0"},
  {:postgrex, ">= 0.0.0"},
  {:poison, ">= 0.0.0"},
  {:phoenix_html, "~> 2.12.0"},
  {:phoenix_live_reload, "~> 1.2.0", only: :dev},
  {:gettext, "~> 0.16.1"},
  {:cowboy, "~> 2.6.0"},
  {:plug_cowboy, "~> 2.0.0"},
  {:comeonin, "~> 4.1.1"},
  {:bcrypt_elixir, "~> 1.0.9"},
  {:guardian, "~> 1.1.1"},
  {:credo, "~> 0.10.2", only: [:dev, :test]},
  {:ex_machina, "~> 2.2.2"},
  {:exactor, "~> 2.2.4"},
  {:hound, "~> 1.0.2"},
  {:mix_test_watch, "~> 0.9.0", only: :dev},
  {:poolboy, "~> 1.5.1"}
]

13 comments

/phoenix #ecto

0 6035 13

2019-01-07 08:10:38 UTC

Most Liked

van-mronov

As error message said the problem occurs in create action not in index.

Post #2

PavelZX

If Erlang himself swears, then, is the error still covered in the communication modules with the database?

  defmodule ImconWeb.SessionController do
      use ImconWeb, :controller

  plug :scrub_params, "session" when action in [:create]

  def create(conn, %{"session" => session_params}) do
    case Imcon.Auth.authenticate(session_params) do
      {:ok, user} ->
        {:ok, jwt, _full_claims} = user |> Guardian.encode_and_sign(:token)

        conn
        |> put_status(:created)
        |> render("show.json", jwt: jwt, user: user)

      :error ->
        conn
        |> put_status(:unprocessable_entity)
        |> render("error.json")
    end
  end

  def delete(conn, _) do
    {:ok, claims} = Guardian.Plug.current_claims(conn)

    conn
    |> Guardian.Plug.current_token
    |> Guardian.revoke(claims)

    conn
    |> render("delete.json")
  end


  def unauthenticated(conn, _params) do
    conn
    |> put_status(:forbidden)
    |> render(ImconWeb.SessionView, "forbidden.json", error: "Not Authenticated")
  end

end

Based on various examples, I brought the authentication to a separate new context. I want to enter roles, for users, groups (teams), adding this context.

defmodule Imcon.Auth do

  import Ecto.Changeset
  import Plug.Conn
  
  alias Comeonin.Bcrypt

  alias Imcon.Repo
  alias Imcon.Auth.User

    # ... User

  def get_user(id), do: Repo.get(User, id)

  def fetch_assoc(%User{} = user, assoc \\ [:board, :user_board, :owned_board]) do
    Repo.preload(user, assoc)
  end

  @required_fields ~w(first_name last_name email password)
  @optional_fields ~w(encrypted_password)

  def create_user(%User{} = user, attrs) do
    user
    |> cast(attrs, @required_fields, @optional_fields)
    |> validate_format(:email, ~r/@/)
    |> validate_length(:password, min: 5)
    |> validate_confirmation(:password, message: "Password does not match")
    |> unique_constraint(:email, message: "Email already taken")
    |> generate_encrypted_password
  end

  def update_user(%User{} = user, attrs) do
    user
    |> cast(attrs, [:first_name, :last_name, :email], [:password])
    |> validate_required([:first_name, :email])
    |> generate_encrypted_password
    |> unique_constraint(:email)
  end

  defp generate_encrypted_password(current_changeset) do
    case current_changeset do
      %Ecto.Changeset{valid?: true, changes: %{password: password}} ->
        put_change(current_changeset, :encrypted_password, Comeonin.Bcrypt.hashpwsalt(password))
      _ ->
        current_changeset
    end
  end

  def load_current_user(conn, _) do
    conn
    |> assign(:current_user, Guardian.Plug.current_resource(conn))
    |> put_user_token(Guardian.Plug.current_resource(conn))
  end

  defp put_user_token(conn, user) do
    token = Phoenix.Token.sign(conn, "user socket", user.id)

    conn
    |> assign(:user_token, token)
  end

  def authenticate(%{"email" => email, "password" => password}) do
    user = Repo.get_by(User, email: String.downcase(email))

    case check_password(user, password) do
      true -> {:ok, user}
      _ -> :error
    end
  end

  defp check_password(user, password) do
    case user do
      nil -> Bcrypt.dummy_checkpw()
      _ -> Bcrypt.checkpw(password, user.encrypted_password)
    end
  end

end

Post #9