hudsonbay

hudsonbay

hello, I have a sku_store many to many relation.

I’m trying to delete the relations in this list:

# This map is what I'm sending to the function
[%{sku_id: 1, store_id: 2}, %{sku_id: 3, store_id: 4}] 

(In reality there are like 10_000 registries to delete in bulk) and there’s no primary key, BTW.

This function does the job:

def bulk_delete_skus_in_stores(list) do
	keys = [:sku_id, :store_id]
	attrs = list_to_tuple(list, keys)
	
	Repo.query(~s"""
		  delete from sku_store where (#{keys |> Enum.join(",")}) in (#{attrs})
		""")
		|> case do
		  {:ok, %Postgrex.Result{num_rows: num_rows}} -> %{rows_affected: num_rows, errors: []}
	end
end

The problem with this function is:

  • It does the job one by one. I want to use a delete_all to achieve more performance
  • I’m not sure if I have the risk of a SQL injection here? :thinking: Maybe using Ecto macros it’s better

has anyone faced a similar problem in the past?

Showing Posts 1 to 4

stefanchrobot

stefanchrobot

I’m writing this from the top of the head, but you should be able to do this:

attrs = Enum.map(list, fn %{sku_id: sku_id, store_id: store_id} -> {sku_id, store_id} end)

Repo.delete_all(
  from s in SkuStore,
  where: {s.sku_id, s.store_id} in ^attrs
)
hudsonbay

hudsonbay OP

Thanks a lot, @stefanchrobot
That’s a great approach :clap: and it’s more or less what I’ve been trying to do with no success.
In this case, I would have something like this [{1, 2}, { 3, 4}] to compare with :+1:.

But it gives me now an error that I’m still trying to debug and have no idea why it’s happening. It makes no sense to me:

(Ecto.Query.CompileError) Tuples can only be used in comparisons with literal tuples of the same size

Why it’s telling me tuples are not the same size? Makes no sense

hudsonbay

hudsonbay OP

Using this answer Ecto IN clauses with tuples - #16 by alex_weinberger I could do it. So at the end, this is what I did:

def delete_skus_by_id(list) do
    queryable =
      from s in SKUStore,
        inner_join:
          j in fragment(
            "SELECT DISTINCT * FROM jsonb_to_recordset(?) AS j(sku_id int, store_id int)",
            ^list
          ),
        on: s.sku_id == j.sku_id and s.store_id == j.store_id

    Ecto.Multi.new()
    |> Ecto.Multi.delete_all(:delete_all, queryable, on_conflict: :nothing)
    |> Repo.transaction()
    |> case do
      {:ok, _} ->
        %{rows_affected: length(list), errors: []}

      {
        :error,
        _,
        %Ecto.Changeset{
          changes: changes,
          errors: errors
        },
        _
      } ->
        %{
          rows_affected: 0,
          errors: "Changes #{changes} couldn't be created because #{inspect(errors)}"
        }
    end
  end
stefanchrobot

stefanchrobot

I think I’ve hit this before too. I think this means you need to use explicit values (not even variable) to make this work.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kpanic
Hi everyone, I am toying with the idea of building a “match maker” for giving personal help to people that wants to start coding. I sta...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
asweet-confluent
I recently noticed that Elixir’s Logger defaults its primary log level to :debug when no :logger, :level application configuration is pre...
New
apz
I’m new to elixir and just tried to install the elixirLS extension for VScode(ium) and it is throwing some errors that I would like help ...
New

Other Trending Topics Top

GenericJam
Edit: 2026 May 15 - This post is archived. Mob is alive!! Main docs: mob v0.7.11 — Documentation A bit of explanation for the slightly c...
New
JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews