poipoi

poipoi

Hi everyone,
When you generate a context with phx.gen.context, the generator creates a changeset function in the schema file that casts certain attributes and marks others as required. However, the id is neither cast nor required.

This changeset is then utilized in nearly all the generated functions within the context.
This works fine for most of the functions, but shouldn’t the changeset used in the update and delete functions of the context require the presence of the id in the struct?
I know that the code can be modified to do this, I thought that the generator should handle it. (if it’s good to do so)

Showing Posts 1 to 7

al2o3cr

al2o3cr

Generally this is handled by fetching the structs from the database via Repo.get etc; you don’t normally cast :id in changesets.

poipoi

poipoi OP

Oh ok I see. I’m in a situation where if a query does not return anything, I am simply passed an empty struct so it’s a bit different

kokolegorille

kokolegorille

It looks You are checking the db before creating, or updating?

You might have race condition, and some other methods deals with this in a safer way.

poipoi

poipoi OP

I’m not really checking the database, I am just retrieving the struct to modify like @al2o3cr said. It’s just that my (simplified) workflow it’s like this: Repo.get(id) |> Map.put(something) |> changeset() |> Repo.update(), but instead of failing on Repo.get!() when there is no object I return an empty struct, and I fail on Repo.update() because the struct has no PK.

Instead of changing the changeset function I plan to call Repo.insert if there is no PK instead of Repo.update

thomas.fortes

thomas.fortes

This will fail because Repo.get/3 returns nil when there’s no result and you can’t Map.put/3 on nil

This is called an “upsert” and ecto has support for it as described here.

poipoi

poipoi OP

This will fail because Repo.get/3 returns nil when there’s no result and you can’t Map.put/3 on nil

I don’t exactly use Repo.get, it was only a simplification.

This is called an “upsert” and ecto has support for it as described here.

Many thanks, I’ll look into it! :grin:

kokolegorille

kokolegorille

If your pipeline can fail, You should use with…

with %{} = struct <- Repo.get(id),
  data <- Map.put(struct),
  changeset <- changeset(data),
  any <- Repo.update(changeset) do

  ...
else
  ...
end
— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews