poipoi

poipoi

Ecto changeset generated with phx.gen.context does not require id for update

Hi everyone,
When you generate a context with phx.gen.context, the generator creates a changeset function in the schema file that casts certain attributes and marks others as required. However, the id is neither cast nor required.

This changeset is then utilized in nearly all the generated functions within the context.
This works fine for most of the functions, but shouldn’t the changeset used in the update and delete functions of the context require the presence of the id in the struct?
I know that the code can be modified to do this, I thought that the generator should handle it. (if it’s good to do so)

First 7 of 7 Posts Switch mode

al2o3cr

al2o3cr

Generally this is handled by fetching the structs from the database via Repo.get etc; you don’t normally cast :id in changesets.

poipoi

poipoi OP

Oh ok I see. I’m in a situation where if a query does not return anything, I am simply passed an empty struct so it’s a bit different

kokolegorille

kokolegorille

It looks You are checking the db before creating, or updating?

You might have race condition, and some other methods deals with this in a safer way.

poipoi

poipoi OP

I’m not really checking the database, I am just retrieving the struct to modify like @al2o3cr said. It’s just that my (simplified) workflow it’s like this: Repo.get(id) |> Map.put(something) |> changeset() |> Repo.update(), but instead of failing on Repo.get!() when there is no object I return an empty struct, and I fail on Repo.update() because the struct has no PK.

Instead of changing the changeset function I plan to call Repo.insert if there is no PK instead of Repo.update

thomas.fortes

thomas.fortes

This will fail because Repo.get/3 returns nil when there’s no result and you can’t Map.put/3 on nil

This is called an “upsert” and ecto has support for it as described here.

poipoi

poipoi OP

This will fail because Repo.get/3 returns nil when there’s no result and you can’t Map.put/3 on nil

I don’t exactly use Repo.get, it was only a simplification.

This is called an “upsert” and ecto has support for it as described here.

Many thanks, I’ll look into it! :grin:

kokolegorille

kokolegorille

If your pipeline can fail, You should use with…

with %{} = struct <- Repo.get(id),
  data <- Map.put(struct),
  changeset <- changeset(data),
  any <- Repo.update(changeset) do

  ...
else
  ...
end
— All posts loaded —

Where Next?

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement