Ecto has_many through with condition/filter

I’d expect this to work (in the User schema):

has_many :model_has_roles, foreign_key: :model_id, where: [model_type: "App\\User"]
has_many :roles, through: [:model_has_role, :role]

along with a standard belongs_to :role on ModelHasRole

This has me so close! I can’t figure out this error though - even though it’s seemingly running the correct query.

iex(3)> Repo.all(from u in User, preload: :roles)

** (ArgumentError) schema ModelHasRole does not have association Role (if you were trying to pass a schema as a query to preload, you have to explicitly convert it to a query by doing `from x in Role` or by calling Ecto.Queryable.to_query/1)
    (elixir 1.11.2) lib/enum.ex:2181: Enum."-reduce/3-lists^foldl/2-0-"/3
    (ecto 3.5.7) lib/ecto/repo/queryable.ex:235: Ecto.Repo.Queryable.execute/4
    (ecto 3.5.7) lib/ecto/repo/queryable.ex:17: Ecto.Repo.Queryable.all/3

Even though I have the association on the ModelHasRole:

belongs_to :role, Role

Actually it looks like I had a typo. The issue now is:

iex(9)> Repo.all(from u in User, preload: :roles)
** (ArgumentError) cannot preload through association `model_has_roles` on `User`. Ecto expected the ModelHasRole schema to have at least one primary key field

ModelHasRole indeed has @primary_key false.

However this works fine..:

Repo.all(from u in User, preload: [model_has_roles: :role])

So I think I figured this out. I was going about it completely wrong. I think this does what I need:

many_to_many :roles, Role,
  join_through: ModelHasRole,
  join_keys: [model_id: :id, role_id: :id],
  join_where: [model_type: "App\\User"]