maz

maz

I have Users and Orgs. Users can belong to multiple Orgs and Orgs can have many users:

defmodule Elijah.Schema.User do
  use Ecto.Schema
  import Ecto.Changeset
  use Waffle.Ecto.Schema

...
  schema "users" do
    field :email, :string
    field :username, :string
    field :name, :string
    field :phone_number, :string
    field :confirmed_at, :naive_datetime
    field :is_admin, :boolean
    field :avatar, Elijah.AvatarUploader.Type

    many_to_many :orgs, Elijah.Schema.Org, join_through: "orgs_users", on_replace: :delete

    timestamps()
  end
...

Org:

defmodule Elijah.Schema.Org do
  use Ecto.Schema
  import Ecto.Changeset
  alias Elijah.Type.OrgHashId
...
  schema "orgs" do
    field :basename, :string
    field :shortname, :string
    field :uuid, Ecto.UUID
    field :hash_id, :string

    has_many :channels, Elijah.Schema.Channel
    has_many :playlists, Elijah.Schema.Playlist
    many_to_many :users, Elijah.Schema.User, join_through: "orgs_users", on_replace: :delete

    timestamps(type: :utc_datetime)

    # timestamps()
  end
...

OrgsUsers:

defmodule Elijah.Schema.OrgsUsers do
  use Ecto.Schema
  import Ecto.Changeset


  schema "orgs_users" do
    field :org_id, :integer
    field :user_id, :integer
  end

  @doc false
  def changeset(orgs_users, attrs) do
    orgs_users
    |> cast(attrs, [:user_id, :org_id])
    |> validate_required([:user_id, :resource_id])
  end
end

I made a function called Accounts.add_user() which is meant to add a user to an org and update the orgs_users table. However what is happening is that the second association will clobber the first one:

Accounts.add_user():

    def add_user(%{"org_id" => org_id, "user_id" => user_id}) do
      org = Repo.get_by!(Org, id: org_id)
      user = Repo.get_by!(User, id: user_id)
      org
      |> Repo.preload(:users)
      |> Ecto.Changeset.change()
      |> Ecto.Changeset.put_assoc(:users, [user])
      |> Repo.update!
    end

Here is the log where I add two users:

SELECT * from orgs_users:

elijah_dev=# select * from orgs_users;
 id | org_id | user_id 
----+--------+---------
  2 |      1 |       2
(1 row)

Any idea why add_user() does not append? I also tried:

Ecto.Changeset.put_assoc(:users, org.users ++ user)

but resulted in this error:

** (ArgumentError) argument error
    :erlang.++(#Ecto.Association.NotLoaded<association :users is not loaded>, #Elijah.Schema.User<__meta__: #Ecto.Schema.Metadata<:loaded, "users">, avatar: nil, confirmed_at: nil, email: "amos@elijah.app", id: 1, inserted_at: ~N[2020-10-19 21:00:31], is_admin: nil, name: "Amos", orgs: #Ecto.Association.NotLoaded<association :orgs is not loaded>, phone_number: nil, updated_at: ~N[2020-10-19 21:00:31], username: "amos", ...>)
    (faithful_word 0.1.0) lib/faithful_word/accounts.ex:93: Elijah.Accounts.add_user/1

(first insert)

Showing Posts 1 to 3

fuelen

fuelen

Hello.

Yes, this behaviour is described in documentation to Ecto.Changeset.put_assoc/4:

This function is used to work with associations as a whole. For example, if a Post has many Comments, it allows you to add, remove or change all comments at once. If your goal is to simply add a new comment to a post, then it is preferred to do so manually, as we will describe later in the “Example: Adding a comment to a post” section.

The last error can be fixed by preloading users assoc to org:

org = Repo.preload(org, :users)
maz

maz OP

Thanks for showing me those docs, missed the example part. I changed

|> Ecto.Changeset.put_assoc(:users, [user])

so add_user() now reads like:

    def add_user(%{"org_id" => org_id, "user_id" => user_id}) do
      org = Repo.get_by!(Org, id: org_id)
      user = Repo.get_by!(User, id: user_id)
      org
      |> Repo.preload(:users)
      |> Ecto.Changeset.change()
      |> Ecto.Changeset.put_assoc(:users, [user | org.users])
      |> Repo.update!
    end

And I get an invalid changeset:

** (Ecto.InvalidChangesetError) could not perform update because changeset is invalid.

Errors

    %{users: [{"is invalid", [type: {:array, :map}]}]}

Applied changes

    %{}

Params

    nil

Changeset

    #Ecto.Changeset<
      action: :update,
      changes: %{},
      errors: [users: {"is invalid", [type: {:array, :map}]}],
      data: #Elijah.Schema.Org<>,
      valid?: false
    >

    (ecto 3.4.6) lib/ecto/repo/schema.ex:182: Ecto.Repo.Schema.update!/4

Why? I do a preload:

      org
      |> Repo.preload(:users)
maz

maz OP

I finally got it working. I had to assign the preloaded org to an intermediate value:

      org_loaded = Repo.preload(org, [:users])
      org_changeset = Ecto.Changeset.change(org_loaded)
      org_user_changeset = org_changeset |> Ecto.Changeset.put_assoc(:users, [user | org_loaded.users])
      Repo.update!(org_user_changeset)

Not sure why it did not work with pipe operator.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
webofbits
With AI doing more of the implementation work, I’ve been wondering how much coding I should deliberately keep doing myself. My main conc...
#ai
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews