EEx.eval_file :functions option in eval is deprecated

onelixir

Hello,

I am studying《Build Your Own Web Framework in Elixir》, In about chapter 7 when I follow the book write code like this:

  def render(view_module, conn, file, assigns) do
    functions = view_module.__info__(:functions)

    contents =
      file
      |> html_file_path()
      |> EEx.eval_file([assigns: assigns], functions: [{view_module, functions}])

    Controller.render(conn, :html, contents)
  end

I get a warning: warning: :functions option in eval is deprecated, and I checked the official document EEx.html#module-options, which doesn’t have functions options, I also check Elixir version before v1.10.0, also don’t have this option, my question is:

In EEx.eval_file if I want to pass a functions option, what should I do?
Where does the functions option come from at the beginning? seems the document never wrote about this option, so how does the author of this book know this?

11 comments

#eex

0 1155 11

2023-09-27 14:35:14 UTC

Showing Posts 1 to 10

Show Best Posts
Show All (oldest first)
Show All (newest first)

LostKobrakai

One can always look at the code, not just the documentation. Though it it hadn’t been documented it likely wasn’t supposed to be used.

Post #1

onelixir

I followed your suggestion, find out the source code here: do_eval, after that I cannot go further, It is not easy for me. Also, nothing mentioned cannot use :functions as an option.

Post #2

LostKobrakai

This part is in the parser itself:

https://github.com/elixir-lang/elixir/blob/main/lib/elixir/src/elixir.erl#L292-L298

Post #3

onelixir

Thank you so much! I will try to follow your step to see how to do without using :functions。

Post #4

stefanluptak

This option was there in Elixir 1.12.3 for the last time (see Code — Elixir v1.12.3)

It was then deprecated in the version 1.13.0 (see elixir/CHANGELOG.md at v1.13 · elixir-lang/elixir · GitHub)

Post #5

onelixir

Thank you so much! my searching ability is so weak…

The changelog just say:

[Code] Environment options in Code.eval_quoted/3 and Code.eval_string/3, such as :aliases and :tracers, have been deprecated in favor of passing an environment

I still don’t know what to do, if I cannot solve it, I have to just mark it and move on, until one day I can.

Post #6

stefanluptak

First of all, I was dealing with a same/similar problem few weeks back, so your searching ability is not weak, I just already invested some time in it previously.

This :functions option is just a list of functions that will be automatically imported thus available to be used in your view without the full module path needed. For example, if you would provide something like functions: [{MyApp.MyModule, [hello: 0]}], (0 being the arity (number of args) of the foo function) then you can use <%= foo() %> in your template. Without the :functions option, you just have to do <%= MyApp.MyModule.foo() %>, that is all.

Hope this helps a bit.

Post #7

onelixir

Thank you for your explanation again,

I understand you now, but I still don’t know what the alternative way to do if the official doesn’t suggest we pass functions option? How to do that with env? I cannot just do EEx.eval_file("xxx.html.eex", [assigns: assigns], __ENV__).

Post #8

stefanluptak

Sorry, I have no knowledge of that and have no time to research it. Maybe someone else could help with that.

Post #9

LostKobrakai

That expects there to be an alternative. Maybe there is none and you’re expected to instead update the templates to not depend on the deprecated functionality.

Post #10

Load more posts (1 remaining)