quda
Elegant refactory of a function
I’ve got this function, translated from an old codebase (imperative language) into Elixir, by our contractor.
def pub0(payload) when is_map(payload) do
if ["country", "commodity", "share", "mon", "cog", "esa1"] |> Enum.all?(fn x -> Map.has_key?(payload, x) end) &&
Map.get(payload, "esa1") == "hs10" &&
is_intger(Map.get(payload, "cog") do
payload = Map.put(payload, "itime", utimestamp(2))
emporio_ts(Jason.encode!(payload))
end
end
The function works fine, it performs its job, but I don’t like the code structure:
There is an if with tree conditions that have to evaluate all to true (logically: if (true & true & true) then …). If satisfices this, then adds new property to the object and finally calls another function.
It does not seem functional. Is there a way to refactory the function in a (more) elegant and functional manner? And also more comprehensible, consistent, shorter ?
Thanks! ![]()
Marked As Solved
trisolaran
Personally, I’d probably go for this:
def pub0(%{"country" => _, "commodity" => _, "share" => _, "mon" => _, "cog" => cog, "esa1" => "hs10"} = payload) when is_integer(cog) do
payload
|> Map.put("itime", utimestamp(2))
|> Jason.encode!
|> emporio_ts()
end
def pub0(_), do: nil
Also Liked
quda
I’ve learnt map support partial matches but still it fails with that error.
Unfortunately, I can’t share more code/data (for legal reasons), I have to debug it myself.
cmo
Last Post!
cmo
Popular in Questions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #elixirconf-us
- #advent-of-code
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #hex









