quda

quda

Elegant refactory of a function

I’ve got this function, translated from an old codebase (imperative language) into Elixir, by our contractor.

  def pub0(payload) when is_map(payload) do
    if ["country", "commodity", "share", "mon", "cog", "esa1"] |> Enum.all?(fn x -> Map.has_key?(payload, x) end) &&
        Map.get(payload, "esa1") == "hs10" &&
        is_intger(Map.get(payload, "cog") do
      payload = Map.put(payload, "itime", utimestamp(2))
      emporio_ts(Jason.encode!(payload))
    end
  end

The function works fine, it performs its job, but I don’t like the code structure:

There is an if with tree conditions that have to evaluate all to true (logically: if (true & true & true) then …). If satisfices this, then adds new property to the object and finally calls another function.

It does not seem functional. Is there a way to refactory the function in a (more) elegant and functional manner? And also more comprehensible, consistent, shorter ?

Thanks! :smiley:

Marked As Solved

trisolaran

trisolaran

Personally, I’d probably go for this:

def pub0(%{"country" => _, "commodity" => _, "share" => _, "mon" => _, "cog" => cog, "esa1" => "hs10"} = payload) when is_integer(cog) do
    payload
    |> Map.put("itime", utimestamp(2))
    |> Jason.encode!
    |> emporio_ts()
  end
  
def pub0(_), do: nil

Also Liked

quda

quda

I’ve learnt map support partial matches but still it fails with that error.
Unfortunately, I can’t share more code/data (for legal reasons), I have to debug it myself.

cmo

cmo

It can’t fall with that catch-all returning nil …?

Last Post!

cmo

cmo

It can’t fall with that catch-all returning nil …?

Where Next?

Popular in Questions Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
vonH
In asking this question I am more interested about the expressiveness of the language itself and less concerned about the availability of...
New
9mm
I am constructing a JSON object (map) and I need to conditionally set a field. I’m trying to write proper elixir-way code… and I’m at a l...
New
stefanluptak
Hello everybody, usually, I use a 29" ultra-wide monitor for VSCode which can easily accomodate explorer (files panel) + file with code ...
New
SoCreat
i’m a new one to elixir which editor can i use vs code? or atom? Thanks! :smiley:
New
fayddelight
I tried installing elixir 1.11.2 erlang 23.3.4 via asdf in my zsh shell. Enabled the versions locally and globally. When I list them ...
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New

Other popular topics Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
sergio_101
I am VERY much an elixir newbie. I have taken one elixir course and one phoenix course on Udemy. During that course, I saw the instructor...
New
sorentwo
Hello! tl;dr Announcing Oban, an Ecto based job processing library with a focus on reliability and historical observability. After spen...
985 44532 311
New
shijith.k
I am trying to start a new phoenix project with elixir 1.9, but mix phx.new does not work. It says that ** (Mix) The task "phx.new" could...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
Harrisonl
We have an ECS cluster with 4 services, where each task joins a single cluster, via discovery ECS discovery service. Currently when I de...
New

We're in Beta

About us Mission Statement