silviurosu
I have a situation that I can not figure out yet for some time and it drives me nuts. Either Enum.sort is not working as expected either I am doing it wrong.
I have some rules have a name and depend on each other. Source is the name of the dependency. I am trying to sort them ascending by dependency to be able to use them later to compute some amounts:
rules = [
%{
name: "ambassador1",
source: "ambassadors"
},
%{
name: "zuppler fee",
source: "total"
},
%{
name: "ambassadors",
source: "zuppler fee"
}
]
sorter = fn
sorter = fn
%{name: name1}, %{source: source2} when name1 == source2 -> true
%{source: source1}, %{name: name2} when source1 == name2 -> false
%{name: name1, source: source1}, %{name: name2, source: source2} when name1 == name2 and source1 == source2 -> true
%{name: name1, source: source1}, %{name: name2, source: source2} -> name1 < name2 and source1 < source2
end
_, _ -> false
end
rules |> Enum.sort(sorter) |> IO.inspect()
Result is:
[
%{name: "ambassadors", source: "zuppler fee"},
%{name: "zuppler fee", source: "total"},
%{name: "ambassador1", source: "ambassadors"}
]
when the expected result would be something like:
[
%{name: "zuppler fee", source: "total"},
%{name: "ambassadors", source: "zuppler fee"},
%{name: "ambassador1", source: "ambassadors"}
]
Can somebody give me a hint?
Where Next?
Trending in Questions
Other Trending Topics
Latest on Elixir Forum
Sponsor Spotlight
Build Elixir applications with speed and confidence.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #blog-post
- #phoenix_html
- #iex
- #graphql
- #ai
- #genstage
- #elixirconf-us
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #security
- #hex
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Producing high quality Elixir screencasts since 2017.
Enabling companies to succeed by building software people love.
The deployment platform built for Elixir: PaaS ease, VPS control.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
First 8 of 8 Posts
hauleth
Function passed to
Enum.sort/2need to provide strict ordering, which mean thatfunc.(a, b) == not func.(b, a) or func.(a, a) == true. This is not a case in your example.LostKobrakai
Also
soucein your map keys vs.sourcein your pattern matches.silviurosu
This is a typo error. But it real code it’s typed ok and still does not work.
silviurosu
I updated my function to handle all comparison cases. I tried to cover all comparison cases that can appear between two elements. It may not be exactly strict ordering but taking whatever two elements it orders them correctly.
Also the docs does not specify too many requirements for this function: Enum — Elixir v1.20.2
I think it complies with this requirement.
stevensonmt
I’m going to suggest it is the order in which you have defined the conditions or the order of items in the list to begin with. The first two conditions/guards (
whenclauses) lead to a situation whereitem 2 > item 3anditem 3 > item 1but the comparison betweenitem 1anditem 2givesitem 1 > item 2based on the last condition/guard clause. This leads to ambiguity that seems to be resolved based on the order of items in the list.You can see this if you alter the order of the original list and apply the same sort. You get a different sorted order.
al2o3cr
Calling
sorterwith%{name: "zuppler fee", source: "total"}and%{name: "ambassador1", source: "ambassadors"}is going to returnfalse, so I don’t thinkEnum.sortwould find the configuration you’re looking for. The position of%{name: "ambassador1", source: "ambassadors"}in the result depends on the existence of%{name: "ambassadors", source: "zuppler fee"}…Consider topological sort + tree traversal algorithms for this one.
silviurosu
Thanks for the tip.
ondrej-tucek
@silviurosu Is this what you want?
Enum.sort_by(rules, &(&1.name), :desc)