silviurosu

silviurosu

I have a situation that I can not figure out yet for some time and it drives me nuts. Either Enum.sort is not working as expected either I am doing it wrong.
I have some rules have a name and depend on each other. Source is the name of the dependency. I am trying to sort them ascending by dependency to be able to use them later to compute some amounts:

rules = [
  %{
    name:  "ambassador1",
    source: "ambassadors"
  },
  %{
    name: "zuppler fee",
    source: "total"
  },
  %{
    name:  "ambassadors",
    source: "zuppler fee"
  }
]

sorter = fn
  sorter = fn
  %{name: name1}, %{source: source2} when name1 == source2 -> true
  %{source: source1}, %{name: name2} when source1 == name2 -> false
  %{name: name1, source: source1}, %{name: name2, source: source2} when name1 == name2 and source1 == source2 -> true
  %{name: name1, source: source1}, %{name: name2, source: source2} -> name1 < name2 and source1 < source2
end
  _, _ -> false
end
rules |> Enum.sort(sorter) |> IO.inspect()

Result is:

[
  %{name: "ambassadors", source: "zuppler fee"},
  %{name: "zuppler fee", source: "total"},
  %{name: "ambassador1", source: "ambassadors"}
]

when the expected result would be something like:

[
  %{name: "zuppler fee", source: "total"},
  %{name: "ambassadors", source: "zuppler fee"},
  %{name: "ambassador1", source: "ambassadors"}
]

Can somebody give me a hint?

Showing Posts 1 to 8

hauleth

hauleth

Function passed to Enum.sort/2 need to provide strict ordering, which mean that func.(a, b) == not func.(b, a) or func.(a, a) == true. This is not a case in your example.

LostKobrakai

LostKobrakai

Also souce in your map keys vs. source in your pattern matches.

silviurosu

silviurosu OP

This is a typo error. But it real code it’s typed ok and still does not work.

silviurosu

silviurosu OP

I updated my function to handle all comparison cases. I tried to cover all comparison cases that can appear between two elements. It may not be exactly strict ordering but taking whatever two elements it orders them correctly.
Also the docs does not specify too many requirements for this function: Enum — Elixir v1.20.2

This function uses the merge sort algorithm. The given function should compare two arguments, and return true if the first argument precedes or is in the same place as the second one.

I think it complies with this requirement.

stevensonmt

stevensonmt

I’m going to suggest it is the order in which you have defined the conditions or the order of items in the list to begin with. The first two conditions/guards (when clauses) lead to a situation where item 2 > item 3 and item 3 > item 1 but the comparison between item 1 and item 2 gives item 1 > item 2 based on the last condition/guard clause. This leads to ambiguity that seems to be resolved based on the order of items in the list.

You can see this if you alter the order of the original list and apply the same sort. You get a different sorted order.

al2o3cr

al2o3cr

Calling sorter with %{name: "zuppler fee", source: "total"} and %{name: "ambassador1", source: "ambassadors"} is going to return false, so I don’t think Enum.sort would find the configuration you’re looking for. The position of %{name: "ambassador1", source: "ambassadors"} in the result depends on the existence of %{name: "ambassadors", source: "zuppler fee"}

Consider topological sort + tree traversal algorithms for this one.

silviurosu

silviurosu OP

Thanks for the tip.

ondrej-tucek

ondrej-tucek

@silviurosu Is this what you want?

Enum.sort_by(rules, &(&1.name), :desc)

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews