intercaetera

intercaetera

Sort of a newbie code review question, but I’m curious if there’s a way to work around this. I’m still trying to wrap my head around good practices for error tuples. The precise code is in a Phoenix app but it could well exist outside of it. I have three functions in three modules:

# TaskRegistry
  def get_status(id) do
    with [{id, status}] <- :ets.lookup(:task_registry, id)
    do
      {:ok, {id, status}}
    else
      [] -> {:error, :file_not_found}
      _ -> {:error, :unknown}
    end
  end

  # TaskServer
  def handle_call({:status, id}, _, state) do
    with {:ok, {_, status}} <- TaskRegistry.get_status(id)
    do
      {:reply, {:ok, status}, state}
    else
      error -> {:reply, error, state}
    end
  end

  # TaskController
  def status(%Plug.Conn{path_params: %{"id" => id}} = conn, _params) do
    with {:ok, status} <- TaskServer.status(id)
    do
      json(conn, %{status: status})
    else
      {:error, :file_not_found} -> conn |> put_status(404) |> json(%{status: "not found"})
    end
  end

This doesn’t really seem right to me, that each of these has a with clause. But without it on each failed request the TaskServer crashes (and Phoenix returns HTTP 500, which is undesirable but not really relevant to the question). It doesn’t seem right that the GenServer should crash just because someone put in something wrong. I’m not sure how to refactor this well, though.

Showing Posts 1 to 2

stefanchrobot

stefanchrobot

All these functions would be much better off with case instead of with. Avoid else in with is a pretty good advice.

al2o3cr

al2o3cr

It’s hard to say exactly what causes this crash without the code, but I’d guess it’s a MatchError when using code like the above but without with, turning <- to =

For an expression with one statement in the “happy path” of a with, case will be more readable:

  def get_status(id) do
    case :ets.lookup(:task_registry, id) do
      [{id, status}] -> {:ok, {id, status}}
      [] -> {:error, :file_not_found}
      _ -> {:error, :unknown}
    end
  end
— All posts loaded —

Where Next? Top

Trending in Questions Top

katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
achenet
Hello, I’m trying to build a basic Phoenix web-app, and I’d like to use Tailwind. However, when I launch mix phx.server, I get an error...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New
Cxx-mlr
I’m working on a small exercise involving update_in/3, and I came up with this solution: data = %{ name: "Periodic Table", category:...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews