intercaetera

intercaetera

Sort of a newbie code review question, but I’m curious if there’s a way to work around this. I’m still trying to wrap my head around good practices for error tuples. The precise code is in a Phoenix app but it could well exist outside of it. I have three functions in three modules:

# TaskRegistry
  def get_status(id) do
    with [{id, status}] <- :ets.lookup(:task_registry, id)
    do
      {:ok, {id, status}}
    else
      [] -> {:error, :file_not_found}
      _ -> {:error, :unknown}
    end
  end

  # TaskServer
  def handle_call({:status, id}, _, state) do
    with {:ok, {_, status}} <- TaskRegistry.get_status(id)
    do
      {:reply, {:ok, status}, state}
    else
      error -> {:reply, error, state}
    end
  end

  # TaskController
  def status(%Plug.Conn{path_params: %{"id" => id}} = conn, _params) do
    with {:ok, status} <- TaskServer.status(id)
    do
      json(conn, %{status: status})
    else
      {:error, :file_not_found} -> conn |> put_status(404) |> json(%{status: "not found"})
    end
  end

This doesn’t really seem right to me, that each of these has a with clause. But without it on each failed request the TaskServer crashes (and Phoenix returns HTTP 500, which is undesirable but not really relevant to the question). It doesn’t seem right that the GenServer should crash just because someone put in something wrong. I’m not sure how to refactor this well, though.

Showing Posts 1 to 2

stefanchrobot

stefanchrobot

All these functions would be much better off with case instead of with. Avoid else in with is a pretty good advice.

al2o3cr

al2o3cr

It’s hard to say exactly what causes this crash without the code, but I’d guess it’s a MatchError when using code like the above but without with, turning <- to =

For an expression with one statement in the “happy path” of a with, case will be more readable:

  def get_status(id) do
    case :ets.lookup(:task_registry, id) do
      [{id, status}] -> {:ok, {id, status}}
      [] -> {:error, :file_not_found}
      _ -> {:error, :unknown}
    end
  end
— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
yarrichar
I’m very new to Elixir, so sorry if this is a silly question: I am wondering what happens to the mailbox of a process when the machine i...
New
pragdave
How do I tell Hologram not to escape HTML when substituting into templates? {Textile.render(@product.long_description)} escapes the HTM...
New
Fl4m3Ph03n1x
Background When trying to execute mix release on a Windows 11 machine for a Phoenix project I get the following error: * assembling mark...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
rlipscombe
I’d like to create a file with 600 permissions (rw-------), but there’s a race condition if I create it and then change the permissions. ...
New

Other Trending Topics Top

dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
raa-ziq
Hi everyone :waving_hand: I wanted to share something I’ve been building — NowBlind, a random chat app designed to help people discover ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New
kip
Localize is the next generation localisation library for Elixir. Think of it as ex_cldr version 3.0. The first version will be released ...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews