mmmrrr
Executing raw SQL fails with `cannot insert multiple commands into a prepared statement`
I need to include multiple legacy migrations (written in plain SQL) in an ecto migration.
The current legacy application relies heavily on custom ENUM types in postgresql.
When I try to run the existing migrations (concatenated as a string) via execute my_combined_sql I will get the error cannot insert multiple commands into a prepared statement.
The minimal example of a failing SQL file is:
CREATE TYPE UState AS ENUM ("state1", "state2");
CREATE TABLE IF NOT EXISTS Users
(userEmail VARCHAR(320) NOT NULL PRIMARY KEY,
state UState NOT NULL);
Is there a way to do this with ecto, or do I need another process to apply the legacy migrations to the database?
Marked As Solved
kip
Now I’ve paid a little more attention… I believe the issue is that you can’t create the Enum in the same transaction as using it.
Typically what I do in this case is actually prepare two migrations: one to create the Enum and the other to create the table.
However should be perfectly ok to:
def up do
execute "CREATE TYPE UState AS ENUM (\"state1\", \"state2\");"
execute """
CREATE TABLE IF NOT EXISTS Users
(userEmail VARCHAR(320) NOT NULL PRIMARY KEY,
state UState NOT NULL);
"""
end
Also Liked
NobbZ
Why a macro at all? If you had written it as a function, then there would be no noeed to quote and unquote…
def up do
execute_sql_as_one_per_line(file_reader())
end
def execute_sql_as_one_per_line(sql_list) do
Enum.each(sql_list, &execute/1)
end
Or even simpler, have it inline:
def up do
Enum.each(file_reader(), &execute/1)
end
mmmrrr
Great! That worked. It needed a little cleanup in the sql files in order to work, but it does now.
For anyone interested: If you have a List/Array of sql statements, you can use a simple macro like:
defmacro execute_sql_as_one_per_line(sql) do
quote do
Enum.each(unquote(sql), fn statement ->
execute(statement)
end)
end
end
in your up migration:
def up do
sql = file_reader()
execute_sql_as_one_per_line(sql)
end
kip
By default Ecto uses prepared statements (this is like a precompiled form of the statement which is the cached so that reuse is materially faster).
There is an option prepare: :unnamed which I think goes on the Repo configuration (its a Postgrex adapter option) but I can’t recall and I’m in China this week so googling isn’t an option.
Sorry its an incomplete answer but hopefully thats enough to get you started…
Last Post!
mmmrrr
Hm. Good point.
I somehow assumed the execute statement would not allow to be called at runtime… now that I think of it, it’s probably stupid ![]()
Thanks for the input ![]()
Popular in Questions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #elixirconf-us
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #security
- #hex









