lpvm

lpvm

Exercism secred_handshake help list

I’ve built the following code (reverse not implemented) to solve the secret_handshake problem at exercism.io.

But the first test fails..

test Create a handshake for a number wink for 1 (SecretHandshakeTest)                                               
     secret_handshake_test.exs:13                                                                                        
     Assertion with == failed                                                                                            
     code:  assert SecretHandshake.commands(1) == ["wink"]                                                               
     left:  ["wink", nil]                                                                                                
     right: ["wink"]                                                                                                     
     stacktrace:                                                                                                         
       secret_handshake_test.exs:14: (test)     

There’s a ["wink", nil] instead of a ["wink"] for the 1 case, and I can’t figure out why this is happening.

defmodule SecretHandshake do
  @doc """
  Determine the actions of a secret handshake based on the binary
  representation of the given `code`.

  If the following bits are set, include the corresponding action in your list
  of commands, in order from lowest to highest.

  1 = wink
  10 = double blink
  100 = close your eyes
  1000 = jump

  10000 = Reverse the order of the operations in the secret handshake
  """
  @spec commands(code :: integer) :: list(String.t())
  def commands(code) do
    in_binary = decimalToBinary code
    to_reverse = true and rem(code, 10000)
    commands = []

    commands = if div(in_binary, 1000) == 1, do: [getAction(1000)] ++ commands
    commands = if div(in_binary, 100) == 1, do: [getAction(100)] ++ commands
    commands = if div(in_binary, 10) == 1, do: [getAction(10)] ++ commands
    commands = if rem(in_binary, 2) == 1, do: [getAction(1)] ++ commands
  end

  defp getAction(dec) do
    case dec do
      1 -> "wink"
      10 -> "double blink"
      100 -> "close your eyes"
      1000 -> "jump"
    end
  end

  defp decimalToBinary(dec) do
    dec
    |> Integer.to_string(2)
    |> String.to_integer
  end
end

Marked As Solved

NobbZ

NobbZ

Each of this lines will return nil from its implicit else branch.

I am not sure though, why your result is ["wink", nil], it should be ["wink" | nil].

You should try to do some other approach by creating a list of tuples, where the first element is the bit that has to be set, the other is the word to put in the command. Then you simply fold over that list.

Something like this:

[{0, "wink"}, {1, "double blink"}, {2, "close your eyes"}, {3, "jump"}]
|> Enum.fold([], fn {bit, cmd}, acc ->
  if bit_set?(code, bit), do: [cmd | acc], else: acc
end)
|> Enum.reverse()

bit_set?/2 is easily implementable using the Bitwise module.

Where Next?

Popular in Questions Top

chrisalley
ExUnit now has describe blocks which is a welcome addition coming from RSpec. In the docs, it states that nested hierarchies of describe ...
New
electic
Hi, I am new to Elixir. I am trying to use the DateTime component to insert a date into MySQL however the there seems to be no way to fo...
New
ovidiubadita
Hey all, I discovered Elixir and I love it. I always wanted to learn a functional programming and I intended to go for Haskell, but afte...
New
jay1
Why is it that the mnesia database isn’t the most preferred database for use in Elixir/Phoenix?
New
beno
I will often find my self writing things similar to: case some_value do nil -> something() "" -> something() _ -> somethi...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
SoCreat
i’m a new one to elixir which editor can i use vs code? or atom? Thanks! :smiley:
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
srinivasu
How to handle excepions in elixir? Suppose i have A, B, C ,D, E modules. and each module has get() function. A.get() method will call t...
New
marick
I had some trouble figuring out how to make many-to-many associations work. Once I got it working, I wrote a blog post. Because I’m a nov...
New

Other popular topics Top

vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
TunkShif
This post is an instruction guide to help you setup your Neovim for Elixir development from scratch. It includes general information on h...
274 41539 114
New
albydarned
Hello all! I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New
chrismccord
As promised, the first release candidate of Phoenix 1.3.0 is out! This release focuses on code generators with improved project structure...
New
JeremM34
Hello, how can I check the Phoenix version ? Thanks !
New
electic
Hi, I am new to Elixir. I am trying to use the DateTime component to insert a date into MySQL however the there seems to be no way to fo...
New
JakeBecker
TL;DR: I’ve just released an implementation of Microsoft’s IDE-independent Language Server Protocol for Elixir. It adds language support ...
1144 53690 245
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
axelson
This post is a wiki (feel free to hit the edit button near the bottom right of this post to add your own changes!) This post collects co...
239 47930 226
New
dogweather
I wrote this comment on r/haskell, and it’s not popular there. :wink: But I think I’m on to something… Haskell reminds me of Java, and e...
New

We're in Beta

About us Mission Statement