lpvm

lpvm OP

I’ve built the following code (reverse not implemented) to solve the secret_handshake problem at exercism.io.

But the first test fails..

test Create a handshake for a number wink for 1 (SecretHandshakeTest)                                               
     secret_handshake_test.exs:13                                                                                        
     Assertion with == failed                                                                                            
     code:  assert SecretHandshake.commands(1) == ["wink"]                                                               
     left:  ["wink", nil]                                                                                                
     right: ["wink"]                                                                                                     
     stacktrace:                                                                                                         
       secret_handshake_test.exs:14: (test)     

There’s a ["wink", nil] instead of a ["wink"] for the 1 case, and I can’t figure out why this is happening.

defmodule SecretHandshake do
  @doc """
  Determine the actions of a secret handshake based on the binary
  representation of the given `code`.

  If the following bits are set, include the corresponding action in your list
  of commands, in order from lowest to highest.

  1 = wink
  10 = double blink
  100 = close your eyes
  1000 = jump

  10000 = Reverse the order of the operations in the secret handshake
  """
  @spec commands(code :: integer) :: list(String.t())
  def commands(code) do
    in_binary = decimalToBinary code
    to_reverse = true and rem(code, 10000)
    commands = []

    commands = if div(in_binary, 1000) == 1, do: [getAction(1000)] ++ commands
    commands = if div(in_binary, 100) == 1, do: [getAction(100)] ++ commands
    commands = if div(in_binary, 10) == 1, do: [getAction(10)] ++ commands
    commands = if rem(in_binary, 2) == 1, do: [getAction(1)] ++ commands
  end

  defp getAction(dec) do
    case dec do
      1 -> "wink"
      10 -> "double blink"
      100 -> "close your eyes"
      1000 -> "jump"
    end
  end

  defp decimalToBinary(dec) do
    dec
    |> Integer.to_string(2)
    |> String.to_integer
  end
end

First 2 of 2 Posts Switch mode

NobbZ

NobbZ

Each of this lines will return nil from its implicit else branch.

I am not sure though, why your result is ["wink", nil], it should be ["wink" | nil].

You should try to do some other approach by creating a list of tuples, where the first element is the bit that has to be set, the other is the word to put in the command. Then you simply fold over that list.

Something like this:

[{0, "wink"}, {1, "double blink"}, {2, "close your eyes"}, {3, "jump"}]
|> Enum.fold([], fn {bit, cmd}, acc ->
  if bit_set?(code, bit), do: [cmd | acc], else: acc
end)
|> Enum.reverse()

bit_set?/2 is easily implementable using the Bitwise module.

lpvm

lpvm OP

You’re right @NobbZ, it’s ["wink" | nil].

Since the input is in decimal, converted the commands’ codes to that scale as well.
Your solution is generalist and functional, mine not so much. Will going to try yours now.
Thanks.

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
roeland
Kia ora, We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New

We're in Beta

About us Mission Statement