lpvm

lpvm

I’ve built the following code (reverse not implemented) to solve the secret_handshake problem at exercism.io.

But the first test fails..

test Create a handshake for a number wink for 1 (SecretHandshakeTest)                                               
     secret_handshake_test.exs:13                                                                                        
     Assertion with == failed                                                                                            
     code:  assert SecretHandshake.commands(1) == ["wink"]                                                               
     left:  ["wink", nil]                                                                                                
     right: ["wink"]                                                                                                     
     stacktrace:                                                                                                         
       secret_handshake_test.exs:14: (test)     

There’s a ["wink", nil] instead of a ["wink"] for the 1 case, and I can’t figure out why this is happening.

defmodule SecretHandshake do
  @doc """
  Determine the actions of a secret handshake based on the binary
  representation of the given `code`.

  If the following bits are set, include the corresponding action in your list
  of commands, in order from lowest to highest.

  1 = wink
  10 = double blink
  100 = close your eyes
  1000 = jump

  10000 = Reverse the order of the operations in the secret handshake
  """
  @spec commands(code :: integer) :: list(String.t())
  def commands(code) do
    in_binary = decimalToBinary code
    to_reverse = true and rem(code, 10000)
    commands = []

    commands = if div(in_binary, 1000) == 1, do: [getAction(1000)] ++ commands
    commands = if div(in_binary, 100) == 1, do: [getAction(100)] ++ commands
    commands = if div(in_binary, 10) == 1, do: [getAction(10)] ++ commands
    commands = if rem(in_binary, 2) == 1, do: [getAction(1)] ++ commands
  end

  defp getAction(dec) do
    case dec do
      1 -> "wink"
      10 -> "double blink"
      100 -> "close your eyes"
      1000 -> "jump"
    end
  end

  defp decimalToBinary(dec) do
    dec
    |> Integer.to_string(2)
    |> String.to_integer
  end
end

Showing Posts 1 to 2

NobbZ

NobbZ

Each of this lines will return nil from its implicit else branch.

I am not sure though, why your result is ["wink", nil], it should be ["wink" | nil].

You should try to do some other approach by creating a list of tuples, where the first element is the bit that has to be set, the other is the word to put in the command. Then you simply fold over that list.

Something like this:

[{0, "wink"}, {1, "double blink"}, {2, "close your eyes"}, {3, "jump"}]
|> Enum.fold([], fn {bit, cmd}, acc ->
  if bit_set?(code, bit), do: [cmd | acc], else: acc
end)
|> Enum.reverse()

bit_set?/2 is easily implementable using the Bitwise module.

lpvm

lpvm OP

You’re right @NobbZ, it’s ["wink" | nil].

Since the input is in decimal, converted the commands’ codes to that scale as well.
Your solution is generalist and functional, mine not so much. Will going to try yours now.
Thanks.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews