Failed file upload test

Alvinkariuki

I’m currently trying to tests file upload functionality for multiple files, here is a snippet of the code in a form

      files =
        file_input(live, "#upload_form", :files, [
          %{
            last_modified: 1_551_913_973,
            name: "file_1.png",
            content: File.read!("test/live/sample.png"),
            size: 512_623,
            type: "image/png"
          },
          %{
            last_modified: 1_551_913_974,
            name: "file_2.png",
            content: File.read!("test/live/sample.png"),
            size: 512_623,
            type: "image/png"
          }
        ])
       
        form_preupload =
        live
        |> form("#upload_form",
            some_form: %{
              user_name: "Employ",
              start_date: "2023-07-19",
            }
          }
        )

      render_upload(
        files,
        "file_1.png"
      )
    
     render_upload(
        files,
        "file_1.png"
      )

    render_submit(form_preupload)

everything works fine till the render submit. to which I get this error

** (RuntimeError) cannot consume uploaded file that is still in progress

the files are being consumed with consume_uploaded_entry/3 in a loop for loop

What could the problem possibly be

5 comments

#file-uploading #liveview #test

0 746 5

2023-08-16 07:20:49 UTC

First 5 of 5 Posts

mcrumm

Phoenix Core Team

It appears you are uploading the same file twice If you change the second file name to "file_2.png" does it work?

Post #1

Alvinkariuki

No, the outcome is still the same

Post #2

mcrumm

Phoenix Core Team

The test code looks fine. Can you share your LiveView code as well?

Post #3

Alvinkariuki

sure thing

here is the liveview code

def update(assigns, socket) do
  socket =
    assigns
    |> allow_upload(:files,
      max_entries: 10,
      accept: ~w(.jpg .jpeg .png .webp .pdf),
      auto_upload: true
    )

  {:ok, socket}
end

def handle_event("update_profile", params, socket) do
  {:noreply,
   socket
   |> maybe_consume_uploads(socket.assigns.profile)}
end

def maybe_consume_uploads(socket, profile) do
  uploaded_files =
    socket
    |> uploaded_entries(:files)
    |> format_and_consume_entries(socket, :files, profile)
end

def format_and_consume_entries({[entry], []}, socket, field, profile) do
  uploaded_file =
    socket
    |> consume_uploaded_entry(entry, fn %{path: path} ->
      file = %Plug.Upload{
        path: path,
        filename: "#{generate_file_name(socket, entry, field)}",
        content_type: entry.client_type
      }

      Profile.update(profile, %{field => file})
    end)

  uploaded_file
end

def format_and_consume_entries({[_ | _] = entries, []}, socket, field, profile) do
  uploaded_fields =
    for {entry, index} <- Enum.with_index(entries, 1) do
      socket
      |> consume_uploaded_entry(entry, fn %{path: path} ->
        file = %Plug.Uploda{
          path: path,
          filename: "#{generate_file_name(socket, entry, field, index)}",
          content_type: entry.client_type
        }

        Profile.update(profile, %{field => file})
      end)
    end

  uploaded_fields
end

def generate_file_name(socket, entry, field, index \\ nil) do
  username =
    if is_nil(index),
      do: "#{socket.assigns.user.fname}_#{socket.assigns.user.lname}",
      else: "#{socket.assigns.user.fname}_#{socket.assigns.user.lname}#{index}"

  case field do
    :files ->
      "file_#{username}"
  end
end

Post #4

trisolaran

Check whether the size value you pass to file_input matches the size of the content. I get the error you’re seeing when they differ.

To be on the safe side, do not hard code the size value but set it directly from the file content. This is what I do in one of my tests:

      file_content = File.read!(Path.join(__DIR__, "two_sigma.csv"))

      file_upload =
        file_input(view, "#resolution_form", :ledes_file, [
          %{
            name: new_file_name,
            type: "text/csv",
            size: byte_size(file_content),
            content: file_content
          }
        ])

Post #5

— All posts loaded —