Konbor704

Konbor704

Recently I started learning elixir for fun and as I’m new to programming in general it is not going too well.
Yesterday I found on the internet an exercise that required me to summarize all Fibonacci numbers less than 4_000_000. I tried doing it like that:

defmodule Fibonacci do
  def fibonacci(number) do
    Enum.reverse(fibonacci_do(number))
  end

  def fibonacci_do(1), do: [0]
  def fibonacci_do(2), do: [1 | fibonacci_do(1)]

  def fibonacci_do(number) when number > 2 do
    [x, y | _] = all = fibonacci_do(number - 1)
    [x + y | all]
  end
end

defmodule Solve do
  def lineOfFi(limit) do
    fib_numbers = Fibonacci.fibonacci_do(limit)
    Enum.sum(Enum.filter(fib_numbers, &(&1 < limit and rem(&1, 2) == 0)))
  end
end

result = Solve.lineOfFi(4_000_000)
IO.puts(result)

The first part is code that I found on the internet (it was supposed to be fast), as calculating the sequence itself completely defeated me. Second part I based on a problem that I solved few days ago.
Unfortunately, this code contains a hidden bug or is so unoptimized that after 5 or 6 minutes of running, it crushes my computer.
I wonder what could be done to improve optimization of this code, that it will be possible to run it at all.

Showing Posts 1 to 2

technusm1

technusm1

Welcome to Elixir community @Konbor704, the problem here is that this code is trying to calculate 4 million fibonacci numbers, NOT fibonacci numbers less than 4_000_000.
See this line:

fib_numbers = Fibonacci.fibonacci_do(limit)

So, your Elixir program is doing a long computation because Fibonacci numbers tend to grow very fast.

If you want to calculate fibonacci numbers, you can use the Stream and Enum modules, specifically look at Stream.unfold:

# This one-liner creates an infinite "list" of numbers from
# which you can extract as many numbers as you want.
# The elements will be calculated on-demand by calling
# the passed function
Stream.unfold({0, 1}, fn {a, b} -> {a, {b, a + b}} end)

Now if you want the first 100 Fibonacci numbers, you can do:

Stream.unfold({0, 1}, fn {a, b} -> {a, {b, a + b}} end)
|> Enum.take(100)

If you want all fibonacci numbers less than 4 million, you can do:

Stream.unfold({0, 1}, fn {a, b} -> {a, {b, a + b}} end)
|> Enum.take_while(fn number -> number < 4_000_000 end)

Further, if you want to sum the numbers, you can pipe the above output to Enum.sum.

Enjoy learning Elixir and have fun solving problems. :slight_smile:

EDIT: I would also suggest looking at the Elixir pipe operator ( |> operator). It is one of the most loved features of Elixir and you’ll soon find out how you can improve your code to make it more readable and how it also helps to understand the parameter positions for a function in a given module (thus allowing you to easily understand and making it easier to memorize standard library module functions!)

Konbor704

Konbor704 OP

Thank you so much for explanation.

— All posts loaded —

Where Next? Top

Trending in Questions Top

Hellowman
Hello everyone! I am new to coding with Elixir/Erlang. And i am looking for some utilities for fuzzing testing like AFL++. Does anyone ...
New
yarrichar
I’m very new to Elixir, so sorry if this is a silly question: I am wondering what happens to the mailbox of a process when the machine i...
New
pragdave
How do I tell Hologram not to escape HTML when substituting into templates? {Textile.render(@product.long_description)} escapes the HTM...
New
mandar1045
I load tested a plain Phoenix chat app backed by Postgres with 100 million messages in it, everything on default settings, to see what br...
New
Fl4m3Ph03n1x
Background When trying to execute mix release on a Windows 11 machine for a Phoenix project I get the following error: * assembling mark...
New
rlipscombe
I’d like to create a file with 600 permissions (rw-------), but there’s a race condition if I create it and then change the permissions. ...
New
saleyn
Is there a way to import record definitions in the iex shell for pretty printing (similar to the rr command in the erl shell)? This woul...
New

Other Trending Topics Top

GenericJam
Edit: 2026 May 15 - This post is archived. Mob is alive!! Main docs: mob v0.7.11 — Documentation A bit of explanation for the slightly c...
261 13183 112
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New
kip
Localize is the next generation localisation library for Elixir. Think of it as ex_cldr version 3.0. The first version will be released ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews