Konbor704

Konbor704

Recently I started learning elixir for fun and as I’m new to programming in general it is not going too well.
Yesterday I found on the internet an exercise that required me to summarize all Fibonacci numbers less than 4_000_000. I tried doing it like that:

defmodule Fibonacci do
  def fibonacci(number) do
    Enum.reverse(fibonacci_do(number))
  end

  def fibonacci_do(1), do: [0]
  def fibonacci_do(2), do: [1 | fibonacci_do(1)]

  def fibonacci_do(number) when number > 2 do
    [x, y | _] = all = fibonacci_do(number - 1)
    [x + y | all]
  end
end

defmodule Solve do
  def lineOfFi(limit) do
    fib_numbers = Fibonacci.fibonacci_do(limit)
    Enum.sum(Enum.filter(fib_numbers, &(&1 < limit and rem(&1, 2) == 0)))
  end
end

result = Solve.lineOfFi(4_000_000)
IO.puts(result)

The first part is code that I found on the internet (it was supposed to be fast), as calculating the sequence itself completely defeated me. Second part I based on a problem that I solved few days ago.
Unfortunately, this code contains a hidden bug or is so unoptimized that after 5 or 6 minutes of running, it crushes my computer.
I wonder what could be done to improve optimization of this code, that it will be possible to run it at all.

Showing Posts 1 to 2

technusm1

technusm1

Welcome to Elixir community @Konbor704, the problem here is that this code is trying to calculate 4 million fibonacci numbers, NOT fibonacci numbers less than 4_000_000.
See this line:

fib_numbers = Fibonacci.fibonacci_do(limit)

So, your Elixir program is doing a long computation because Fibonacci numbers tend to grow very fast.

If you want to calculate fibonacci numbers, you can use the Stream and Enum modules, specifically look at Stream.unfold:

# This one-liner creates an infinite "list" of numbers from
# which you can extract as many numbers as you want.
# The elements will be calculated on-demand by calling
# the passed function
Stream.unfold({0, 1}, fn {a, b} -> {a, {b, a + b}} end)

Now if you want the first 100 Fibonacci numbers, you can do:

Stream.unfold({0, 1}, fn {a, b} -> {a, {b, a + b}} end)
|> Enum.take(100)

If you want all fibonacci numbers less than 4 million, you can do:

Stream.unfold({0, 1}, fn {a, b} -> {a, {b, a + b}} end)
|> Enum.take_while(fn number -> number < 4_000_000 end)

Further, if you want to sum the numbers, you can pipe the above output to Enum.sum.

Enjoy learning Elixir and have fun solving problems. :slight_smile:

EDIT: I would also suggest looking at the Elixir pipe operator ( |> operator). It is one of the most loved features of Elixir and you’ll soon find out how you can improve your code to make it more readable and how it also helps to understand the parameter positions for a function in a given module (thus allowing you to easily understand and making it easier to memorize standard library module functions!)

Konbor704

Konbor704 OP

Thank you so much for explanation.

— All posts loaded —

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
Onor.io
I have what I’ve heard referred to as a “lookup table” in my database. This is a way of assigning codes to common values. One common lo...
New
jaybe78
Hello, I’m developing a online persistent chat system (what’s app) like using elixir/dynamodb/aws for a mobile app(flutter). The diffic...
New
Trolleger
What approach to take when sending live updates to “random” users Hi! I have a question, I have a little chat app, and when I create a DM...
New
matt-savvy
Anyone here using Honeybadger? My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of Bandit.HTTPError...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New

Other Trending Topics Top

garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
wintermeyer
There are three potential reasons for members of this forum to have a look at https://vutuv.de You are tired or annoyed of LinkedIn. Yo...
New
webofbits
Aludel - LLM Evaluation Workbench Aludel is an embeddable Phoenix LiveView dashboard for evaluating and comparing LLM prompts across mult...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews