Formatter breaking code by adding new lines below `attr/3`

Phoenix Forum Questions / Help
,
1

I’ve come across a few instances recently where the built-in formatter is breaking otherwise working code. As an example, take a Phoenix component with a moderately long default string attribute:

attr :text_color, :string, default: "text-gray-900 hover:text-primary-700 dark:text-gray-400 dark:hover:text-white"
attr :border, :string, default: "border focus:outline-none"

def button(assigns) do

end

This code works fine, except that with default settings the text_color attribute gets broken into 2 lines and a new line added below:

attr :text_color, :string,
    default: "text-gray-900 hover:text-primary-700 dark:text-gray-400 dark:hover:text-white"

attr :border, :string, default: "border focus:outline-none"

def button(assigns) do

end

The additional line between the two attr/3 statements breaks the component and results in a compiler error.

I’ve worked around this by adding line_length: 120 to my .formatter.exs file, but this is not an ideal workaround. I’m struggling to find a way to override the rule that’s causing this to break; can it be set to ignore attr/3 line length, for example, or even not apply the rule in this file type?

2

Newlines shouldn’t be a problem. E.g. the CoreComponents phoenix generates do have such attr defintions as well and I’ve not seen anyone have problems with that. By my understanding attr simply aggregates all attr invokations between functions, no matter the whitespace or other (valid) syntax between the individual attr calls.

If that’s a problem on your end I’d argue that’s a bug somewhere, not a problem with the formatter.

Can you post the error you’re getting?

1 Like
3

This absolutely is not a compiler error, can you post the error you are getting? Which would have been helpful in your first post, it helps us assist with less back and forth.

4

You’re completely right, I seem to have made an error elsewhere and somehow thought it was a compiler error. My mistake, thanks for your inputs!