Gringotts: A complete payment library for Elixir and Phoenix Framework

[josevalim]

@michalmuskala

Why is the project using GenServers in the middle? It should be perfectly enough to have “just” modules and functions. The worker process does not use the state in any way, so the only thing it does, is creating a bottleneck in the system.

Hi @pkrawat1 and team, I would like to reinforce the point above.

Using a GenServer when you don’t need one is an anti-pattern and it will actually have severe applications on the system performance, as you put all operations besides a single process which will become a bottleneck. We cover this in detail in Adopting Elixir and there is a thread about this particular topic in the forum.

Even if you may end-up using the worker for configuration, I would ask you to revisit that, because it should not be the place of libraries to impose a stateful configuration mechanism. Simply ask the users to pass the configuration every time the gateway is called. If the users of your library need to store this configuration somewhere, they can easily do so by using an Agent, application config, GenServer, etc.

[ashish173]

Thanks for your feedback! yes, we realised it after @michalmuskala’s feedback!

We have been working on it and merged the PR 2 days back.

We have got rid of the worker and Gringotts does not start any application now.

[josevalim]

@ashish173

We have been working on it and merged the PR 2 days back.

Apologies for my at least - but probably more - 2 days late feedback.

[ashish173]

It’s our pleasure that we even got your attention and more importantly your feedback. We are thankful!

We are planning on adding as many as 22 new gateways in next 2 months would be exciting to have 30 to 32 gateways by June.

[wojtekmach]

@kip

I’ve released ex_money version 2.0.0 which no longer supports a float as a parameter to the factory method Money.new/2 (it will return an error or raise on the ! method).

Decimal v1.5.0 has just been released with similar change: passing floats to Decimal.new is soft deprecated (no warnings emitted yet) and there is now a new function to do that explicitly: Decimal.from_float.

Thanks everyone for feedback in this thread!

[OvermindDL1]

@wojtekmach

Decimal v1.5.0 has just been released with similar change: passing floats to Decimal.new is soft deprecated (no warnings emitted yet) and there is now a new function to do that explicitly: Decimal.from_float.

Definitely a great move there!

A question, does the Decimal.from_float also accept an accuracy in it? So you can tell it to only accept to 2 decimal places or so (and in what base)?

[wojtekmach]

A question, does the Decimal.from_float also accept an accuracy in it?

No, it just accepts the float to convert, see: Decimal — Decimal v2.1.1.

[ashish173]

Release update 1.1.0

We are super excited about the release of gringotts 1.1.0.

Added

• api: Introduces a Money protocol (#71)
• core: Introduces Response.t (#119)
• development: Adds a useful mix task gringotts.new (#78)
• docs: Adds changelog, contributing guide (#117)

Changed

• api: Deprecates use of floats for money amounts, check issue #62 (#71)
• core: Removes payment worker, no application, no worker now after @josevalim, @michalmuskala pointed it]jose-feedback (#118)

We are very thankful for all the awesome and super useful feedback given by you all

What’s next?

We are working on adding more gateways, we are expecting to have 18-20 new gateways by mid of May.

PS: We are working on something cool internally apart from gringotts and expect it to present it to you all by mid of May.

[jpinnix]

I noticed this library hasn’t had any commits since Oct 25, 2018, and that the demo https://gringottspay.herokuapp.com/ is no longer live. Is this no longer in development?

[ashish173]

@jpinnix we are taking any PR’s and issues and fixing them. Also planning some more gateways this summer. Let us know if you have any questions.

[jpinnix]

We may have to start using liveness advisories in the Elixir community like they do on some Clojure projects like: https://github.com/candera/causatum#liveness-advisory

[Cochonours]

What would be nice would be for such advisories to be in the code, so that scripts could automatically run from time to time and update curated lists of live libraries. It would solve the usual problem that especially new users have concerning which libraries are nice and current!