Help to make (and understand) better and beautiful code

if i understood it correctly the struct that you’re using seems to be an internal abstraction. so why not internalize the digest_length and the block_length in the struct, this way you can always have it available on the function head by just destructing it and keep the same guard validations.

Are you sure you got all the references? This take(134) seems extremely suspicious - it’s two less than @block_length for @digest_length == 32 in 256-bit, but not changed for 512-bit where @digest_length is different.

https://github.com/N-0x90/keccak_ex/blob/master/lib/hash/hash512.ex#L86

Your right!!! also that pointed me to an edge case…

The correct version is:

  defp padding(%__MODULE__{} = value) do
    fix = if (value.input_length + 1) == byte_size(value.buffer) do
      value.buffer
      |> binary_part(0, value.input_length)
      |> set_value(<<0x81>>)

Nice one, already applied, thanks!!!