N0x90

N0x90

Help to make (and understand) better and beautiful code

Years ago i worte keccak_ex with only support for hash 256

Now I completed the support for hash 512 and 128 bytes

The “problem”
Both implementation are the same ( :upside_down_face: copy and paste) and just change

for hash 256

  @digest_length 32

  @block_length 200 - 2 * @digest_length

for hash 512

  @digest_length 64

  @block_length 200 - 2 * @digest_length

i thik something like an “interface/inheritance” can help with all the duplicated code making an isolation with the concret type but i cant find anything like that

the other problematic line is

defp process_block_decode_loop(%__MODULE__{} = value, index) when index < @block_length do

because you need the block_length to make the loop work…

i appretiate any idea/insight/suggestion to make the code looks better and to learn a better way

First Post! Switch mode

cevado

cevado

if i understood it correctly the struct that you’re using seems to be an internal abstraction. so why not internalize the digest_length and the block_length in the struct, this way you can always have it available on the function head by just destructing it and keep the same guard validations.

Last Post!

N0x90

N0x90

Nice one, already applied, thanks!!!

Where Next?

Trending in Questions Top

jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
saveman71
Hello ! We want new/edit form pages to POST/PUT to their own URL rather than the resources REST defaults (post /things, put /things/:id)...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement