owaisqayum

owaisqayum

I have defined a module GS where genserver will be used and I need to create tables. I have the whole logic of the program In another module named base. How do I inherit handle_call in my genserver GS module ?

GS MODULE:

defmodule GS do
  use GenServer
  @name gen
  # client
  def start_link(opts \\ []) do
    GenServer.start_link(__MODULE__, [], opts ++ [name: gen])
  end

  def creating_tables(tables_list) do
    GenServer.call(@name, {:creating_tables, tables_list})
  end

  # server
  def init(initial_state) do
    {:ok, initial_state}
  end
end

BASE MODULE

defmodule Base do
  def handle_call({:creating_tables}, _from, state_tables_list) do
    tables = Enum.map(state_tables_list, fn table -> create(table) end)
    {:reply, tables, state_tables_list}
  end

  defp create(table) do
    try do
      :ets.new(table, [:named_table, :bag])
    rescue
      ArgumentError -> table
    end
  end
end

First 9 of 9 Posts Switch mode

Laetitia

Laetitia

Why do you want to extract this function from the GS module? Do you want to create an extended genserver?

I think handle_call has to be in the genserver module as it is a callback implementation.
If you want, you can extract the logic of the table creation in another module and use it in your genserver.

owaisqayum

owaisqayum OP

Thanks for such a prompt response. Actually, I will have other features in my Base module which i want to affiliate with other genserver. Keeping them under ‘GS’ will make it crowded.

Laetitia

Laetitia

I will be happy to help. I need more infos.
Why it is a Base? What is the role of this module?

owaisqayum

owaisqayum OP

So Base is like a Base table in database where tables can be created or deleted and also can add or delete data from it. GS will be a genserver module where i can create multiple tables concurrently and later in my program add data to tables concurrently.

Laetitia

Laetitia

In this case, keep the handle_call function in GS. The Base module is a TableCreator (surely, you can find a better name)

defmodule TableCreator do
   def create_tables(tables) when is_list(tables) do
      tables |> Enum.map(fn table -> create(table) end)
   end

  defp create(table) do
    try do
      :ets.new(table, [:named_table, :bag])
    rescue
      ArgumentError -> table
    end
  end
end

and in the genserver module the function handle_call would be

def handle_call({:creating_tables}, _from, state_tables_list) do
    tables = TableCreator.create_tables(state_tables_list)
    {:reply, tables, state_tables_list}
  end

i hope it helps :wink:

owaisqayum

owaisqayum OP

So, Basically i must have to use handle call inside my GenServer.

gregvaughn

gregvaughn

I agree with @Laetitia and will add that handle_call and the tuple it returns is your contract with GenServer. That logic belongs in the GenServer callback module. But you can certainly call out to shared logic in another module in the body of the function.

I’d also caution you about bottlenecking your system. You seem to want to make it easy to create multiple ets tables. Those are owned by a process for lifecycle management purposes and you’re not making them public (nor are you accepting a parameter to do so) so all access will have to go through a single GenServer, which only handles a single message at a time.

owaisqayum

owaisqayum OP

Yes, I agree, and thanks a lot for such valuable feedback. Actually, I will make each :ets table a separate table. So, all the entries to a single table are handled by a separate process. I was wrong initially when I stated that each would have a separate process. Thanks for correcting me.

lud

lud

You must define handle_call/3 in the module you give to GenServer.start_link/3.

Your code:

 GenServer.start_link(__MODULE__, [], opts ++ [name: gen])

Here you give __MODULE__, so you give GS.

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
roeland
Kia ora, We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
rahultumpala
Hello, I have an Elixir backend that implements a custom protocol over TCP. I want to load test the backend and assess the performance o...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New

We're in Beta

About us Mission Statement