aaronrenner

aaronrenner

Phoenix Core Team

I’m trying to write a couple macros that define either a public or private functions. Here’s an example

defmodule Defs do
  defmacro mydef(name, do: block) do
    quote do
      def unquote(name), do: unquote(block)
    end
  end

  defmacro mydefp(name, do: block) do
    quote do
      defp unquote(name), do: unquote(block)
    end
  end
end

# Example usage
mydefp hello do
 :world 
end 

Since the functions that are being written are exactly the same except for def/defp, I’d like to extract the function writing logic into a common place

defmodule Defs do
  defmacro mydef(name, do: block), do: do_def(name, block, :def)

  defmacro mydefp(name, do: block), do: do_def(name, block, :defp)

  defp do_def(name, block, visibility) do
    #What goes here?
  end
end

Since def is just a macro on Kernel, I rewrote my macros to look like they were writing function calls.

defmodule Defs do
  defmacro mydef(name, do: block) do
    quote do
      Kernel.def(unquote(name), do: unquote(block))
    end
  end

  defmacro mydefp(name, do: block) do
    quote do
      Kernel.defp(unquote(name), do: unquote(block))
    end
  end
end

From there, it seemed that I should be able to use apply/3 to dynamically call def or defp.

defmodule Defs do
  defmacro mydef(name, do: block), do: do_def(name, block, :def)

  defmacro mydefp(name, do: block), do: do_def(name, block, :defp)

  defp do_def(name, block, visibility)
    apply(Kernel, unquote(visibility), [unquote(name), do: unquote(block)])
  end
end

However, when I use this macro in a module:

defmodule Greeter do
  import Defs
  
  mydef hello do
    :world 
  end

I get the following error:

** (CompileError) iex:3: undefined function hello/0
    (stdlib) lists.erl:1354: :lists.mapfoldl/3
    (stdlib) lists.erl:1355: :lists.mapfoldl/3
    (my_app) expanding macro: Defs.mydef/2

Long question short, how do I dynamically call def or defp so I can share the rest of the logic between my macros?

Showing Posts 1 to 4

Qqwy

Qqwy

TypeCheck Core Team

In your second example, you seem to have lost the quote blocks around the macro definitions, which is probably the source of your problems.

aaronrenner

aaronrenner OP

Phoenix Core Team

In this example, I was thinking the unquote would go inside do_def/3.

mudasobwa

mudasobwa

Creator of Cure

The main issue here is: one cannot unquote outside of the quote. That said, you cannot call unquote inside your private function. The good news would be, you don’t need it at all, just construct an AST:

defmodule Defs do
  defmacro mydef(name, do: block),
    do: do_def(name, block, :def)

  defmacro mydefp(name, do: block),
    do: do_def(name, block, :defp)

  defp do_def(name, block, visibility) do
    {{:., [], [{:__aliases__, [alias: false], [:Kernel]}, visibility]},
      [], [name, [do: block]] }
  end
end

defmodule Greeter do
  import Defs
  
  mydef hello do
    :world 
  end
end

IO.puts Greeter.hello
#⇒ world
Qqwy

Qqwy

TypeCheck Core Team

There is nothing preventing you from calling

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews