unfode

unfode

How to achieve atomicity (all or nothing)?

Suppose I have two states. In C, I can mutate them atomically (either all or none are mutated) using locks:

bool atomic_mutation() {
  lock(state1_lock);
  lock(state2_lock);

  bool success = mutate1(state1);
  if (!success) {
    unlock(state1_lock);
    unlock(state2_lock);
    return false;
  }

  success = mutate2(state2);
  if (!success) {
    // revert mutate1(state1)
    unlock(state1_lock);
    unlock(state2_lock);
    return false;
  }

  unlock(state1_lock);
  unlock(state2_lock);
  return true;
}

I’m new to Elixir. What I’ve learned is that I normally use an Agent to manage a state. But how to achieve atomicity shown above in Elixir? Thanks!

Edit: I fixed the bug in the C code above as pointed out by @al2o3cr

Marked As Solved

al2o3cr

al2o3cr

The BEAM provides the infrastructure, but you need to write the code to glue things together into a consistent distributed system - and to be clear, once you have TWO GenServers you’re trying to make change together you’re in distributed-system territory.

For instance, here’s a very basic “table with a lock” GenServer (see below for notes):

defmodule TableWithLock do
  use GenServer

  defstruct [:data, :owner]

  def unlock(pid), do: GenServer.call(pid, :unlock)
  def lock(pid), do: GenServer.call(pid, :lock)
  def update(pid, fun), do: GenServer.call(pid, {:update, fun})

  @impl true
  def init(data) do
    {:ok, %__MODULE__{data: data, owner: nil}}
  end

  @impl true
  def handle_call(:lock, {pid, _tag}, state) do
    cond do
      is_nil(state.owner) ->
        # unlocked, pid now owns lock
        {:reply, :ok, %{state | owner: pid}}

      state.owner == pid ->
        # already locked by pid
        {:reply, :ok, state}

      true ->
        # locked by another process
        raise "oh no lock contention"
    end
  end

  def handle_call(:unlock, {pid, _tag}, state) do
    cond do
      is_nil(state.owner) ->
        # already not locked
        raise "somebody already unlocked this???"

      state.owner == pid ->
        # locked by the caller
        {:reply, :ok, %{state | owner: nil}}

      true ->
        # locked by somebody else
        raise "unlocking somebody else's lock"
    end
  end

  def handle_call({:update, fun}, {pid, _tag}, state) do
    cond do
      is_nil(state.owner) ->
        # not locked
        raise "not locked"

      state.owner == pid ->
        # locked by the caller
        result = fun.(state.data)
        {:reply, result, %{state | data: result}}

      true ->
        # locked by somebody else
        raise "updater not holding the lock"
    end
  end
end

{:ok, pid1} = GenServer.start_link(TableWithLock, [1,2,3])

:ok = TableWithLock.lock(pid1)

result = TableWithLock.update(pid1, fn data -> Enum.map(data, & &1*2) end)

:ok = TableWithLock.unlock(pid1)

IO.inspect(result)

There are a LOT of places where this could be work better / handle concurrency better:

  • crashing the table when a second process tries to take the lock is not realistic. A better implementation would keep a queue of pids that are currently trying to take the lock in lock and pick the next one to reply to in unlock.
  • crashing the table on bogus unlocks isn’t realistic either. An alternative would be to return something from handle_call that the implementation of unlock/1 could use to crash the calling process, since unlocking a table that you haven’t locked is a logic error
  • if a process dies while holding the lock, it will never be unlocked. Tools like Process.monitor can help with this, at the cost of additional complexity.

Expanding this setup to TWO tables adds some extra complications:

  • if process A takes lock 1 and then tries to take lock 2, while at the same time process B takes lock 2 and tries to take lock 1 the system is in a classic DEADLOCK situation. The default 5s timeout on GenServer.call will eventually pick a winner, but real systems will detect this and complain

  • coordinating changes to ensure that they either all appear or all do not is still just as tricky as always. You’d need a third process to coordinate the TableWithLocks and roll back changes if a future change fails.

    Note that even the code in your example does not produce atomicity - if mutate2 returns false, the changes from mutate1 are still visible.

    Solving this problem correctly is capital-H Hard and the solutions are highly sensitive to exactly what tradeoffs your particular application can tolerate.

Also Liked

benwilson512

benwilson512

Author of Craft GraphQL APIs in Elixir with Absinthe

I would simply use the database itself for this, it will provide a ton of dedicated tooling for it.

codeanpeace

codeanpeace

If you’re using Ecto, it has a built in way of achieving this via Ecto.Multi

Ecto.Multi is a data structure for grouping multiple Repo operations.

Ecto.Multi makes it possible to pack operations that should be performed in a single database transaction…

defmodule PasswordManager do
  alias Ecto.Multi

  def reset(account, params) do
    Multi.new()
    |> Multi.update(:account, Account.password_reset_changeset(account, params))
    |> Multi.insert(:log, Log.password_reset_changeset(account, params))
    |> Multi.delete_all(:sessions, Ecto.assoc(account, :sessions))
  end
end
LostKobrakai

LostKobrakai

How do you make sure multiple actors changes are actually independent?

In the end you’ll surely get to the fact that immutability prevents certain optimizations, but generally the question should be how much those matter to the endproduct.

Last Post!

codeanpeace

codeanpeace

If you’re using Ecto, it has a built in way of achieving this via Ecto.Multi

Ecto.Multi is a data structure for grouping multiple Repo operations.

Ecto.Multi makes it possible to pack operations that should be performed in a single database transaction…

defmodule PasswordManager do
  alias Ecto.Multi

  def reset(account, params) do
    Multi.new()
    |> Multi.update(:account, Account.password_reset_changeset(account, params))
    |> Multi.insert(:log, Log.password_reset_changeset(account, params))
    |> Multi.delete_all(:sessions, Ecto.assoc(account, :sessions))
  end
end

Where Next?

Popular in Questions Top

rms.mrcs
Hi, I need to transform a list of numbers into a map where the keys are the indexes and the values are the original values of the list. ...
New
electic
Hi, I am new to Elixir. I am trying to use the DateTime component to insert a date into MySQL however the there seems to be no way to fo...
New
minhajuddin
I have seen a lot of code which picks the first element from a list using Enum.at(0) instead of List.first. Is there a reason why people ...
New
Brian
What is the proper way to load a module from a file in to IEX? In the python world, doing something like this pretty standard: from ....
New
openscript
Hello! Sorry for this astonishing simple question, but I’m really stuck. I try to set up the intellij-elixir plugin, but I don’t know ho...
New
Fl4m3Ph03n1x
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: ) Hello all, this is ...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New

Other popular topics Top

ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
shijith.k
I am trying to start a new phoenix project with elixir 1.9, but mix phx.new does not work. It says that ** (Mix) The task "phx.new" could...
New
msaraiva
Surface is an experimental library built on top of Phoenix LiveView and its new LiveComponent API that aims to provide a more declarative...
564 44139 214
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID<0.412.0> terminating ** (Postgrex.Error) FATAL...
New
Harrisonl
We have an ECS cluster with 4 services, where each task joins a single cluster, via discovery ECS discovery service. Currently when I de...
New

We're in Beta

About us Mission Statement