jpcaruana

jpcaruana

How to do a series of validations in Elixir the most idiomatic way

I am new (but curious) to Elixir. I want to validate two aspects of an URL :

  • it should not be an IP adress
  • the path should not contains /../

I have a function:

def validate_url(url) do
  URI.parse(url)
  |> validate_profile
end

After some pattern matching (to exclude other cases), I come to 2 (unstatisfying) solutions :

1st :

defp validate_profile(%URI{scheme: "https", path: path, host: host, userinfo: nil, fragment: nil}),
     do: validate_path(path)
         |> validate_host(host)
<snip code>
defp validate_profile(_), do: :invalid

defp validate_path(path) do
  case String.split(path, ["/../"]) do
    [_ | []] -> :valid
    _ -> :invalid
  end
end

defp validate_host(:invalid, _), do: :invalid
defp validate_host(:valid, host) do
  case :inet.parse_address(to_charlist(host)) do
    {:ok, _} -> :invalid
    _ -> :valid
  end
end

2nd:

defp validate_profile(%URI{scheme: "https", path: path, host: host, userinfo: nil, fragment: nil}),
     do: validate_path(path, host)
         |> validate_host
<snip code>
defp validate_profile(_), do: :invalid

defp validate_path(path, host) do
  case String.split(path, ["/../"]) do
    [_ | []] -> host
    _ -> :invalid
  end
end

defp validate_host(:invalid), do: :invalid
defp validate_host(host) do
  case :inet.parse_address(to_charlist(host)) do
    {:ok, _} -> :invalid
    _ -> :valid
  end
end

How can I improve here ? Is there a more idiomatic way of doing this ?

Marked As Solved

darkbaby123

darkbaby123

Below is an example to use with. Each validation step only return ok/error tuple. The url is not changed so it can be reused in each step.

@spec validate_url(raw_url :: URI.t() | binary) :: {:ok, URI.t()} | :error
def validate_url(raw_url) do
  with url <- URI.parse(raw_url),
       :ok <- validate_path(url),
       :ok <- validate_host(url) do
    {:ok, url}
  else
    :error -> :error
  end
end

@spec validate_path(URI.t()) :: :ok | :error
defp validate_path(%URI{path: path}) do
  # ...
end

@spec validate_host(URI.t()) :: :ok | :error
defp validate_host(%URI{host: host}) do
  # ...
end

Pipeline is suitable when you have a data structure to express both url and validation result. The simplest data structure is {:ok, url} | :error .

Also Liked

dimitarvp

dimitarvp

This could be a good candidate for using the with keyword.

wanton7

wanton7

I’m no Elixir guru but probably something like this

def parse_url(url) do
  {:ok, URI.parse(url)}
  |> validate_profile()
  |> validate_stuff()
end

defp validate_profile({:ok, url} = data) do
# validate here
# if ok
data
# if error
{:error, "profile validation failed"}
end

defp validate_stuff({:ok, url} = data) do
# validate here
# if ok
data
# if error
{:error, "stuff validation failed"}
end

defp validate_stuff(x), do: x

In case you need to return nil or string if it’s valid use something like

def parse_url(url) do
  {:ok, URI.parse(url)}
  |> validate_profile()
  |> validate_stuff()
  |> case do
    {:ok, url} -> url
    _ -> nil
  end
end
NobbZ

NobbZ

Why?

I can understand why you do not want the server part to be an IP. But why restricting the path to not contain /../?

http://example.com/path/../foo and http://example.com/foo are different URLs. Not every server will interprete .. as “one folder up”.

Where Next?

Popular in Questions Top

vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
Fl4m3Ph03n1x
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: ) Hello all, this is ...
New
JulienCorb
I am trying to implement my new.html.eex file to create new posts on my website. new.html.eex: &lt;h1&gt;Create Post&lt;/h1&gt; &lt;%= ...
New
joeerl
Hello again - after a longish gap I’ve decided I really must dig into Elixir and see what’s been happening here - so I have a few questio...
New
vrod
I am using the Starship cross-shell prompt – it seems pretty nice, but I get some errors: [WARN] - (starship::utils): Executing command ...
New
Brian
What is the proper way to load a module from a file in to IEX? In the python world, doing something like this pretty standard: from ....
New
joaquinalcerro
Hi there, I am working with Ecto-Postgresql and I need to call all of the records from a specific table but the table has 40,000 records...
New
jaysoifer
Is there a way to rollback a specific migration and only that one (“skipping” all the other ones)? Would mix ecto.rollback -v 200809061...
New
dokuzbir
I want to highlight html closing tags when i click a html tag. That works in .html files but doesnt work for html.eex templates. How can...
New

Other popular topics Top

danschultzer
None of the current solutions worked well for me, so I went ahead and built a user management system from scratch. This project took far...
548 29603 241
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
minhajuddin
I have seen a lot of code which picks the first element from a list using Enum.at(0) instead of List.first. Is there a reason why people ...
New
freewebwithme
Using vs code and installed ElixirLS: support and debugger. And I got an error popped up on start up says Failed to run ‘elixir’ comma...
New
nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
rms.mrcs
Hi, I need to transform a list of numbers into a map where the keys are the indexes and the values are the original values of the list. ...
New
PeterCarter
There are pre-rolled solutions for other frameworks that do work. However, Phoenix does not seem to have these. Have people had good expe...
New
sergio
Kind of like when jquery came out, it was super necessary. Existing drag and drop libraries have a bunch of baggage to support old browse...
New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New

We're in Beta

About us Mission Statement