shahryarjb

shahryarjb

How to improve function and remove extra from it's code

Hello, I want to try to improve my code, please see the below code :

def test() do
  with {:ok, %{acl: "admin", info: _info}} <- TrangellApiGateway.User.Login.user_acl_check(allreq),
            {:ok, ms} <- http_error_handeller(conn, Post.name(allreq), "created")  do
            conn
            |> put_status(201)
            |> json(%{message: ms})  
      else
            _ ->
               conn
               |> put_status(400)
               |> json(%{error: "Your request is invalid."}) 
      end
end

Please see the Post.name(allreq), I want to replace some Fun like `Post.other_name(allreq) insted of that, but I dont want to remove the other code of this function.

for exampel

The code concerned should be blow code :

fn 2

def test() do
  with {:ok, %{acl: "admin", info: _info}} <- TrangellApiGateway.User.Login.user_acl_check(allreq),
            {:ok, ms} <- http_error_handeller(conn, Post.other_name(allreq), "created")  do
            conn
            |> put_status(201)
            |> json(%{message: ms})  
      else
            _ ->
               conn
               |> put_status(400)
               |> json(%{error: "Your request is invalid."}) 
      end
end

I just edited Post.other_name(allreq), not anything else .

My friend told me that I could use action_fallback , but I don’t know how to use it in my code , if I can do this , My code will be 80% optimized

How do I do ?

ref :
https://swanros.com/2017/03/04/action-fallback-contexts-phoenix1-3-tiny-controllers/

First 2 of 2 Posts Switch mode

LostKobrakai

LostKobrakai

Pseudo-Code as there are missing parameters in those functions, but it should convey the point. You could pass just the function name or the module and the function.

def test_1(), do: test(:name)
def test_2(), do: test(:other_name)

defp test(function_name) do
  with {:ok, %{acl: "admin", info: _info}} <- TrangellApiGateway.User.Login.user_acl_check(allreq),
            {:ok, ms} <- http_error_handeller(conn, apply(Post, function_name, [allreq]), "created")  do
            conn
            |> put_status(201)
            |> json(%{message: ms})  
      else
            _ ->
               conn
               |> put_status(400)
               |> json(%{error: "Your request is invalid."}) 
      end
end
fuelen

fuelen

I think it is better to pass a lambda as an argument to test function. In this case, compiler can catch errors if function or module doesn’t exist.

def test_1(), do: test(&Post.name/1)
def test_2(), do: test(&Post.other_name/1)
— All posts loaded —

Where Next?

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement