thojanssens1

thojanssens1

How to print changeset errors without using the changeset in form_for?

I have a login page which allows to authenticate an admin.
If there are no users at all in the database (first time the app runs), I will create the superuser based on the login data entered (email/password).

My login form looks like this:

<h1>Login</h1>

<%= form_for @conn,
             Routes.admin_session_path(@conn, :create),
             [as: :session],
             fn f -> %>
  <div>
    <%= text_input f, :email, placeholder: "Email" %>
    <%= error_tag f, :email %>
  </div>

  <div>
    <%= password_input f, :password, placeholder: "Password" %>
    <%= error_tag f, :password %>
  </div>

  <%= submit "Log in" %>
<% end %>

And my controller actions:

def new(conn, _params) do
  render(conn, "new.html")
end

def create(conn, %{"session" => %{"email" => email, "password" => pass}}) do
  case Accounts.authenticate_by_email_and_pass(email, pass) do
    {:ok, %{"active" => true} = user} ->
      conn
      |> MyAppWeb.Authentication.login(user)
      |> put_flash(:info, "Welcome back!")
      |> redirect(to: Routes.admin_question_path(conn, :index))

    {:ok, %{"active" => false}} ->
      conn
      |> put_flash(:error, "Account is disabled")
      |> render("new.html")

    {:error, _reason} ->
      case Accounts.count_users() do
        0 ->
          case Accounts.register_user(%{"name" => "Superuser", "email" => email, "password" => pass, "type" => "admin"}) do
            {:ok, user} ->
              conn
              |> put_flash(:info, "#{user.name} created!")
              |> redirect(to: Routes.admin_session_path(conn, :new))

            {:error, %Ecto.Changeset{} = changeset} ->
              conn
              |> put_flash(:error, changeset.errors)
              |> render("new.html")
          end
        _ ->
          conn
          |> put_flash(:error, "Invalid username/password combination")
          |> render("new.html")
      end
  end
end

Of course as expected I have a problem on this line:
put_flash(:error, changeset.errors)

But as the login form is not displayed based on a changeset (but rather uses the connection: form_for @conn), how do I display the list of changeset errors when the superuser is being attempted to be created?

Marked As Solved

idi527

idi527

:waving_hand:

Check out Ecto.Changeset.traverse_errors/2:

errors = Ecto.Changeset.traverse_errors(changeset, fn {msg, opts} ->
  Enum.reduce(opts, msg, fn {key, value}, acc ->
    String.replace(acc, "%{#{key}}", to_string(value))
  end)
end)

error_msg =
  errors
  |> Enum.map(fn {key, errors} -> "#{key}: #{Enum.join(errors, ", ")}")
  |> Enum.join("\n")

put_flash(conn, :error, error_msg)

Also note that ecto schema structs have atom keys, so these two clauses might not match:

case Accounts.authenticate_by_email_and_pass(email, pass) do
    {:ok, %{"active" => true} = user} -> # <----- this one
      conn
      |> MyAppWeb.Authentication.login(user)
      |> put_flash(:info, "Welcome back!")
      |> redirect(to: Routes.admin_question_path(conn, :index))

    {:ok, %{"active" => false}} -> # <---- and this one
      conn
      |> put_flash(:error, "Account is disabled")
      |> render("new.html")

Also Liked

lucaong

lucaong

Regarding the issue with <br> being literally printed, take a look at raw/1 for the solution :slight_smile:

NobbZ

NobbZ

Or traverse, print and format the errors in the view, rather than the controller…

Last Post!

julismz

julismz

You can put it all together and replace the map + join by map_join

{:error, changeset} ->
        parsed_errors =
          Ecto.Changeset.traverse_errors(changeset, fn {msg, opts} ->
            Enum.reduce(opts, msg, fn {key, value}, acc ->
              String.replace(acc, "%{#{key}}", to_string(value))
            end)
          end)
          |> Enum.map_join("\n", fn {key, errors} -> "#{key} #{Enum.join(errors, ", ")}" end)

Where Next?

Popular in Questions Top

minhajuddin
I have seen a lot of code which picks the first element from a list using Enum.at(0) instead of List.first. Is there a reason why people ...
New
lessless
I believe there are people here who are dealing with CSV files import on the daily basis, and since Excel is a really popular tool there ...
New
PeterCarter
There are pre-rolled solutions for other frameworks that do work. However, Phoenix does not seem to have these. Have people had good expe...
New
bsollish-terakeet
Credo is smart enough to check for (something like) this: assert length(the_list) == 0 with this response: Checking if an enum is empt...
New
shijith.k
I am trying to start a new phoenix project with elixir 1.9, but mix phx.new does not work. It says that ** (Mix) The task "phx.new" could...
New
siddhant3030
Hi, I have to write a raw query for one of my project. But till now I have used ecto queries and don’t have much experience writing raw ...
New
fayddelight
I tried installing elixir 1.11.2 erlang 23.3.4 via asdf in my zsh shell. Enabled the versions locally and globally. When I list them ...
New

Other popular topics Top

nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
chrismccord
Phoenix 1.4.0 released Phoenix 1.4 is out! This release ships with exciting new features, most notably with HTTP2 support, improved deve...
688 31586 112
New
AngeloChecked
What learn first? Rust or Elixir Hi Elixir community! I’m here because i want learn a new language. I’m a junior developer and mainly i ...
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID&lt;0.412.0&gt; terminating ** (Postgrex.Error) FATAL...
New
Harrisonl
We have an ECS cluster with 4 services, where each task joins a single cluster, via discovery ECS discovery service. Currently when I de...
New
AstonJ
Posting this to see if we can make things easier for people to get into Neovim. If you use Neovim and have a favourite distro please let ...
New

We're in Beta

About us Mission Statement