Kapeusz

Kapeusz

How to refactor Enum.reduce?

Hello, I have a problem with properly understanding Enum.reduce but after many tries I managed to get this inside my function to work. However, when I run mix credo --strict I see there’s a refactoring opportunity because the function body is nested too deep. Could you please help me with refactoring this function? I would appreciate an additional explanation. Thank you!

    Enum.reduce(conditions, queryable, fn {k, v}, acc ->
      case {k, v} do
        {_, ""} ->
          acc

        {_, _} when is_atom(k) ->
          case {k in like_fields, k in date_fields} do
            {true, false} -> where_ilike(acc, k, v)
            {false, true} -> where_date(acc, k, v)
            {false, false} -> where(acc, [u], field(u, ^k) == ^v)
          end

        _ ->
          acc
      end
    end)

First Post! Switch mode

josevalim

josevalim

Creator of Elixir

Note that the branching and pattern matching can also be applied to fn and are equivalent:

    Enum.reduce(conditions, queryable, fn
      {_, ""}, acc ->
        acc

      {k, v}, acc when is_atom(k) ->
        case {k in like_fields, k in date_fields} do
          {true, false} -> where_ilike(acc, k, v)
          {false, true} -> where_date(acc, k, v)
          {false, false} -> where(acc, [u], field(u, ^k) == ^v)
        end

      _, acc ->
        acc
    end)

You can also merge the first and third branches:

    Enum.reduce(conditions, queryable, fn
      {k, v}, acc when is_atom(k) and v != "" ->
        case {k in like_fields, k in date_fields} do
          {true, false} -> where_ilike(acc, k, v)
          {false, true} -> where_date(acc, k, v)
          {false, false} -> where(acc, [u], field(u, ^k) == ^v)
        end

      _, acc ->
        acc
    end)
— All posts loaded —

Where Next?

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement