shahryarjb

shahryarjb

How to restart a genserver under DynamicSupervisor which is started under PartitionSupervisor

Hello friends, I think I am creating a bad config for my project.

I have a genserver is started under DynamicSupervisor and I start it with PartitionSupervisor

my Application config:

  def start(_type, _args) do
    children = [
      {Registry, keys: :unique, name: MishkaJobWorkerRegistry},
      {PartitionSupervisor, child_spec: DynamicSupervisor, name: MishkaJobWorkerSupervisor},
    ]

    opts = [strategy: :one_for_one, name: MishkaInstaller.Supervisor]
    Supervisor.start_link(children, opts)
  end

It is my Genserver simple code:

defmodule Queue.Job do
  use GenServer
  require Logger
  
  def start_link(args) do
    id = Map.get(args, :worker)
    type = Map.get(args, :type, :normal)

    GenServer.start_link(__MODULE__, [], name: via(id, type))
  end

  @impl true
  def init(state \\ %{}) do
    {:ok, state}
  end
  
  @doc false
  def child_spec(process_name) do
    %{
      id: __MODULE__,
      start: {__MODULE__, :start_link, [process_name]},
      restart: :transient,
      max_restarts: 4
    }
  end

  defp via(id, value) do
    {:via, Registry, {MishkaJobWorkerRegistry, id, value}}
  end
end

and I start like this:

  def start_job_worker(args) do
    DynamicSupervisor.start_child(
      {:via, PartitionSupervisor, {MishkaJobWorkerSupervisor, self()}},
      {Queue.Job, args}
    )
  end

But if my genserver crashes unexpectedly, it does not reset it and when I check the process of my genserver , it returns false.

Another problem is

when I use this to terminate one of genserver by pid, it returns not found

DynamicSupervisor.terminate_child(MishkaJobWorkerSupervisor, pid)

Where I am creating a bug?

Thank you in advance

Marked As Solved

alisinabh

alisinabh

when I use this to terminate one of genserver by pid, it returns not found

DynamicSupervisor.terminate_child(MishkaJobWorkerSupervisor, pid)

Where I am creating a bug?

The problem is that you are referencing the wrong name here. MishkaJobWorkerSupervisor is not the name that you should use. If you pay close attention to how the process is started here you can see that the :via tuple has been used. To terminate the child, you need to use the same via tuple.

  def start_job_worker(args) do
    DynamicSupervisor.start_child(
      {:via, PartitionSupervisor, {MishkaJobWorkerSupervisor, self()}},
      {Queue.Job, args}
    )
  end

So to terminate you can do something like

DynamicSupervisor.terminate_child(
  {:via, PartitionSupervisor, {MishkaJobWorkerSupervisor, self()}}, 
  # Remember that because you used self() for the partition key, you need to call this from the same process or replace self() with the correct pid.
  pid
)

Also Liked

al2o3cr

al2o3cr

This line is the problem - MishkaJobWorkerSupervisor is the PartitionSupervisor, so the PID isn’t found because it’s a child of one of the supervisor’s children.

The call doesn’t crash because DynamicSupervisor.terminate_child sends a {:terminate_child, pid} message, which is handled by the machinery for :supervisor.terminate_child.

To accurately target the message, you need to use a :via tuple pointing to the PartitionSupervisor:

{:via, PartitionSupervisor, {MishkaJobWorkerSupervisor, self()}}

HOWEVER

If the process that’s calling terminate_child isn’t the same one that started the child, I’m not sure that’s going to find the correct DynamicSupervisor. :thinking:

Where Next?

Popular in Questions Top

sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
nobody
How to bind a phoenix app to a specific ip address? could not find anything about that, nowhere, unfortunately, but for me this is quite...
New
beno
I will often find my self writing things similar to: case some_value do nil -> something() "" -> something() _ -> somethi...
New
Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
stefanluptak
Hello everybody, usually, I use a 29" ultra-wide monitor for VSCode which can easily accomodate explorer (files panel) + file with code ...
New
sergio_101
I am VERY much an elixir newbie. I have taken one elixir course and one phoenix course on Udemy. During that course, I saw the instructor...
New
komlanvi
Hi everyone, I was playing with phoenix liveView but I run into an issue. I have a form and want to validate each input text when the te...
New
yawaramin
In the Dialyzer docs ( dialyzer — OTP 29.0.2 (dialyzer 6.0.1) ), there is a way to turn off a specific warning for a function: -dialyzer...
New
jaysoifer
Is there a way to rollback a specific migration and only that one (“skipping” all the other ones)? Would mix ecto.rollback -v 200809061...
New

Other popular topics Top

sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
danschultzer
None of the current solutions worked well for me, so I went ahead and built a user management system from scratch. This project took far...
548 29603 241
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
greenz1
I have a phoenix application from which a user can download multiple(5-6) files of size 1MB. I couldn’t find anything related to sending ...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod – where is this set? Thanks.
New
belgoros
I’m not a pro in using Regex and can’t figure out why the following behaviour happens, especially if we take into account the difference ...
New
Qqwy
Original source of discussion: This topic on the Pragmatic Programmers’ Functional Web Development with Elixir, OTP, and Phoenix forum. ...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
boundedvariable
I am going through the kafka architecture. All the features what the kafka is providing are already in Erlang. I would like hear your opi...
New
joaquinalcerro
Hi there, I am working with Ecto-Postgresql and I need to call all of the records from a specific table but the table has 40,000 records...
New

Latest on Elixir Forum

Elixir Forum

We're in Beta

About us Mission Statement