mysterymt

mysterymt

How to run validation only when changeset is valid?

I’m continuing to work on a small Ash project and have a situation where I’m building out a validator to verify a user’s password before allowing changes to be made on the User’s password. However, if there are other errors on the form, I don’t want it running the hashing algorithm since it’s expensive. The action on the resource looks something like this:

update :update_password do
  # ... code here

  # Run validations
  validate {Validators.VerifyPassword, password_argument: :current_password}

  # ... more code here
end

When doing it this way, I have to check if the changeset is valid inside the validator itself before running. Something along the lines of this:

@impl true
def validate(%{valid?: false}, _opts, _context), do: :ok

@impl true
def validate(changeset, opts, _context) do
  # ... do actual validation here
end

The problem with this is I’m returning :ok even though the validation hasn’t been run, which feels wrong to me. I know there are where clauses that can be run like so:

# Run validations
validate {Validators.VerifyPassword, password_argument: :current_password} do
  where # ... some condition here
end

My question is, is there way to make that where clause check to see if the changeset itself is valid before running this validation? That feels a little more clean and logical to me than what I’m currently doing in the validator module for it. I checked the documentation and there are a few examples of using where, but I still don’t fully understand all the possible options for it are. Would I have to create another validator that checks to see if the changeset is valid and then have the where run that validator? Is there something easier and already built into Ash that I can use?

Marked As Solved

zachdaniel

zachdaniel

Creator of Ash

You could do it in the way you described yes, but there is an option for it, only_when_valid?: true. This can be added to both validations and changes. In 4.0 we may swap the default of that (and provide an upgrade script that preserves the old behavior for all existing validations and changes).

See the docs for more :grin:

Where Next?

Popular in Questions Top

Kurisu
For example for a current url like http://localhost:4000/cosmetic/products?_utf8=✓&query=perfume&page=2, I would like to get: ...
New
skosch
To my knowledge, put_in, Map.update etc. all have the one limitation of not automatically creating intermediate keys when needed (for exa...
New
gshaw
What is the idiomatic way of matching for not nil in Elixir? E.g., First way: defp halt_if_not_signed_in(conn, signed_in_account) when...
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID<0.412.0> terminating ** (Postgrex.Error) FATAL...
New
jononomo
I am trying to figure out how Mix knows whether the environment is test, dev, or prod – where is this set? Thanks.
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
joeerl
Hello again - after a longish gap I’ve decided I really must dig into Elixir and see what’s been happening here - so I have a few questio...
New
nsuchy
Hi. I’ve noticed that Windows Powershell has it’s own IEX command and you cannot access Elixir’s IEX due to the conflict. This isn’t a cr...
New
dotdotdotPaul
Okay, I’m having a heck of a time trying to figure out how to best handle the validation of belongs_to associations in Ecto. I’m sure I’...
New
joaquinalcerro
Hi there, I am working with Ecto-Postgresql and I need to call all of the records from a specific table but the table has 40,000 records...
New

Other popular topics Top

sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
senggen
Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] 15:22:35.803 [error] gen_event {lager_file_backend...
New
albydarned
Hello all! I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New
AngeloChecked
What learn first? Rust or Elixir Hi Elixir community! I’m here because i want learn a new language. I’m a junior developer and mainly i ...
New
alice
Hey, Just curious what are the main benefits of Elixir compared to Clojure? When is Elixir more useful than Clojure and vice versa? Th...
New
nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
jason.o
In the code below, if the create action is not set to accept “extra_key” as an input, it errors out with a message shown above. Is there ...
New
shijith.k
I am trying to start a new phoenix project with elixir 1.9, but mix phx.new does not work. It says that ** (Mix) The task "phx.new" could...
New

We're in Beta

About us Mission Statement