Hello, again folks!
I’ve been challenged by a problem this week and I’m not quite sure how to proceed to solve it. Also, I’ve spent a good amount of time today researching to better understand the said problem, however, I’m still kinda stuck with it. This is my drama…
I’m importing/ creating data using a CSV file, and I’m validating each line to see if the values are correctly filled/ formated and overall valid. Each row in this file has n columns, and they are not always part of the same schema (some of those columns are associations that should be created).
For example:
%Post{} that I want to create for each row:
schema "posts" do
field :title, :string
field :description, :string
has_many :post_tags, PostTag
end
%Tag{} that exists beforehand:
schema "tags" do
field :name, string
# Let's say that we have to validate that the user
# has chosen from a value within a valid range
field :max_possible_score, :integer
end
%PostTag{} relationship that will be inserted with the post:
schema "post_tags" do
belongs_to :post, Post
belongs_to :tag, Tag
field :rating, :integer
end
And the file would look like this:
| Title | Description | Taste | Looks | Popularity |
|---|---|---|---|---|
| how to cook lobster | just lobster | 5 | 10 | 100 |
| how to cook beans | just beans | 4 | 8 | 70 |
So far, so good. I have a draft of the import logic in place and I was about to make some performance tests to start refactoring the code. The goal is to be able to import something like 20k rows with 100 columns.
The first thing that comes to mind is to chunk the rows that are being streamed from the file and process them asynchronously. But, I have to process everything in a transaction because If there’s even one invalid row, the whole operation should be invalid and not processed at all.
So what I’m doing right now is:
- Getting all the rows from the CSV and generating a bunch of changesets
- Filtering those changesets to see if they’re valid or not
- If there’s at least one invalid changeset we abort the operation
In the end, I have a list of valid changesets for the %Post struct and the structure that I’m inserting is something similar to this (as a changeset, of course):
%Post{
title: "how to cook lobster",
description: "just lobster",
post_tags: [
%PostTag {
tag_id: 1,
rating: 5
},
%PostTag {
tag_id: 2,
rating: 10
},
%PostTag {
tag_id: 1,
post_id: nil,
rating: 100
}
]
Because I need to persist a struct with its association I’m having to use insert instead of insert_all (to keep the references). Looking to improve the code, I’ve wrapped the changesets in a transaction like this:
Repo.transaction(fn repo ->
changesets
|> Enum.chunk_every(10)
|> Enum.map(fn chunk ->
Task.async(fn ->
Enum.each(chunk, fn changeset ->
repo.insert!(changeset)
end
end)
end)
end)
I took inspiration from this comment and I thought this would work fine, but I got a series of errors ranging from database timeouts/ disconnects and problems with the test sandbox - It seems that there’s a problem with the processes sharing the same connection or something like this which I can’t quite put my finger on.
Besides that, I was trying to benchmark the code with benchee, and I got really confused about what exactly was going on. If the problem was in my test case or on the async routine and so on…
I’ve read multiple old replies of @michalmuskala talking about this not being supported and there are some old comments about it here too. I’m not sure if this is still true to this day or if I’m missing something here.
Could someone give me a hint on how to overcome this?
