leon_cruz

leon_cruz

How to validate Ecto Associations properly?

Hello there, I’m getting some problems in validate associations in Ecto. I have two schemas, Video and Playlist (a playlist can have many videos). The Video schema has a following changeset:

def changeset(video, attrs \\ %{}) do
  video
    |> cast(attrs, [:name, :url, :playlist_id])
    |> validate_required([:name, :url, :playlist_id])
end

And Playlist has the following changeset:

def changeset(playlist, attrs \\ %{}) do
  playlist
    |> cast(attrs, [:name, :category])
    |> cast_assoc(:videos, required: true)
    |> validate_required([:name, :category])
end

What I want is when create a video, a playlist must be required, and when create a playlist, at least, one video has to be informed. This works for the video case, but when I try to create a playlist, there is a validation error on playlist_id of video. Anyone has some idea how to proceed with this? What I’m doing wrong? Thanks!

Most Liked

soup

soup

Sounds like you’re trying to build everything in one go? But since the playlist doesn’t exist yet, it doesn’t have an id, so it can it be given to the videos, so they fail their validation.

Confession: I can’t remember the last time I used cast_assoc personally, I set association ids manually. I also don’t like how IIRC you have to always give all the relationships in total which can be cumbersome.

I would do something like this, where its a two step transaction. You can also try ecto.multi.

###
### Writing this on my way out the door, so take it as a suggestion
###

def create_playlist_with_videos(name, category, videos) do
  # I normally have my own wrapper around transaction, so trying to remember
  # exactly without docs.
  Repo.transaction(fn ->
    with {:ok, playlist} <- create_playlist(name, category),
         # now playlist exists with an id so we can create videso
         {:ok, videos} <- create_playlist_videos(playlist, videos) do
      # transaction() wraps result in {:ok, _}
      %{playlist | videos: videos}
    else
      # can write this nicer, ideally the {:error, _} could just fall
      # out and fail the transaction
      {:error, e} -> rollback(e)
    end
  end)
end

defp create_playlist(name, category) do
  %Playlist{}
  # its ok to have more than one changeset function, i find it useful to
  # have at least a create_ and update_ as often they want different
  # validations.
  |> Playlist.create_changeset(name, category)
  |> Repo.insert()
end

defp create_playlist_videos(%Playlist{} = p, videos) do
  videos
  |> Enum.map(fn v ->
    %Video{}
    |>Video.create_changeset(playlist.id, v.name, v.url)
    |> Repo.insert()
  end)
  |> Enum.reduce({:ok, []}, fn
    # acc is error, perpetuate
    # you can use reduce_while to quit out
    _, {:error, e} -> {:error, e}
    # vid was ok, save and keep going
    {:ok, vid}, {:ok, vids} -> {:ok, [vids | vid]}
    # vid was error, return error (or collate all errors or ...?)
    # how you handle these errors is kind of application specific
    {:error, cs} _ -> {:error, :idk_lol}
  end)
end

e: you also probably want to put a null: false constraint in the database too if you haven’t.

al2o3cr

al2o3cr

cast_assoc combined with validate_required on the child schema’s foreign key will not work (see also a lot of the search results on this forum for cast_assoc). When you’re creating a Playlist, the related Video changesets need to be valid before the Playlist has an ID.

My suggestion to resolve this:

  • use a changeset function in cast_assoc(:videos, ...) that doesn’t cast or require playlist_id; that value will be set by the Ecto machinery automatically

  • if a video cannot be created without a playlist_id, enforce this at the database level with a null: false constraint on the column

A rule I find useful to help decide if something should be validated in a changeset function: is there a meaningful way to give feedback about a resulting error to the user? For instance, a blank name or category can show a “can’t be blank” message next to the UI for that value - what feedback could a missing playlist_id give?

leon_cruz

leon_cruz

i’ve already setup this

For this case, the message error will be like: “must be select a playlist”

Where Next?

Popular in Questions Top

aadeshere1
I have a another noob question about loop. Since elixir is immutable, while loop is not directly possible. total = 10 while total != 0 ...
New
vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
New
tduccuong
Hi, is there any work on GUI with Elixir, that is similar to Electron/Javascript? My idea is to bundle Phoenix and BEAM into a single se...
New
LegitStack
I’m trying to make a websocket server in Phoenix or raw Elixir. I heard about gun, I think I could use cowboy, but since I’m not that sma...
New
JDanielMartinez
Hi! May someone helps me, please! I have two apps into an umbrella project: the first one is Database, which manages queries, and the se...
New
nsuchy
Hi. I’ve noticed that Windows Powershell has it’s own IEX command and you cannot access Elixir’s IEX due to the conflict. This isn’t a cr...
New
PeterCarter
There are pre-rolled solutions for other frameworks that do work. However, Phoenix does not seem to have these. Have people had good expe...
New
jononomo
For some reason my phoenix channels are working for me in my local dev environment, but as soon as I deploy via Docker, I get a 403 error...
New
lanycrost
Hi everyone! I need implement if…else if…else condition from my elixir code, and anymore of this control flow structures not work proper...
New

Other popular topics Top

vertexbuffer
Hello, can anybody help here..? I have a list of players and I what to delete an element, but every for loop the list is reverting to ori...
New
Fl4m3Ph03n1x
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: ) Hello all, this is ...
New
baxterw3b
Hi guys, i’m new in the Elixir world, and i have to say, that i love it! i’m having some problem to understand anonymous functions with ...
New
vonH
When I run the Plug and I recompile I wind up having to use Ctrl C to quit iex and start again. Witht the help of rlwrap I can use the cu...
New
sergio_101
I am VERY much an elixir newbie. I have taken one elixir course and one phoenix course on Udemy. During that course, I saw the instructor...
New
shijith.k
I am trying to start a new phoenix project with elixir 1.9, but mix phx.new does not work. It says that ** (Mix) The task "phx.new" could...
New
openscript
Hello! Sorry for this astonishing simple question, but I’m really stuck. I try to set up the intellij-elixir plugin, but I don’t know ho...
New
dogweather
I wrote this comment on r/haskell, and it’s not popular there. :wink: But I think I’m on to something… Haskell reminds me of Java, and e...
New
hariharasudhan94
Lets say I have map like this fetching from my database %{"_id" =&gt; #BSON.ObjectId&lt;58eb1a7a9ad169198c3dXXXX&gt;, "email" =&gt; ...
New
svb
Hi! Currently I want to submit a form by pressing the Enter key. However, since my input field is of type “textarea” this is just adds a...
New

We're in Beta

About us Mission Statement