How to wait for tenant migrations to finish successfully?

Ash Forum Ash Questions / Help
,
1

In my multi-tenant application, when the user registers, I want to create :

  • a user record
  • an organisation / tenant
  • and some records into the tenant specific schema tables.

I have written the aciton for it. But while running the code, I am getting errors like - ERROR 42P01 (undefined_table) relation \"test18757.teams\" does not exist

I suspect, this could be because of the race condition - when the org record is created, it creates schema for the new org/tenant and runs tenant migrations. And since I am trying to insert records in tenant specific tables before migration finishes, it is failing.

So my question is - How can I wait for tenant migrations to finish successfully before running the next steps?

Thanks!

2

Can you share what your action looks like?

3

It might not be idiomatic Ash code, but here is the current state of the function :-

  create :register_with_organization do
    description "Register a new user with organization and default controller team"

    # User arguments
    argument :email, :ci_string do
      allow_nil? false
    end

    argument :password, :string do
      description "The proposed password for the user, in plain text."
      allow_nil? false
      constraints min_length: 8
      sensitive? true
    end

    # Organization arguments
    argument :org_name, :string do
      allow_nil? false
    end

    argument :org_domain, :string do
      allow_nil? false
    end

    # Set user fields
    change set_attribute(:email, arg(:email))

    # Hashes the provided password
    change AshAuthentication.Strategy.Password.HashPasswordChange

    # Create organization and setup tenant relationships
    change fn changeset, _context ->
      org_name = Ash.Changeset.get_argument(changeset, :org_name)
      org_domain = Ash.Changeset.get_argument(changeset, :org_domain)

      # Create organization using manage_relationship
      org_data = %{
        name: org_name,
        domain: org_domain,
        subscription_expiry_date: Date.add(Date.utc_today(), 365)
      }

      Ash.Changeset.manage_relationship(changeset, :organisation, org_data, type: :create)
    end

    # After organisation is created, setup tenant and create team/membership
    change after_action(fn changeset, user, _context ->
      if user.organisation do
        # Create default controller team
        team_params = %{
          name: "Controller",
          short_name: "CTRL",
          description: "The document controllers group",
          team_type: :controller,
          organisation_id: user.organisation.id
        }

        case Ash.create(Dci.MasterSetup.Team, team_params, tenant: user.organisation) do
          {:ok, team} ->
            # Create team membership
            membership_params = %{
              user_id: user.id,
              team_id: team.id,
              role: "admin"
            }

            case Ash.create(Dci.MasterSetup.TeamMembership, membership_params,
                  tenant: user.organisation
                ) do
              {:ok, _membership} ->
                {:ok, user}

              {:error, error} ->
                {:error, error}
            end

          {:error, error} ->
            {:error, error}
        end
      else
        {:ok, user}
      end
    end)
  end
4

:thinking: interesting. So at that point, the tenant should exist and be migrated :thinking:

Oh, okay nevermind. Try replacing your manage_relationship to an after action hook that creates the organization directly. So two after action hooks, which will then happen in sequence.

5

Even if I avoid this situation by delaying the operation into tenant tables, to give time for creation of tenant schema, wouldn’t this problem come up in tests?

For tests involving tenant schema, I will be creating the user, org and tenant data without much delay between them. Please let me know if I am not thinking right.

I will replace the manage_relationship as you suggested and come back to you.

6

The tenant schema and migrations are run synchronously, just like action hooks. The only way you can get to what you’re getting at is due to things happening out of order. I’m actually surprised that there would be an issue with the way you have it, but eliminating the manage_relationship call will remove at least one factor. I’d have to double check but I’m pretty sure that with that formulation the organization is created after the hooks run, because manage_relationship doesn’t do that logic “right then and there” but adds it to the changeset to be done at the end.

7

It turns out, its my fault. I apologise for wasting your time.

There was a difference between the domain name used to create the schema and the domain name in my tests which I was using to read the schema tables.

The schema generation is working synchronously exactly as you described.

1 Like