niels_bom
I just found myself writing this:
def foo([], _), do: []
def foo(_, 0), do: []
But then I thought I could also use a guard clause with a boolean OR, like so:
def foo(list, n) when list == [] or n == 0, do: []
Is either version more idiomatic?
Would it maybe depend on the amount of code in the function? (DRY and all)
Because pattern matching is so nice and in this case the function body is very small I’ll probably choose the first version.
Thanks!
Where Next?
Trending in Questions
Other Trending Topics
Latest on Elixir Forum
Sponsor Spotlight
Bringing learning, work and compliance together since 1987.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #ai
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #blog-post
- #ecto-query
- #elixirconf-us
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #elixirconf-eu
- #api
- #forms
- #security
- #hex
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Master modern tools, write cleaner code, and tackle real-world challenges.
Producing high quality Elixir screencasts since 2017.
The deployment platform built for Elixir: PaaS ease, VPS control.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
Showing Posts 1 to 4- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
dimitarvp
I use both of these idioms – and others – quite often. My main heuristic is: “is the code readable?”
The only non-idiomatic Elixir in such cases would be a load of
if-s. The rest is quite fine and the exact idiom should vary depending on your priorities and the situation.thomasbrus
Second one is easier to understand I would say. More idiomatic.. I don’t know, either one is fine.
NobbZ
The first one, as it leaves more room for optimisation by the compiler. Also matching
0in the function head is more strict thanx == 0since0.0 == 0.PS: sometimes, if from business perspective both cases are to treat the same and not only by accident, I tend to use a guard using
===, as it better communicates indent of treating this cases the same.niels_bom
Thanks all!
Yeah readability is definitely important.
Other things being equal (like readability) leaning towards faster code is good of course.
@NobbZ good catch of the
x == 0!