Import and macro conflict

mguimas

Hello.

Suppose we have a file with this code

import ImportMe

defmodule AModule do
  use UseMe
end

where the modules above are defined in another file like this

defmodule ImportMe do
  def bar, do: :ok
end

defmodule UseMe do
  defmacro __using__(_opts) do
    quote do
      def foo, do: bar()
      def bar(), do: :ok
    end
  end
end

The compilation of these two files produces the imported ImportMe.bar/0 conflicts with local function error in the first file.

Is this something that should be reported as a bug or not?

Thanks

9 comments

#core #learning-elixir

0 2856 9

2019-03-25 15:45:02 UTC

Showing Posts 1 to 9

Show Best Posts
Show All (oldest first)
Show All (newest first)

LostKobrakai

Why would it be a bug? You clearly have two functions named bar available in the same scope. What if you change the order of your functions to:

def bar(), do: :ok
def foo, do: bar()

What should is call in that case? It’s not clear.

Post #1

mguimas

Switching the order of the definitions inside UseMe generates the same compilation error.

Why would it be a bug?

The modules ImportMe and UseMe are not freely composable (i.e., some uses result in a compilation error).

If the modules are the responsibility of the same team, then things are easy to solve (just rename the functions).

But if the modules come from disparate teams, then the developer must use ImportMe.bar/0 qualified.

A similar situation results when trying to use A and use B, and A and B define the same named function with the same arity.

This might be an unintended limitation with macros, or something that one must live with, hence my question.

Post #2

LostKobrakai

I’m not really sure how this is related to macros at all. You have two different functions named the same in the same scope. That’s not going to work well. The compiler cannot decide for you which of the two ones it’s supposed to call. How those named functions ended up in the same scope shouldn’t make any difference.

Post #3

mguimas

This is related to macros because it relates to injecting definitions in a scope where the same definition already exists.

This is breaking macro hygiene: more specifically, if injecting a variable is not a problem, then injecting a definition should not be a problem too. (See macro hygiene).

Post #4

NobbZ

:only and :except options are available for import, you can use them to steer the compiler in the right direction.

But if you want hygiene for macro defined functions as you have them for variables, fine. You made macros useless, as from now on funtions defined in a macro don’t leak the macro anymore!

Post #5

mguimas

But if you want hygiene for macro defined functions as you have them for variables, fine. You made macros useless, as from now on funtions defined in a macro don’t leak the macro anymore!

I was almost going to agree with this, but then I remembered that the injected functions are accessible through the AModule interface. So macros do not become useless.

Post #6

NobbZ

When you are in AModule, there is no difference between bar and AModule.bar.

Just cope with it. Calling a macro is the same as copy and pasting code into your file. If you do not want a function f generated, then do not call the macro.

If you do not want to import a function g, then :exclude it from the import list.

That aside, I have a very strict opinion about libraries narrowing my own available namespace by dumping arbitrary functions into my module. But I think we already argued about this a lot in the slack…

Post #7