fceruti

fceruti

I’m working on a cool library (news about that in a few weeks :smiley:), and there’s no sugar coating this: I really want to use inheritance.

I’m no Elixir n00b, at least not completely. I’ve enjoyed the functional paradigm shift very much, but in this particular case, I can’t help but feel like I’m jumping all kinds of hoops just to emulate what simple inheritance stuff would fit perfectly.

Let me describe the problem, then the best solution I’ve come up with, and I hope you can help me come up with a better one.

So, in this library, there’s lots of configuration to do. Most of this configuration will be written by the author of the library, lets call them starting points, and there are many of them. Users can use one of these starting points and just modify whatever they want to change and keep the rest. A config that uses a base “template” can also be a template for another config, and they would catch these config definitions in a cascade manner.

That’s probably the longest I’ve written about inheritance without mentioning it.

Right now I’ve got something like this:

defmodule Config do
  @callback __attr_value(atom(), atom()) :: atom()
  @optional_callback __attr_value: 2

  defmacro __using__(_opts) do
     quote do
        @behaviour Config

         def attr_value(category, item) do
           try do
               __MODULE__.__attr_value(category, item)
           rescue
              _e in [UndefinedFunctionError, FunctionClauseError] ->
                variables = __MODULE__.__info__(:attributes)
    
                if parent = Keyword.get(variables, :parent) do
                  parent.__attr_value(category, item)
                else
                  default_value(category, item)
                end
           end
         end
     end 
  end
end

defmodule BaseConfig do
   use Config

   def __attr_value(:category, :name), do: :my_value
   def __attr_value(:category, :picture), do: :my_picture
end
   
defmodule ChildConfig do
   use Config
   @parent BaseConfig

   def __attr_value(:category, :name), do: :another_value
end

It works, but I don’t know, I’m feeling uneasy with it.

What do you think? Have you seen this in the wild? Is there a better way?

Showing Posts 1 to 6

dimitarvp

dimitarvp

Quick shot at this: why not use defdelegate in the derived (child) configs?

fceruti

fceruti OP

hehe nice! That’s it. Inheritance solved!

Now it looks like this

defmodule MyConfig do
  @callback attr_value(atom(), atom()) :: atom()
  @optional_callbacks attr_value: 2
end

defmodule BaseBaseConfig do
   @behaviour MyConfig

   def attr_value(:category, :name), do: :base_base_name
   def attr_value(:category, :picture), do: :my_picture
end

defmodule BaseConfig do
   @behaviour MyConfig

   def attr_value(:category, :name), do: :base_name
   defdelegate attr_value(a, b), to: BaseBaseConfig
end
   
defmodule ChildConfig do
   @behaviour MyConfig
   def attr_value(:category, :name), do: :child_name
   defdelegate attr_value(a, b), to: BaseConfig
end

Now a tiny little detail. How can I “annotate the information” of who I’m delegating to, at the top of the module instead of the bottom.

I’m thinking something like using a macro that injects at the end what is defined at the top. Is that possible?

cmo

cmo

I presume you mean something more advanced than a module attribute?

defmodule ChildConfig do
   @behaviour MyConfig
   @delegate BaseConfig
   def attr_value(:category, :name), do: :child_name
   defdelegate attr_value(a, b), to: @delegate
end
fceruti

fceruti OP

Oh man, thanks this is awesome. I got lost in a sea of macros when the solution was so simple :slight_smile:

Thanks!

eksperimental

eksperimental

First, do not use Config as the name for your behaviour since it is a module in Elixir.

Then I would work with module attributes and do compile time checks.
What i usually do is create functions in the behaviour module that are called by default with the default implementations defined in __using__/1. Also look into how to play with òptions passed to this macro.
Then also make use of defoverridable/1 to let the user rewrite the default implementation.
You should be covered by all this.

krasenyp

krasenyp

This is what I’ve implemented numerous times and works well. Something similar is shown in the article Macro Madness: How to use `use` well - DockYard.

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
pragdave
How do I tell Hologram not to escape HTML when substituting into templates? {Textile.render(@product.long_description)} escapes the HTM...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
rlipscombe
I’d like to create a file with 600 permissions (rw-------), but there’s a race condition if I create it and then change the permissions. ...
New
saleyn
Is there a way to import record definitions in the iex shell for pretty printing (similar to the rr command in the erl shell)? This woul...
New
rlipscombe
When I use Mix.install with a git dependency, using git@github.com:... how do I change the SSH identity used? I’ve got two Github accoun...
New

Other Trending Topics Top

saleyn
The following two features were added to erlexec. Container: exec:run_container/1: run a command in a container You describe the contain...
New
dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
raa-ziq
Hi everyone :waving_hand: I wanted to share something I’ve been building — NowBlind, a random chat app designed to help people discover ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews