idi527

idi527

Is there a way to compare iolists for equality without converting them to binary?

Or is a custom function needed?

Something like (currently incorrect, doesn’t account for nested lists):

defmodule Comparer do
  @moduledoc """
  Equality comparison for iolists consisting of binaries.
  """

  @spec equal?(iolist, iolist) :: boolean
  def equal?(iolist1, iolist2)

  def equal?(iolist1, iolist2) do
    equal?(iolist1, iolist2, [])
  end

  defp equal?(
         [<<char, rest_bin1::bytes>> | rest_iolist1],
         [<<char, rest_bin2::bytes>> | rest_iolist2],
         []
       ) do
    equal?([<<rest_bin1::bytes>> | rest_iolist1], [<<rest_bin2::bytes>> | rest_iolist2], [])
  end

  defp equal?(
         [<<>> | rest_iolist1],
         [<<>> | rest_iolist2],
         []
       ) do
    equal?(rest_iolist1, rest_iolist2, [])
  end

  defp equal?(
         [<<>> | rest_iolist1],
         iolist2,
         []
       ) do
    equal?(rest_iolist1, iolist2, [])
  end

  defp equal?(
         iolist1,
         [<<>> | rest_iolist2],
         []
       ) do
    equal?(iolist1, rest_iolist2, [])
  end

  defp equal?(
         [<<char, rest_bin1::bytes>> | rest_iolist1],
         rest2,
         [<<char, rest_bin3::bytes>> | rest_buffer2]
       ) do
    equal?([<<rest_bin1::bytes>> | rest_iolist1], rest2, [<<rest_bin3::bytes>> | rest_buffer2])
  end

  defp equal?(
         [<<>> | rest_iolist1],
         rest2,
         [<<>> | rest_buffer2]
       ) do
    equal?(rest_iolist1, rest2, rest_buffer2)
  end

  defp equal?(
         [<<>> | rest_iolist1],
         rest2,
         buffer2
       ) do
    equal?(rest_iolist1, rest2, buffer2)
  end

  defp equal?([], [], []) do
    true
  end

  defp equal?(_, _, _) do
    false
  end
end

Marked As Solved

NobbZ

NobbZ

Equality is easy, just use ==/2. But I fear it’s equivalency you want to check. And to be honest, I think flushing them into binary and compare equality on those should be the easiest thing.

Also Liked

hauleth

hauleth

@NobbZ already told you that equality != equivalence, but let see why you cannot compare iolists and why your comparator is terribly wrong.

See what Typespecs say about iolist type:

iolist() maybe_improper_list(byte() | binary() | iolist(), binary() | [])

But what is improper list?

So all of us get used to it that list in Erlang is head and tail or an empty list (yes empty list is special case of list). So when we do [a | b] = list then is_list(b) == true. Simple. But what when it isn’t? Nothing in Erlang prevents you from doing [1 | 2]. Yes this is proper syntax, yes it will compile, yes it is used. This is called improper list and your Comparer will fail on that.

Second thing is that iolist can be:

  • infinitely nested, so [[[[[["a"]]]]]] is also proper iolist that is equivalent to ["a"]
  • can contain raw bytes, so ["a", 97] is equivalent to ["aa"]
  • can contain Erlang strings, which are lists ['a'] == [[97]] == [[?a]] which is equivalent to ["a"]

So some hard examples for you to compare:

  • ["foo", 'bar' | ?z] vs [["foo" | "bar"], "z"]
  • ['a' | "ą"] vs ["aą"]
  • ["aa", ?a, 'aa'] vs ["a", ?a, 'aa' | "a"]
rvirding

rvirding

Creator of Erlang

None that I know of. The thing to be aware of is that there is no real iolist data type, it is just a nested recursive structure which happens to be interpreted in a special way in some cases. The main one being that on output the BEAM will automagically flatten it and output the bytes. This means that in many case you don’t have to pay the price of flattening it.

That should be all now. :smile:

rvirding

rvirding

Creator of Erlang

The reason converting the iolists to binaries and then doing and equals test is that these are both implemented in the VM in C while your code is in Elixir. No, will not go faster if you were to write it in Erlang. [*]

You can probably make your code more efficient when comparing binaries by directly comparing the longest leading chunk in one go instead of doing it byte by byte. And it is fun code to write as well. Another fun function is one that takes an iolist and returns the Nth byte.

[*] Of course the Erlang would be more beautiful. :wink:

Where Next?

Popular in Questions Top

minhajuddin
I have seen a lot of code which picks the first element from a list using Enum.at(0) instead of List.first. Is there a reason why people ...
New
Emily
I have VueJS GUIs with the project generated using Webpack. I have Elixir modules that will need to be used by the VueJS GUIs. I forese...
New
stefanchrobot
What’s the safe way to decode a JSON string into a struct? I want to avoid calling String.to_atom. Jason.decode can give me a map with st...
New
nsuchy
Hi. I’ve noticed that Windows Powershell has it’s own IEX command and you cannot access Elixir’s IEX due to the conflict. This isn’t a cr...
New
Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
Fl4m3Ph03n1x
About me? ( if you have nothing better to do than reading about some random guy in the internet :stuck_out_tongue: ) Hello all, this is ...
New
fireproofsocks
Forgive me if this is obvious, but how does one delete a database record WITHOUT selecting it first? Ecto.Repo — Ecto v3.14.0 has exampl...
New
sergio_101
I am VERY much an elixir newbie. I have taken one elixir course and one phoenix course on Udemy. During that course, I saw the instructor...
New
siddhant3030
Hi, I have to write a raw query for one of my project. But till now I have used ecto queries and don’t have much experience writing raw ...
New
pmjoe
I have a relationship of love and hate with Elixir. Lots of things are just absolutely right, but there are some things that are kind of ...
New

Other popular topics Top

Qqwy
Update: How to use the Blogs &amp; Podcasts section You can post links to your blog posts or podcasts either in one of the Official Blog...
3271 127089 1222
New
RisingFromAshes
I’ve read in another post that it may be possible with a router helper - but I couldn’t find an appropriate one, and tbh, I’m still just ...
New
grych
Hi folks, Few months ago I have announced the proof-of-concept of the library to manipulate the browsers DOM objects directly from Elixi...
639 52673 488
New
hariharasudhan94
I would like to know what is the best IDE for elixir development?
New
stefanchrobot
What’s the safe way to decode a JSON string into a struct? I want to avoid calling String.to_atom. Jason.decode can give me a map with st...
New
nsuchy
Hi. I’ve noticed that Windows Powershell has it’s own IEX command and you cannot access Elixir’s IEX due to the conflict. This isn’t a cr...
New
Darmani72
If I have a post route which an argument: post /my_post_route/:my_param1, MyController.my_post_handler How would get the post params ...
New
AstonJ
Seen any cool LiveView demos, sample apps or examples? Please post them here! :003:
New
klo
Got a question about when to concat vs. prepending items to list then reversing to achieve appending. So i know lists boil down to [1 | ...
New
AstonJ
Posting this to see if we can make things easier for people to get into Neovim. If you use Neovim and have a favourite distro please let ...
New

Latest on Elixir Forum

Elixir Forum

We're in Beta

About us Mission Statement