LiveView: File upload not saving files

I’ve followed the Phoenix LiveView file upload code here Uploads — Phoenix LiveView v1.0.0-rc.7 and so far everything works just fine with no errors, the only thing I noticed is that the file (images in my case) are not actually being saved. Instead of I have this long, weird filename with no extension e.g. live_view_upload-1733165679-200177911668-2

My code for uploading is line for line from the docs:

def handle_event("save", _params, socket) do
    Logger.info("UploadLive.Upload: save")

    uploaded_files =
      consume_uploaded_entries(socket, :avatar, fn %{path: path}, _entry ->
        dest = Path.join(Application.app_dir(:live_jobzz, "priv/static/uploads"), Path.basename(path))
        
        Logger.info("UploadLive.Upload: path #{path}")
        Logger.info("UploadLive.Upload: dest #{dest}")

        # You will need to create `priv/static/uploads` for `File.cp!/2` to work.
        File.cp!(path, dest)
        {:ok, ~p"/uploads/#{Path.basename(dest)}"}
      end)

    {:noreply, update(socket, :uploaded_files, &(&1 ++ uploaded_files))}
  end

What do I need to change?

When liveview uploads the file, a temporary file is created on your server with a unique name “live_view_upload-…”, in the example code you are copying this file with that name to your uploads folder.
So if you do not want that you have to change your dest to something more useful, eg based upon the name of the original file that you can find in the uploaded entry.

Also beware the example shows storing your files in your priv dir, do not do this in production.
When you release a new version of your app (increase the version number in mix.exs), you will get a new priv-dir and all your uploads will be lost. Much better to store it in a location outside of your app tree.

3 Likes

thanks this worked! I realized that the consume_uploaded_entries method returns an UploadedEntry struct which has all the info I need…
In prod the uploads will be going to S3, this set up was just for dev purposes

1 Like

similar question and solution here: How to include file extension with LiveView Uploads? - #2 by mcrumm

1 Like