bianchidotdev
Liveview: is_connected macro?
I came across a blog post that implemented a function guard for a liveview socket connection’s presence. It seems like a really ergonomic way to separate out mount functions for connected sockets and disconnected sockets, and I was surprised I wasn’t able to find any existing proposals or suggestions to implement connected? as a macro (very possibly my search fu failing me).
Is there any appetite in implementing this function guard in core liveview? Are there reasons it’s not implemented as a guard yet.
Code referenced in the blog post:
defguard is_connected?(socket) when socket.transport_pid != nil
Enabling:
def mount(params, session, socket) when is_connected?(socket) do
# Connected mount
end
def mount(params, session, socket) do
# Disconnected mount
end
Most Liked
al2o3cr
One reason this may not exist already - the map.field notation wasn’t supported in guards until this PR, released in 1.11:
https://github.com/elixir-lang/elixir/pull/9711
Phoenix 1.6 only requires Elixir 1.9+, so Phoenix 1.7 is the earliest version this guard could have been included in.
JohnnyCurran
Glad you liked the article! I have been thinking about making a PR to add it to LiveView. I wanted to get some feedback on it first. I suppose this thread might serve that purpose
I haven’t tested it, but I imagine the map.field syntax could be worked around by matching on the fields in the struct:
defguard connected?(%Socket{transport: transport}) when transport != nil
But that’s just a guess. I wrote that in the forum post editor
codeanpeace
Gave it a whirl and it doesn’t look like you can pattern match when defining guards:
** (ArgumentError) invalid syntax in defguard is_connected?(%Socket{transport_pid: transport_pid})
Popular in Proposals: Ideas
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #performance








