jeffdeville

jeffdeville

I’m building a module from a csv. If I set it up to define methods as I parse through the file, it works fine:

defmodule ExModbus.SunSpec.Fronius do
  @external_resource Path.join([__DIR__, "sunspec.csv"])
  for line <- File.stream!(Path.join([__DIR__, "sunspec.csv"]), [], :line) |> Stream.drop(1) do
    [start, _end, size, _access, _func_codes, name, desc, type, _units, _scale_factor, _range] = String.split(line, ",")

    start = String.to_integer(start)
    size = String.to_integer(size)
    name = String.to_atom(String.downcase(name))

    def unquote(name)(pid, slave_id \\ 1) do
      case ExModbus.Client.read_data(pid, slave_id, unquote(start - 1 + 40000), unquote(size)) do
        %{data: {:read_holding_registers, data}, transaction_id: transaction_id, unit_id: unit_id} ->
          data = data |> ExModbus.Types.convert_type(unquote(type))
          {:ok, %{data: data, transaction_id: transaction_id, slave_id: unit_id}}
        other ->
          IO.puts inspect other
      end
    end
  end
end

However, my CSV also includes a description, and I want to use it for documentation @doc unquote(desc) This doesn’t work though, because I’m not in a quote block. So I tried this:

defmodule ExModbus.SunSpec.Fronius do
  @external_resource Path.join([__DIR__, "sunspec.csv"])
  ast = for line <- File.stream!(Path.join([__DIR__, "sunspec.csv"]), [], :line) |> Stream.drop(1) do
    [start, _end, size, _access, _func_codes, name, desc, type, _units, _scale_factor, _range] = String.split(line, ",")

    start = String.to_integer(start)
    size = String.to_integer(size)
    name = Macro.underscore(name)

    quote do
      def unquote(name)(pid, slave_id \\ 1) do
        case ExModbus.Client.read_data(pid, slave_id, unquote(start - 1 + 40000), unquote(size)) do
          %{data: {:read_holding_registers, data}, transaction_id: transaction_id, unit_id: unit_id} ->
            data = data |> ExModbus.Types.convert_type(unquote(type))
            {:ok, %{data: data, transaction_id: transaction_id, slave_id: unit_id}}
          other ->
            IO.puts inspect other
        end
      end
    end
  end

  IO.puts inspect Macro.to_string(ast)
  Code.eval_quoted ast
end

My AST looks reasonable, but it dies at the last line with:

** (ArgumentError) cannot invoke def/2 outside module
(elixir) lib/kernel.ex:4436: Kernel.assert_module_scope/3
(elixir) lib/kernel.ex:3433: Kernel.define/4
(elixir) expanding macro: Kernel.def/2
nofile:1: (file)

It looks like I’m running this in a module, but apparently not.

The docs say Code.eval_quoted is bad form anyway, so I tried replacing it with this:

  quote do
    unquote(ast)
  end

This compiles, but none of my methods are defined. It seems wrong that my AST is a list, and not a tree, but the same is true for the Translator module from Metaprogramming Elixir, and it’s still working. I suppose this isn’t the top of the tree anyway. But I’m out of guesses for the moment. Any suggestions?

Showing Posts 1 to 2

chrismccord

chrismccord

Creator of Phoenix

s/methods/functions :slight_smile:

You can set the @doc attribute simply inline before your function def:

defmodule ExModbus.SunSpec.Fronius do
  @external_resource Path.join([__DIR__, "sunspec.csv"])
  for line <- File.stream!(Path.join([__DIR__, "sunspec.csv"]), [], :line) |> Stream.drop(1) do
    [start, _end, size, _access, _func_codes, name, desc, type, _units, _scale_factor, _range] = String.split(line, ",")

    start = String.to_integer(start)
    size = String.to_integer(size)
    name = String.to_atom(String.downcase(name))

    @doc "Function that does #{desc}"
    def unquote(name)(pid, slave_id \\ 1) do
      case ExModbus.Client.read_data(pid, slave_id, unquote(start - 1 + 40000), unquote(size)) do
        %{data: {:read_holding_registers, data}, transaction_id: transaction_id, unit_id: unit_id} ->
          data = data |> ExModbus.Types.convert_type(unquote(type))
          {:ok, %{data: data, transaction_id: transaction_id, slave_id: unit_id}}
        other ->
          IO.puts inspect other
      end
    end
  end
end
jeffdeville

jeffdeville OP

Ha! Looks like I was mentally checked out yesterday evening. Thanks Chris!

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
pragdave
How do I tell Hologram not to escape HTML when substituting into templates? {Textile.render(@product.long_description)} escapes the HTM...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New
Stef-Verniers
Hello I’ve been coding in Elixir for almost two years now because of my current job where we implemented Elixir in our application. But ...
New
csmr
Hi all, I’m new here and would like to hear peoples views on my Elixir/Phoenix based game-engine! :smiley: Mutonex gamedesign was finish...
New

Other Trending Topics Top

dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
raa-ziq
Hi everyone :waving_hand: I wanted to share something I’ve been building — NowBlind, a random chat app designed to help people discover ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
kip
Localize is the next generation localisation library for Elixir. Think of it as ex_cldr version 3.0. The first version will be released ...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews