caslu
Mix phx.gen: Add not-null modifier to Phoenix generators
Recently (last week) this PR was merged in Ruby on Rails repository and i thought it could be nice to have in phoenix, basically what it does is to add a “!” operator at the end of each type, so in summary we would type:
$ mix phx.gen.schema Blog.Post blog_posts title:string! views:integer!
and the current output would be generated:
defmodule MyApp.Repo.Migrations.CreateBlogPosts do
use Ecto.Migration
def change do
create table(:blog_posts) do
add :title, :string, null: false
add :views, :integer, null: false
timestamps(type: :utc_datetime)
end
end
end
If you think this make sense as i do and like the idea i think would be great for me to work in this feature since i’m always looking to ways to contribute with code for phoenix, but i would need some help and i’d be really greateful if you guys could help me do it.
IMPORTANT: There’s my first feature suggestion and i don’t know very well how things are done here, sorry if the post does not follow any standard or something like that.
Trending in Proposals: Ideas
Other Trending Topics
Latest Phoenix Threads
Latest on Elixir Forum
Sponsor Spotlight
Error tracking, logs, APM, uptime and cron monitoring in one dev-friendly platform. Find and fix problems before your users notice.
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #elixirconf-us
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #metaprogramming
- #hex
- #performance
Our Sponsors
Build Elixir applications with speed and confidence.
Supporting innovation across the BEAM ecosystem.
We build reliable cloud platforms for business-critical systems.
Catch errors, track performance, monitor hosts and more.
Error tracking, logs, uptime, and Just Enough APM. Built for developers.
Practical resources that improve the lives of professional developers.
Producing high quality Elixir screencasts since 2017.
Enabling companies to succeed by building software people love.
The team behind Membrane, Popcorn, LiveDebugger. Available for hire.
Courses that'll move you from confusion to "Aha, now I get it!"
First 6 of 6 Posts
rhcarvalho
It’s a reasonable feature. I occasionally add
null: falseafter generating migrations.Let’s hear what other people think.
If you have buy-in from the Phoenix team I can help you both suggesting pointers for where to look at in the code base as well a reviewing a PR.
dimitarvp
I do like the idea and I believe I’ve seen it in other ecosystems as well. But there must always be kept a balance between over-loading a DSL and the usefulness that the new feature will bring. It’s not a clear win in favor of adding the bang variant.
caslu
Thanks for your reply and point of view, so if i got it you meant that’s not worthy to add bang variable in generators right? I can be wrong but In my opinion, this feature is classified as a small change that would help a lot in everyday life of phoenix devs, i already had to generate long schemas and was kind of boring to add
null: falsein almost every field. Anyway, thanks for your replycaslu
Thanks bro, i think would be great to have this feature cause we’ll be able to generate almost everything in migration only using mix phx task.
I’d really love this help, would be very welcome mate
rhcarvalho
(If your driving motivation is to contribute something, and you are interested in the code generators, this open issue might serve as a good entrypoint to the topic Calling phx.mix.gen without specifying attributes will succeed but create broken code · Issue #5870 · phoenixframework/phoenix · GitHub)
caslu
Gonna take a look bro, i’m really looking forward code contribution in phoenix. Can i send you a DM in forum chat ?