bmitch

bmitch

I’m new to Elixir and just recently completed “Elixir for Programmers” by pragdave.

I thought creating tic tac toe in Elixir would be a good next step for me to continue my learning.

I’ve created the logic for the tic tac toe game and was wondering if anyone would mind reviewing it and providing me with feedback?

The meat of the code starts from here:

A couple of things I’d like to see if can be improved:

Thanks very much!

First 5 of 5 Posts Switch mode

OvermindDL1

OvermindDL1

First thing first, always run your code through the elixir formatter. :slight_smile:

The way you are doing it is fine:

    game = Map.put(game, :board, new_board)
    |> Map.put(:whos_turn, rotate_player(who))
    Map.put(game, :game_state, update_game_state(game))

Though more efficiently would probably be (assuming you can write update_game_state to work on the old state):

  defp accept_move(game = %Game{}, who, index, true) do
    %{game |
      board: put_elem(game.board, index, who),
      whos_turn: rotate_player(who),
      game_state: update_game_state(game),
    }
  end

Use not in:

  def check_board({a, b, c, d, e, f, g, h, i}) when nil not in [a, b, c, d, e, f, g, h, u] do
    :draw
  end
  def check_board(no_nils), do: :in_progress

Otherwise there are a few places in code that could be simplified more but I’m a bit busy at moment… ^.^;

yurko

yurko

I’d drop pattern matching and do something like this in the end

def check_board(board) do
  if Enum.count(board, &(&1 != nil)) == 0 do
    :draw
  else
    :in_progress
  end
end

upd it’d be wrong though since tuples are not enumerable in elixir, sorry for the confusion :smiley:

OvermindDL1

OvermindDL1

You can always Tuple.to_list/1 them, but the pattern matching way is probably a lot more efficient I’d wager, if that even matters. :slight_smile:

kokolegorille

kokolegorille

A really small note about aliasing… You can use MODULE when aliasing the module.

eg.

defmodule Tictactoe.Game do
  alias __MODULE__
end
bmitch

bmitch OP

Thanks very much @OvermindDL1 @yurko and @kokolegorille !! Great feedback.

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
roeland
Kia ora, We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
rahultumpala
Hello, I have an Elixir backend that implements a custom protocol over TCP. I want to load test the backend and assess the performance o...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New

We're in Beta

About us Mission Statement