bmitch
I’m new to Elixir and just recently completed “Elixir for Programmers” by pragdave.
I thought creating tic tac toe in Elixir would be a good next step for me to continue my learning.
I’ve created the logic for the tic tac toe game and was wondering if anyone would mind reviewing it and providing me with feedback?
The meat of the code starts from here:
A couple of things I’d like to see if can be improved:
-
Can you update multiple values in a map better than the way I do it here: elixir_tictactoe/lib/tictactoe/game.ex at master · bmitch/elixir_tictactoe · GitHub
-
Is there a more condensed way to write this guard on the function?
elixir_tictactoe/lib/tictactoe/board_checker.ex at master · bmitch/elixir_tictactoe · GitHub
Thanks very much!
Trending in Questions
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
Hello!
Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app.
I creat...
New
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
So my question is quite simple and i have found no conclusive answer on forum, google or AI.
Should we use :erlang.float for Integer to ...
New
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted”
Version...
New
Other Trending Topics
I am happy to introduce the very α version of the new programming language compiled to BEAM.
Welcome Cure.
It has literally three kille...
New
Hobbes is a low-level distributed database for the Elixir programming language.
Hobbes provides a simple, safe, and scalable storage lay...
New
Hi there! We created Gust: A task orchestrator inspired by Airflow.
For those who have never heard about Aiflow, it’s a Python-based wor...
New
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve.
They are GUI (Emerge) and State management (S...
New
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #library
- #deployment
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #elixirconf
- #channels
- #exunit
- #discussion
- #code-sync
- #podcasts
- #javascript
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixirconf-us
- #blog-post
- #ai
- #elixir-ls
- #phoenix_html
- #iex
- #graphql
- #genstage
- #websockets
- #supervisor
- #advent-of-code
- #distillery
- #processes
- #api
- #forms
- #hex
- #security
- #metaprogramming










Showing Posts 1 to 5- Show Best Posts
- Show All (oldest first)
- Show All (newest first)
OvermindDL1
First thing first, always run your code through the elixir formatter.
The way you are doing it is fine:
Though more efficiently would probably be (assuming you can write
update_game_stateto work on the old state):Use
not in:Otherwise there are a few places in code that could be simplified more but I’m a bit busy at moment… ^.^;
yurko
I’d drop pattern matching and do something like this in the end
upd it’d be wrong though since tuples are not enumerable in elixir, sorry for the confusion
OvermindDL1
You can always
Tuple.to_list/1them, but the pattern matching way is probably a lot more efficient I’d wager, if that even matters.kokolegorille
A really small note about aliasing… You can use MODULE when aliasing the module.
eg.
bmitch
Thanks very much @OvermindDL1 @yurko and @kokolegorille !! Great feedback.