bmitch

bmitch

I’m new to Elixir and just recently completed “Elixir for Programmers” by pragdave.

I thought creating tic tac toe in Elixir would be a good next step for me to continue my learning.

I’ve created the logic for the tic tac toe game and was wondering if anyone would mind reviewing it and providing me with feedback?

The meat of the code starts from here:

A couple of things I’d like to see if can be improved:

Thanks very much!

Showing Posts 1 to 5

OvermindDL1

OvermindDL1

First thing first, always run your code through the elixir formatter. :slight_smile:

The way you are doing it is fine:

    game = Map.put(game, :board, new_board)
    |> Map.put(:whos_turn, rotate_player(who))
    Map.put(game, :game_state, update_game_state(game))

Though more efficiently would probably be (assuming you can write update_game_state to work on the old state):

  defp accept_move(game = %Game{}, who, index, true) do
    %{game |
      board: put_elem(game.board, index, who),
      whos_turn: rotate_player(who),
      game_state: update_game_state(game),
    }
  end

Use not in:

  def check_board({a, b, c, d, e, f, g, h, i}) when nil not in [a, b, c, d, e, f, g, h, u] do
    :draw
  end
  def check_board(no_nils), do: :in_progress

Otherwise there are a few places in code that could be simplified more but I’m a bit busy at moment… ^.^;

yurko

yurko

I’d drop pattern matching and do something like this in the end

def check_board(board) do
  if Enum.count(board, &(&1 != nil)) == 0 do
    :draw
  else
    :in_progress
  end
end

upd it’d be wrong though since tuples are not enumerable in elixir, sorry for the confusion :smiley:

OvermindDL1

OvermindDL1

You can always Tuple.to_list/1 them, but the pattern matching way is probably a lot more efficient I’d wager, if that even matters. :slight_smile:

kokolegorille

kokolegorille

A really small note about aliasing… You can use MODULE when aliasing the module.

eg.

defmodule Tictactoe.Game do
  alias __MODULE__
end
bmitch

bmitch OP

Thanks very much @OvermindDL1 @yurko and @kokolegorille !! Great feedback.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
ryanwinchester
apply_graft/2 doesn’t rewrite an add_many sub-workflow’s deps on an add step. Grafted jobs cancel with “upstream job was deleted” Version...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews