rm-rf-etc

rm-rf-etc

Nicer way to pipe?

This is basically the same question I’ve asked before, I’m just wondering if anything has changed since I last asked, or if there’s any other ways to do this thing that I am doing.

I know there’s been proposals for alternate ways to pipe some input into an argument slot other than the first position, and I understand why those got shot down, so I’m not really asking about that.

Here’s an example of a function I wrote recently, and shows a style I’ve been doing kind of frequently.

  def get_meter(num, total) do
    Decimal.div(num, total)
    |> Decimal.mult(10)
    |> Decimal.round(0)
    |> Decimal.to_integer()
    |> (fn level ->
      Enum.map(0..10, fn ^level -> "|"; _ -> "-" end)
      |> Enum.join()
    end).()
  end

And this is another way to do the same thing, which I kind of like because we don’t have to add the extra parentheses, but we do have to add an extra level of indentation, which I find annoying.

  def get_meter(num, total) do
    Decimal.div(num, total)
    |> Decimal.mult(10)
    |> Decimal.round(0)
    |> Decimal.to_integer()
    |> case do
        level ->
          Enum.map(0..10, fn ^level -> "|"; _ -> "-" end)
          |> Enum.join()
    end
  end

Using case is really nice when we truly have different conditions to handle in different ways, and I love that we can then pipe the result from the case statement/operator/function/macro/whatever-the-correct-term-is into whatever else comes after, but in the example shown, I don’t like it much.

The best alternative I can find to make this a little cleaner would be this:

  def do_func(arg, func), do: func.(arg)

  def get_meter(num, total) do
    Decimal.div(num, total)
    |> Decimal.mult(10)
    |> Decimal.round(0)
    |> Decimal.to_integer()
    |> do_func(fn level ->
      Enum.map(0..10, fn ^level -> "|"; _ -> "-" end)
      |> Enum.join()
    end)
  end

Would be nice if Elixir had a built-in Kernel.do_func/2.

First 6 of 6 Posts! Switch mode

rm-rf-etc

rm-rf-etc

Oh hey! This is not bad! Just realized I could make this small change.

  def do_func(arg, func), do: func.(arg)

  def get_meter(num, total) do
    Decimal.div(num, total)
    |> Decimal.mult(10)
    |> Decimal.round(0)
    |> Decimal.to_integer()
    |> do_func(&Enum.map(0..10, fn ^&1 -> "|"; _ -> "-" end))
    |> Enum.join()
  end
RudManusachi

RudManusachi

Another approach could be to use capture operator & to create anonymous function. Plus after it we could take Enum.join/1 out to the “main pipeline”

  def get_meter(num, total) do
    Decimal.div(num, total)
    |> Decimal.mult(10)
    |> Decimal.round(0)
    |> Decimal.to_integer()
    |> (&Enum.map(0..10, fn ^&1 -> "|"; _ -> "-" end)).()
    |> Enum.join()
  end

However, I think overall this pattern of wrapping code into anonymous function just to fit into pipeline is considered as bad a bad practice and it’s more preferred to break it into separate functions or intermediate values
(see GitHub - lexmag/elixir-style-guide: An opinionated Elixir style guide · GitHub

RudManusachi

RudManusachi

There ya go! =)

rm-rf-etc

rm-rf-etc

Sorry to have cut in front of you @RudManusachi.

I hear what you’re saying, but this seems it’s pretty small to break out into a separate function. Mind showing me what you think would be the best practice for this?

benwilson512

benwilson512

Author of Craft GraphQL APIs in Elixir with Absinthe

Exactly. It is not obvious what the intent of (&Enum.map(0..10, fn ^&1 -> "|"; _ -> "-" end)).() is at all. However if you name it, then it’s a lot clearer.

rm-rf-etc

rm-rf-etc

'Aight, good feedback. You all were right, I moved some things around and the code got better. Thanks everyone.

Where Next?

Trending in Questions Top

jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
silverdr
Using Phoenix.LiveView.TagEngine as an EEx.Engine is deprecated! To compile HEEx, use Phoenix.LiveView.TagEngine.compile/2 instead. Sta...
New
saveman71
Hello ! We want new/edit form pages to POST/PUT to their own URL rather than the resources REST defaults (post /things, put /things/:id)...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
michallepicki
I am using Oban and occasionally, shortly after a deployment, a handful of jobs can fail because of dependency on other parts of the syst...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
type1fool
I just stumbled on a newly redesigned elixir-lang.org. :tada: It looks like @Software_Mansion did the work, and I think it is generally a...
New
akoutmos
@hugobarauna and I (Alex Koutmos) have been hard at work on writing a book on Nerves that takes you from simply blinking LEDs to building...
New

We're in Beta

About us Mission Statement