Hello all,
I added version 1.2 of NimbleCSV to my dependencies, and now when I run mix coveralls it’s computing nimble_csv as my own code and code coverage is down 16%
Does anyone have any idea why this might be happening?
Thanks in advance for any help!
What’s the version of elixir/erlang/excoveralls/nimble_csv?
Also could be related to
opened 08:04PM - 12 Feb 21 UTC
I'm running excoveralls in an umbrella. If I run `mix coveralls -u` at the top … level, or if I `cd` into a specific application's directory and just run `mix coveralls`, it will include some random files from dependencies:
```
Finished in 9.2 seconds
271 doctests, 4 properties, 101 tests, 0 failures
Randomized with seed 987334
----------------
COV FILE LINES RELEVANT MISSED
0.0% /home/chris/src/noreaga/deps/mox/lib/mox 756 1 1
51.9% lib/bson/id_server.ex 101 27 13
0.0% lib/mix/tasks/ci.module_filenames.ex 144 26 26
0.0% lib/mix/tasks/ua_inspector.maybe_downloa 19 3 3
0.0% lib/peek.ex 12 0 0
71.9% lib/peek/actor.ex 471 64 18
... continues
```
The first file should not be here; the rest are correct.
I get the same thing with `mix coveralls -u` at the top level, but with an incorrect file path:
```
... other coverage from other apps...
0.0% apps/peek//home/chris/src/noreaga/deps/m 756 1 1
51.9% apps/peek/lib/bson/id_server.ex 101 27 13
0.0% apps/peek/lib/mix/tasks/ci.module_filena 144 26 26
0.0% apps/peek/lib/mix/tasks/ua_inspector.may 19 3 3
0.0% apps/peek/lib/peek.ex 12 0 0
71.9% apps/peek/lib/peek/actor.ex 471 64 18
... continues
```
1 Like
Thanks a lot for your reply @chulkilee
I’m using Elixir 1.13.2, Erlang 24.2.1 and Nimble 1.2. Also I’m not using umbrella apps.
In the links you shared, they suggested excluding files from coveralls, I’ll do that as a last resort, but I’m trying to find a way that I don’t need to do that.
Do you create a custom NimbleCSV parser? If so that’s code generated by nimble_csv, but in your codebase. Maybe that’s the culpit here.
1 Like
I just checked and that is exactly it. Thanks a lot @LostKobrakai
So probably my best solution is just to add this module to the skip_files in the coverall.json, right?
