vshesh

vshesh

Nx.LinAlg.solve basic case error?

Trying to implement projective transform in elixir.
I ported an algorithm over from another project:

defmodule ProjectiveTransform do
  def make_transform(
    [[x1, y1], [x2, y2], [x3, y3], [x4, y4]],
    [[xx1, yy1], [xx2, yy2], [xx3, yy3], [xx4, yy4]]
  ) do
    make_transform(
      [x1, y1, x2, y2, x3, y3, x4, y4],
      [xx1, yy1, xx2, yy2, xx3, yy3, xx4, yy4])
  end
  def make_transform(
    [x1, y1, x2, y2, x3, y3, x4, y4],
    [xx1, yy1, xx2, yy2, xx3, yy3, xx4, yy4]
  ) do
    a = Nx.tensor([
      [x1, y1, 1, 0, 0, 0, 0, 0,   -xx1, 0, 0, 0],
      [x2, y2, 1, 0, 0, 0, 0, 0,   0 ,-xx2, 0, 0],
      [x3, y3, 1, 0, 0, 0, 0, 0,   0, 0 ,-xx3, 0],
      [x4, y4, 1, 0, 0, 0, 0, 0,   0, 0, 0 ,-xx4],
      [0, 0, 0, x1, y1, 1, 0, 0,   -yy1, 0, 0, 0],
      [0, 0, 0, x2, y2, 1, 0, 0,   0 ,-yy2, 0, 0],
      [0, 0, 0, x3, y3, 1, 0, 0,   0, 0 ,-yy3, 0],
      [0, 0, 0, x4, y4, 1, 0, 0,   0, 0, 0 ,-yy4],
      [0, 0, 0, 0, 0, 0, x1, y1,    -1, 0, 0, 0],
      [0, 0, 0, 0, 0, 0, x2, y2,   0  ,-1, 0, 0],
      [0, 0, 0, 0, 0, 0, x3, y3,   0, 0  ,-1, 0],
      [0, 0, 0, 0, 0, 0, x4, y4,   0, 0, 0  ,-1],
    ])
    v = Nx.tensor([0, 0, 0, 0, 0, 0, 0, 0, -1, -1, -1, -1])
    x = Nx.LinAlg.solve(a, v)
    Nx.reshape(Nx.concatenate([x[0..7], Nx.tensor([1])]), {3,3})
  end
end

Then wrote a simple test


defmodule ProjectiveTransformTest do
  use ExUnit.Case, async: true
  use ExUnitProperties

  alias StreamData
  import TestHelpers

  test "single hardcoded transformation case" do
    assert ProjectiveTransform.make_transform(
      [[0,0], [0,10], [10,10], [10,0]],
      [[0,0], [0,10], [10,10], [10,0]]
    ) == Nx.eye(3)
  end
end

And when I run mix test I get the following error:


  2) test single hardcoded transformation case (ProjectiveTransformTest)
     test/object_tracking_test.exs:57
     Assertion with == failed
     code:  assert ProjectiveTransform.make_transform([[0, 0], [0, 10], ~c"\n\n", [10, 0]], [
              [0, 0],
              [0, 10],
              ~c"\n\n",
              [10, 0]
            ]) == Nx.eye(3)
     left:  #Nx.Tensor<\n  f32[3][3]\n  [\n    [1.0000011920928955, -2.006071753157812e-7, 1.415989459019329e-6],\n    [9.025153069330827e-9, 1.000001072883606, -2.960541394259053e-7],\n    [8.9426798410841e-8, 5.948747983097746e-8, 1.0]\n  ]\n>
     right: #Nx.Tensor<\n  s64[3][3]\n  [\n    [1, 0, 0],\n    [0, 1, 0],\n    [0, 0, 1]\n  ]\n>

For comparison, the same exact thing in Julia:

julia> make_perspective(((0,0), (0,10), (10,10), (10,0)), ((0,0), (0,10), (10,10), (10,0)))
3×3 SMatrix{3, 3, Float64, 9} with indices SOneTo(3)×SOneTo(3):
 1.0  0.0  0.0
 0.0  1.0  0.0
 0.0  0.0  1.0

It looks like it’s “close” to zero but why e-7?

Most Liked

polvalente

polvalente

Nx Core Team

There are 2 issues at hand here. Firstly, your equality check is going to fail because you’re comparing an s64 tensor to an f32 tensor, and those will always be different Elixir-wise.

Nx unit tests use an assert_equal helper that you can yank, or better yet, assert all close.

Now for the precision issue. You’re dealing with floating point numbers, and the first difference I spot is that in Julia you used f64, while in Nx you used f32. That by itself is already a source of significant difference. Aside that, Julia might be doing some rounding in the results, especially in the underlying mechanisms of the linear system solution (e.g zero-rounding in PLU or QR decomposition before doing triangular solves)

Where Next?

Popular in Questions Top

ashish173
I am using Ecto timestamps with postgres, I can see the timestamps() use the :naive_dateime but for my use case I wanted to store the ti...
New
gshaw
What is the idiomatic way of matching for not nil in Elixir? E.g., First way: defp halt_if_not_signed_in(conn, signed_in_account) when...
New
bsollish-terakeet
Credo is smart enough to check for (something like) this: assert length(the_list) == 0 with this response: Checking if an enum is empt...
New
stefanluptak
Hello everybody, usually, I use a 29" ultra-wide monitor for VSCode which can easily accomodate explorer (files panel) + file with code ...
New
pmjoe
I have a relationship of love and hate with Elixir. Lots of things are just absolutely right, but there are some things that are kind of ...
New
albydarned
Hello all! I am typing this post from my new MacBook Pro with the M1 chip. I’m loving it so far, and will probably use it as my daily dr...
New
WestKeys
Currently suffering from paralysis by [HTTP client] analysis. This is rather unusual in Elixirland as there tends to be consensus on the ...
New

Other popular topics Top

KronicDeth
Elixir plugin for JetBrain’s IntelliJ Platform (including Rubymine) This is a plugin that adds support for Elixir to JetBrains IntelliJ...
289 36689 110
New
nobody
Hi! In PHP: $_SERVER[‘SERVER_ADDR’] - in Elixir? Searched the docs for ip address and the web, no good results. Thanks!
New
sen
Hi All, I set a environment variables in dev.exs , like below code. when i start server, how can i set the ${enable} value? thanks. d...
New
axelson
This post is a wiki (feel free to hit the edit button near the bottom right of this post to add your own changes!) This post collects co...
239 49134 226
New
sergio_101
I am VERY much an elixir newbie. I have taken one elixir course and one phoenix course on Udemy. During that course, I saw the instructor...
New
Patoshizzle
After calling mix ecto.create I get this error: 17:00:32.162 [error] GenServer #PID&lt;0.412.0&gt; terminating ** (Postgrex.Error) FATAL...
New

We're in Beta

About us Mission Statement