sc4224

sc4224

Hi, having a problem refactoring using pattern matching for these lines of code

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    input =~ ~r/\A[a-z]\z/ ->
      Map.put(game, :guess, input)
    true ->
      IO.puts "please enter a lower-case letter"
      accept_move(game)
  end
end

Basically what I want to do is refactor the conditional logic, but I can’t seem to find a way to pattern match sigils using the where clause. Can anybody show me how?

First 7 of 7 Posts Switch mode

LostKobrakai

LostKobrakai

As you can see here https://hexdocs.pm/elixir/guards.html =~ is not listed in the list of things you can use within a guard clause. And while you can use sigils in pattern matches executing a regex is not possible as part of a pattern match or guard clause.

sc4224

sc4224 OP

does this mean it is not possible to refactor this conditional logic into a new function?

NobbZ

NobbZ

Of course…

def only_single_lowercase(<<c::utf8>>), do: c in ?a..?z
sc4224

sc4224 OP

so for the latter condition would be something like this

def only_single_lowercase(<<boolean>>) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

what would that argument be? and where is the documentation for <>? thanks

NobbZ

NobbZ

No, you use only single lowercase instead of your current match.

Based on this you should be able to build a two clause function that replaces your current function.

Documentation for the <<>>/1 can be found in the docs :wink:

sc4224

sc4224 OP

so how do you write a multi clause function for this case?

def only_single_lowercase(<<c::utf-8>>), do: c in ?a..?z

and

def only_single_lowercase(input) where is_boolean(input) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

these are my two clauses. I apologize, this isn’t what i’m used to and i’m lost.

NobbZ

NobbZ

I’m not quite sure where you get the is_boolean/1 from. I never used that.

The first step is (as I said already) to simply replace your first condition with my function:

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    only_single_lowercase(input) ->
      Map.put(game, :guess, input)
    true ->
      IO.puts("please enter a lower-case letter"
      accept_move(game)
  end
end

The next step is to rewrite the cond into a case (and inline my function):

def check_input(input, game = %State{}) do
  input
  |> String.trim()
  |> case do
    <<c::utf8>> when c in ?a..?z ->
      Map.put(game, :guess, input)
    _ ->
      IO.puts(…)
      accept_move(game)
  end
end

And now it should be easy to extract this 2-clause case into a 2-clause function.

— All posts loaded —

Where Next? Top

Trending in Questions Top

stjefim
Hello! Suppose you are building workflow (order / task / payment) processing system with the following requirements: Each workflow con...
New
jonnycharles
I’m in search of an Elixir library that offers PDF generation capabilities similar to Ruby’s Prawn. While there have been discussions abo...
New
spammy
I’m looking to build a personal workflow to quickly deploy web applications written in elixir/phoenix, for local consumption (ie not on t...
New
dli
Before I dive in myself, did anyone successfully sprinkle Hologram into their existing LiveView app? Looking for hints regarding: Addi...
New
bottlenecked
Hi all, I wanted to ask how the community is dealing with post-release steps. Today we have Ecto migrations, which make sure that the db...
New
roeland
Kia ora, We have been using elixir-google-api to connect to Google Drive. However, with the updates to Tesla due to CVEs this is now bro...
New
rahultumpala
Hello, I have an Elixir backend that implements a custom protocol over TCP. I want to load test the backend and assess the performance o...
New

Other Trending Topics Top

JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New

We're in Beta

About us Mission Statement