sc4224

sc4224

Hi, having a problem refactoring using pattern matching for these lines of code

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    input =~ ~r/\A[a-z]\z/ ->
      Map.put(game, :guess, input)
    true ->
      IO.puts "please enter a lower-case letter"
      accept_move(game)
  end
end

Basically what I want to do is refactor the conditional logic, but I can’t seem to find a way to pattern match sigils using the where clause. Can anybody show me how?

Showing Posts 1 to 7

LostKobrakai

LostKobrakai

As you can see here https://hexdocs.pm/elixir/guards.html =~ is not listed in the list of things you can use within a guard clause. And while you can use sigils in pattern matches executing a regex is not possible as part of a pattern match or guard clause.

sc4224

sc4224 OP

does this mean it is not possible to refactor this conditional logic into a new function?

NobbZ

NobbZ

Of course…

def only_single_lowercase(<<c::utf8>>), do: c in ?a..?z
sc4224

sc4224 OP

so for the latter condition would be something like this

def only_single_lowercase(<<boolean>>) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

what would that argument be? and where is the documentation for <>? thanks

NobbZ

NobbZ

No, you use only single lowercase instead of your current match.

Based on this you should be able to build a two clause function that replaces your current function.

Documentation for the <<>>/1 can be found in the docs :wink:

sc4224

sc4224 OP

so how do you write a multi clause function for this case?

def only_single_lowercase(<<c::utf-8>>), do: c in ?a..?z

and

def only_single_lowercase(input) where is_boolean(input) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

these are my two clauses. I apologize, this isn’t what i’m used to and i’m lost.

NobbZ

NobbZ

I’m not quite sure where you get the is_boolean/1 from. I never used that.

The first step is (as I said already) to simply replace your first condition with my function:

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    only_single_lowercase(input) ->
      Map.put(game, :guess, input)
    true ->
      IO.puts("please enter a lower-case letter"
      accept_move(game)
  end
end

The next step is to rewrite the cond into a case (and inline my function):

def check_input(input, game = %State{}) do
  input
  |> String.trim()
  |> case do
    <<c::utf8>> when c in ?a..?z ->
      Map.put(game, :guess, input)
    _ ->
      IO.puts(…)
      accept_move(game)
  end
end

And now it should be easy to extract this 2-clause case into a 2-clause function.

— All posts loaded —

Where Next? Top

Trending in Questions Top

itzmidinesh
Hi all, I’m working on a Phoenix project where I need to make external HTTP requests and I’m trying to choose between Req and HTTPoison....
New
yarrichar
I’m very new to Elixir, so sorry if this is a silly question: I am wondering what happens to the mailbox of a process when the machine i...
New
pragdave
How do I tell Hologram not to escape HTML when substituting into templates? {Textile.render(@product.long_description)} escapes the HTM...
New
Fl4m3Ph03n1x
Background When trying to execute mix release on a Windows 11 machine for a Phoenix project I get the following error: * assembling mark...
New
rlipscombe
I’d like to create a file with 600 permissions (rw-------), but there’s a race condition if I create it and then change the permissions. ...
New
saleyn
Is there a way to import record definitions in the iex shell for pretty printing (similar to the rr command in the erl shell)? This woul...
New
rlipscombe
When I use Mix.install with a git dependency, using git@github.com:... how do I change the SSH identity used? I’ve got two Github accoun...
New

Other Trending Topics Top

dominicletz
Hey there, I haven’t seen a list of useful Elixir specific skills for the popular AI tools yet so I’m starting one here with my first. ...
New
raa-ziq
Hi everyone :waving_hand: I wanted to share something I’ve been building — NowBlind, a random chat app designed to help people discover ...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
OndrejValenta
(I just needed to vent somewhere and LinkedIn is full of hope, or hype, I’m not sure which exactly) AI dream has many faces, but general...
New
kip
Localize is the next generation localisation library for Elixir. Think of it as ex_cldr version 3.0. The first version will be released ...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews