sc4224

sc4224

Hi, having a problem refactoring using pattern matching for these lines of code

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    input =~ ~r/\A[a-z]\z/ ->
      Map.put(game, :guess, input)
    true ->
      IO.puts "please enter a lower-case letter"
      accept_move(game)
  end
end

Basically what I want to do is refactor the conditional logic, but I can’t seem to find a way to pattern match sigils using the where clause. Can anybody show me how?

Showing Posts 1 to 7

LostKobrakai

LostKobrakai

As you can see here https://hexdocs.pm/elixir/guards.html =~ is not listed in the list of things you can use within a guard clause. And while you can use sigils in pattern matches executing a regex is not possible as part of a pattern match or guard clause.

sc4224

sc4224 OP

does this mean it is not possible to refactor this conditional logic into a new function?

NobbZ

NobbZ

Of course…

def only_single_lowercase(<<c::utf8>>), do: c in ?a..?z
sc4224

sc4224 OP

so for the latter condition would be something like this

def only_single_lowercase(<<boolean>>) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

what would that argument be? and where is the documentation for <>? thanks

NobbZ

NobbZ

No, you use only single lowercase instead of your current match.

Based on this you should be able to build a two clause function that replaces your current function.

Documentation for the <<>>/1 can be found in the docs :wink:

sc4224

sc4224 OP

so how do you write a multi clause function for this case?

def only_single_lowercase(<<c::utf-8>>), do: c in ?a..?z

and

def only_single_lowercase(input) where is_boolean(input) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

these are my two clauses. I apologize, this isn’t what i’m used to and i’m lost.

NobbZ

NobbZ

I’m not quite sure where you get the is_boolean/1 from. I never used that.

The first step is (as I said already) to simply replace your first condition with my function:

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    only_single_lowercase(input) ->
      Map.put(game, :guess, input)
    true ->
      IO.puts("please enter a lower-case letter"
      accept_move(game)
  end
end

The next step is to rewrite the cond into a case (and inline my function):

def check_input(input, game = %State{}) do
  input
  |> String.trim()
  |> case do
    <<c::utf8>> when c in ?a..?z ->
      Map.put(game, :guess, input)
    _ ->
      IO.puts(…)
      accept_move(game)
  end
end

And now it should be easy to extract this 2-clause case into a 2-clause function.

— All posts loaded —

Where Next? Top

Trending in Questions Top

Blokh
Hey guys, I’ve got a huge CSV ( around 10 GB ) that needs to be processed hourly Do you guys have any suggestions what is the best prac...
New
kszambelanczyk
Hello! Could someone please give me a help/sample code, how to delete a file from s3 using waffle/waffle_ecto from Phoenix app. I creat...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
matt-savvy
Anyone here using Honeybadger? My Honeybadger account is being overwhelmed with noise from some bots. Seeing a lot of Bandit.HTTPError...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
garrison
Hobbes is a low-level distributed database for the Elixir programming language. Hobbes provides a simple, safe, and scalable storage lay...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
mcass19
ExRatatui lets you cook up rich terminal UIs in Elixir, powered by Rust’s ratatui via Rustler NIFs. Build interactive terminal applicatio...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge &amp; Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews