sc4224

sc4224

Hi, having a problem refactoring using pattern matching for these lines of code

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    input =~ ~r/\A[a-z]\z/ ->
      Map.put(game, :guess, input)
    true ->
      IO.puts "please enter a lower-case letter"
      accept_move(game)
  end
end

Basically what I want to do is refactor the conditional logic, but I can’t seem to find a way to pattern match sigils using the where clause. Can anybody show me how?

Showing Posts 1 to 7

LostKobrakai

LostKobrakai

As you can see here https://hexdocs.pm/elixir/guards.html =~ is not listed in the list of things you can use within a guard clause. And while you can use sigils in pattern matches executing a regex is not possible as part of a pattern match or guard clause.

sc4224

sc4224 OP

does this mean it is not possible to refactor this conditional logic into a new function?

NobbZ

NobbZ

Of course…

def only_single_lowercase(<<c::utf8>>), do: c in ?a..?z
sc4224

sc4224 OP

so for the latter condition would be something like this

def only_single_lowercase(<<boolean>>) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

what would that argument be? and where is the documentation for <>? thanks

NobbZ

NobbZ

No, you use only single lowercase instead of your current match.

Based on this you should be able to build a two clause function that replaces your current function.

Documentation for the <<>>/1 can be found in the docs :wink:

sc4224

sc4224 OP

so how do you write a multi clause function for this case?

def only_single_lowercase(<<c::utf-8>>), do: c in ?a..?z

and

def only_single_lowercase(input) where is_boolean(input) do
      IO.puts "please enter a lower-case letter"
      accept_move(game)
end

these are my two clauses. I apologize, this isn’t what i’m used to and i’m lost.

NobbZ

NobbZ

I’m not quite sure where you get the is_boolean/1 from. I never used that.

The first step is (as I said already) to simply replace your first condition with my function:

defp check_input(input, game = %State{}) do
  input = String.trim(input)
  cond do
    only_single_lowercase(input) ->
      Map.put(game, :guess, input)
    true ->
      IO.puts("please enter a lower-case letter"
      accept_move(game)
  end
end

The next step is to rewrite the cond into a case (and inline my function):

def check_input(input, game = %State{}) do
  input
  |> String.trim()
  |> case do
    <<c::utf8>> when c in ?a..?z ->
      Map.put(game, :guess, input)
    _ ->
      IO.puts(…)
      accept_move(game)
  end
end

And now it should be easy to extract this 2-clause case into a 2-clause function.

— All posts loaded —

Where Next? Top

Trending in Questions Top

water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New

Other Trending Topics Top

budgie
A little off-topic, but I feel like people here have a good head on their shoulders. I used to be quite good at making software. Was luc...
New
KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews