aiwaiwa
Phoenix 1.7.1 - thank you for making Heroicons CSS-enabled
The title says it all ![]()
Great thanks! Awesome job on 1.7.x. Thank you, thank you!
I was to report that z- class thing covers flash when <.modal> is open, but it’s an easy quick dirty edit fix. Plus phx-click-away on a <.modal> is too aggressive and hides itself when one taps a flash popup. Also an easy fix.
Side note: Would be cool to allow renaming attributes to _ prefix, to temporarily disable them
without causing warning complaints.
Most Liked
josevalim
The HeroIcons package approach works for client side frameworks but it doesn’t work for server side frameworks. With the package, we would send to the client the same svg several times, either in the same or separate pages. The way to address it by sending it as a regular image and have the browser cache it, as pretty much any server side framework does.
I am 100% certain that the new default provides better user experiences. Upgrading the icons is the only downside, but that rarely happens, and it is as easy as dropping a zip file. In any case, we are looking into streamlining it, potentially with a mix task.
LostKobrakai
I think the icons should be a depedency e.g. like how esbuild or tailwind are pulled in assets.
greven
Icon packages like HeroIcons are a great upgrade to user experience, since it’s easier than inlining SVGs and one can go and use different ones available in HEX like Lucide Icons, etc. I even commited some PRs to HeroIcons to make upgrading easier, etc.
With this said, I understand the change for performance reasons, but like Kobrakai says, it would be nicer for it to be an external package with an easy way to update the icons, be it with new releases or in place with a mix script (what we have now but with the added script).
If Phoenix Components provides the Icon Component Function one could easily use different icon packages and still reap the performance benefits of this method.
Popular in Discussions
Other popular topics
Categories:
Sub Categories:
Forums
Popular Tags
- #ecto
- #liveview
- #troubleshooting
- #learning-elixir
- #deployment
- #library
- #erlang
- #testing
- #genserver
- #mix
- #absinthe
- #remote-other
- #otp
- #plug
- #how-to-question
- #macros
- #postgres
- #channels
- #elixirconf
- #exunit
- #discussion
- #code-sync
- #javascript
- #podcasts
- #onsite
- #dialyzer
- #docker
- #authentication
- #umbrella
- #full-time-contract
- #podcasts-by-brainlid
- #ecto-query
- #elixir-ls
- #phoenix_html
- #iex
- #blog-post
- #graphql
- #genstage
- #ai
- #websockets
- #supervisor
- #advent-of-code
- #elixirconf-us
- #distillery
- #processes
- #forms
- #api
- #metaprogramming
- #security
- #hex










