Phoenix and multiple webhooks ignored

Phoenix Forum Questions / Help
, ,
1

Hello,

I have an elixir phoneix application that receives Stripe webhooks to update payment status in the database, I have a problem, sometimes my webhook endpoint does not return a response to stripe so the webhook will be failed.

When I looked in the logs : I found that sometimes the request does not pass through the Plug (in the Plug I check the signature of the webhook), and then the request can reach the Controller function.

The Plug code :


def call(%{request_path: "/webhooks/stripe"} = conn, _) do
    check_signature(conn, "secret")
  end


  defp check_signature(conn, signing_secret) do
      # Stripe.Webhook.construct_event(body, stripe_signature, signing_secret)
      # etc..
      IO.puts("signature OK")
      Plug.Conn.assign(conn, :stripe_event, stripe_event)
    else
      {:error, error} ->
        Logger.info(error)
        conn
        |> send_resp(:bad_request, "Stripe signature error: #{error}")
        |> halt()
      _ -> conn
      |> send_resp(:bad_request, "Stripe signature error")
      |> halt()
    end
  end

So in the logs the request can be terminated in the Plug and the last log entry is “signature OK”

Why do you think is that ?

1 Like
2

Well it seems like the plug is executed successfully then. You’ll have to post more code that is supposed to be executed after it to troubleshoot further.

3

Here is the function in the controller :

  def webhooks_payment(%Plug.Conn{assigns: %{stripe_event: stripe_event}} = conn, _params) do
    IO.puts("webhooks_payment controller reached")
    case handle_payment_intent_event(stripe_event) do
      {:ok, _result} ->
        IO.puts("webhooks_payment controller ok")
        handle_success(conn)

      {:error, error} ->
        IO.puts("webhooks_payment controller error")
        Logger.error(error)
        handle_error(conn, error)
    end
  end

I put 2 screenshots to show how sometimes it can reach the controller function and sometimes it doesn’t even log the entry message.

  • If the app is working on the request (still in Plug) and another webhook is received, will that block the current one ?

1
11372×124 17.5 KB

2
21400×243 26.3 KB

4

What do you think @dimitarvp ? I don’t think it’s a networking problem (k8s istio ingress) becuase the request can reach the Plug but not pass to the Controller

5

Any ideas please ?

6

That does seem quite mysterious…

Maybe add an IO.inspect(stripe_event) after this or wrap the assignment like so

conn
|> IO.inspect(label: "conn before when signature OK")
|> Plug.Conn.assign(:stripe_event, stripe_event)
|> IO.inspect(label: "conn after when signature OK")

to determine if there’s anything unexpected going on with the conn that do not reach the function in the controller.

The request could also potentially be reaching the controller and just not matching on webhooks_payment if there’s no catchall function head e.g.
def webhooks_payment(conn, params), do: IO.inspect(conn, label: "conn from catchall webhooks_payments")

1 Like
7

If you followed Stripe Webhooks in Phoenix with Elixir Pattern Matching | Connor Fritz (which it kind of looks like from your function signatures) , I might know the fix . I ran into the same problem when referencing said article .

In Connor’s code , I believe the offending lines are :

{:ok, body, _} = Plug.Conn.read_body(conn)
conn

The conn returned is ‘stale’ in a sense . So I changed this to

{:ok, body, conn} = Plug.Conn.read_body(conn)
conn

and the problem seems to have gone away . I haven’t done any further digging into exactly why this is the case (the exact difference between the conn passed into Plug.Conn.read_body and the one that comes out , and how this affects the pipeline downstream . If anyone has any insight on it , am curious to hear)

1 Like
8

While I can’t comment on the exact reasons I’d always advise to use the Plug.Conn that’s returned to you. If you have such a return value then the underlying library has changed it and gives you the modified copy. So just use that.

1 Like