TLDR: In case of “unmatched topic” error, phoenix.js library continuously retries to rejoin the channel. Shouldn’t the default retry behaviour for “unmatched topic” error - be stop further rejoin attempts or try to join n times?

When a topic does not match any topic defined in channels, server returns the “unmatched topic” error.

[null,“6”,“topic:subtopic”,“phx_reply”,{“response”:{“reason”:“unmatched topic”},“status”:“error”}]

Phoenix 1.5.8 branch

https://github.com/phoenixframework/phoenix/blob/4e066449cce05a866ca2d181ce1ec6bbbfc32537/assets/js/phoenix.js#L400

// 
 this.joinPush.receive("error", () => {
      this.state = CHANNEL_STATES.errored
      if(this.socket.isConnected()){ this.rejoinTimer.scheduleTimeout() }
    })

The channel state is set to errored, but in the next line scheduleTimeout() is called which schedules a rejoin on next timeout.

https://github.com/phoenixframework/phoenix/blob/4e066449cce05a866ca2d181ce1ec6bbbfc32537/assets/js/phoenix.js#L621

rejoin(timeout = this.timeout){ if(this.isLeaving()){ return }
    this.socket.leaveOpenTopic(this.topic)
    this.state = CHANNEL_STATES.joining
    this.joinPush.resend(timeout)
  }

Rejoin just clears out error state and results in an endless loop of rejoin in case of “unmatched topic”

• When channel state is set to error - it is not checked in rejoin function - should it be checked?
• When a “unmatched topic” happens - default behaviour should be to try n times and stop or infinitely try to connect back to server?

What am I missing in this scenario ?

Edited: grammar and typos