Phoenix Channels C# Client

I did C# since .Net 1, so I scanned through it and I think the C# code looks great!

Class and Method names are capitalized, local variables and private fields are pascalCased…the only change I would make is having the public properties/fields be PascalCased, thus differentiating between local variables/args and properties/fields. Also it is less common in C# to have the hanging indent-style curly braces, but I’ve seen some big projects that use that style like Caliburn if memory serves (framework by Rob Eisenberg, the dude behind Aurelia/Durandal).

So overall everything looks very consistent and clean from what I can see, so again, very impressive for not being a C# guy!

Thanks for the detailed feedback!

What do you think about _privateField convention, is that the norm as well? Do private functions need a differentiation as well?

I personally used _PrivateField because it worked with snippets. Nowadays maybe you can dynamically change a snippet’s variable first letter casing. So I would have for property notified change properties, e.g.:

private string _MyProp;
public string MyProp
{
  get { return _MyProp; }
  set 
  { 
    if (value != _MyProp) 
    {
      _MyProp = value;
      NotifyPropertyChanged(value);
    } 
  }
}

Disclaimer: That’s from memory anyway (I’ve been doing only JS/TS/Elixir for the past year or two) and I’m on my phone!

I think I would use four spaces but on my phone I’m doing two…yes, here is an example of a more fully fleshed base class property.

Cool!

I’m using https://github.com/jfis/dn-phoenix with some tweaks. And I do found there are some JS stuff does not fit into C# world. Glad to see a client not translated line by line from JS. Here are some of my changes:

• The Timer does not play well within UnityEditor, so I removed the auto reconnect code, let the game decide what to do
• Added Push.Receive<T>(string, Action<T>)
• Also added shortcuts Push.Ok , Push.Timeout , Push.Error

Best HTTP looks useful, will also check it.

Those are some excellent notes!
I’ve had the same issues you described, the timer issue was especially
annoying.

In my library, I make sure to clean all timers when you call disconnect.
So, even in my game, I always call disconnect and use my own coroutine
based retry logic.

The generic variant of receive looks very useful. I think it will be a good
addition.

Feel free to open issues or submit PRs when you find the time

Hate to resurrect this thread but is this still something you are actively working on?

@AlejandroHuerta Yup! My game is still in production, and the library is still actively maintained.

Ah that’s great to hear. So you have any plans for the c# upgrade in beta? Such as async/await?

Not yet, that will have to wait until unity officially rolls out support for those features.

Wont be waiting very long as 2017.1 is in beta and scheduled to release in July with support for it. Anyways I’m glad you’re still supporting your library. Seems to be the only one still being actively worked on.