smon

smon

I am working on an Phoenix API (PUT) route that allows the upload of rather large image files (more than 1gb). So I am trying to read the request body in chunks by parsing some requests parameters, opening an io_device (with File.open/2) and hand both my conn and the device to the following function:

  defp read_body_chunked(conn, io_device) do
    IO.inspect(conn, label: "read_body_chunked called")

    read_body(conn)
    |> IO.inspect()
    |> case do
      {:ok, data, conn} ->
        IO.binwrite(io_device, data)
        {:ok, conn}

      {:more, data, conn} ->
        IO.binwrite(io_device, data)
        read_body_chunked(conn, io_device)

      error ->
        error
    end
  end

This works in general if the connection is stable.

But if I kill my client (an Electron app) deliberately while a large file is being uploaded it looks like read_body/2 is still called but never returns. I get a final log with the label “read_body_chunked called”, but then nothing afterwards and I end up with a only partially uploaded file and no apparent way to recover.

What am I missing?

I am using :plug_cowboy 2.7 and Phoenix 1.7.20.

Showing Posts 1 to 3

al2o3cr

al2o3cr

I believe that Cowboy will terminate the process that’s holding the conn when the remote end goes away; trapping exits inside (or around) read_body_chunked would give you more opportunity for logging.

smon

smon OP

How would I implement that?

The function above gets called directly in my controller module. So I would need to somehow inject that capture somewhere in the Phoenix endpoint/router?

smon

smon OP

Solved it with the following extension code:

  defp start_body_streaming(conn, io_device, target_path) do
    parent = self()

    spawn(fn ->
      Process.monitor(parent)

      receive do
        {:DOWN, _ref, :process, _pid, {:shutdown, :local_closed}} ->
          Logger.warning(
            "File upload got interrupted for `#{target_path}`, deleting data received so far."
          )

          File.rm(target_path)
      end
    end)

    stream_body(conn, io_device)
  end

  defp stream_body(conn, io_device) do
    read_body(conn)
    |> case do
      {:ok, data, conn} ->
        IO.binwrite(io_device, data)
        {:ok, conn}

      {:more, data, conn} ->
        IO.binwrite(io_device, data)
        stream_body(conn, io_device)

      error ->
        error
    end
  end

via `Plug.Conn.read_body/2` not returning when client drops/crashes · Issue #107 · elixir-plug/plug_cowboy · GitHub

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
RemyXRenard
I’m seeing that a list inside a Kino.DataTable will be interpreted as a charlist, even if the Kino.configure() is set to charlists: :as_l...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
samoloth
Hi, I’ve just set up an application with ash_authentication. There is only magic link strategy for now, so there is no confirmation add o...
New
FlyingNoodle
If a change or preparation module uses Ash.Changeset.get_argument/2 or Ash.Query.get_argument/2 (or any of the other get_argument functio...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New

Other Trending Topics Top

mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
Dmk
Xamal is a deployment tool for Elixir apps that deploys native releases to bare metal servers over SSH. It’s a port of GitHub - basecamp/...
New
Damirados
Hello everyone. After busy few months I am happy to announce v0.1.0 of Emerge & Solve. They are GUI (Emerge) and State management (S...
New
netoum
Corex is an accessible, unstyled UI component library for Phoenix that integrates Zag.js state machines using Vanilla JavaScript and Live...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews