gouthamvel

gouthamvel

I’m fairly new to elixir. Here’s the code:

defmodule MovAvi.Pool.Executor do
  defmodule Worker do
    use GenServer

    def start_link(args) do
      GenServer.start_link(__MODULE__, args, [])
    end

    def init(args \\ []) do
      uniq_id = :rand.uniform(500)
      IO.puts("Starting worker with uniq_id: #{uniq_id}")
      {:ok, {uniq_id}}
    end

    def worker_called(server, args) do
      GenServer.call(server, {:worker_called, args})
    end

    def handle_call({:worker_called, args}, _from, state) do
      IO.puts("worker_called #{args} #{inspect(state)}")
      :timer.sleep(500)
      {:reply, nil, state}
    end
  end

  use GenServer

  def start_link(args) do
    GenServer.start_link(__MODULE__, args, name: __MODULE__)
  end

  def init(args \\ [pool_size: 2, pool_overflow: 0]) do
    {:ok, pool} =
      :poolboy.start_link(
        worker_module: args[:worker_module],
        size: args[:pool_size],
        max_overflow: args[:pool_overflow]
      )

    {:ok, pool}
  end

  def wait_for_tasks(tasks) do
    GenServer.call(__MODULE__, {:wait_for_tasks, tasks})
  end

  def run_with_task(id) do
    GenServer.call(__MODULE__, {:run_with_task, id})
  end

  def run(id) do
    GenServer.call(__MODULE__, {:run, id})
  end

  def handle_call({:wait_for_tasks, tasks}, _from, state) do
    tasks |> Enum.each(&Task.await(&1))
    {:reply, nil, state}
  end

  def handle_call({:run_with_task, id}, _from, pool) do
    task =
      Task.async(fn ->
        :poolboy.transaction(pool, fn worker ->
          Worker.worker_called(worker, id)
        end)
      end)

    {:reply, task, pool}
  end

  def handle_call({:run, id}, _from, pool) do
    :poolboy.transaction(pool, fn worker ->
      Worker.worker_called(worker, id)
    end)

    {:reply, nil, pool}
  end
end

{:ok, executer} =
  MovAvi.Pool.Executor.start_link(worker_module: MovAvi.Pool.Executor.Worker, pool_size: 2)

Enum.map(0..5, fn id ->
  MovAvi.Pool.Executor.run(id)
end)

IO.puts("=== running run_with_task ===")

Enum.map(6..10, fn id ->
  MovAvi.Pool.Executor.run_with_task(id)
end)
|> MovAvi.Pool.Executor.wait_for_tasks()

I’m playing around with :poolboy and ran into an issue. With normal run the GenServer is blocked till the worker :poolboy.transaction is completed this is expected. Also only 2 workers are created as mentioned.

But when I use run_with_task, :poolboy creates new worker for every id. I’m confused why this is happening.

I’m expecting run_with_task to create all Task and the Task should be blocked for :poolboy to allocate workers.

Any insights and help is appreciated. Also If you think there’s a better way to write the code do let me know.

Thanks

Showing Posts 1 to 2

dom

dom

Executor.init receives [worker_module: MovAvi.Pool.Executor.Worker, pool_size: 2] as args, so args[:pool_overflow] returns nil, not 0. Consider making the default arg an empty list and using a default per item instead like args[:pool_overflow] || 0.

(In fact the default arg for init will never be used, since the callback used by OTP is init/1, not init/0)

gouthamvel

gouthamvel OP

Thanks :smile:

For some reason I was thinking defaults will fill missing keys. Sort of merge args with defaults.

Everything works as expected.

— All posts loaded —

Where Next? Top

Trending in Questions Top

water
I’m aware of 2 such projects, are there others? git: GitHub - team-alembic/realworld: A fullstack Phoenix LiveView application with back...
New
katta
I having some trouble figuring out if I have set myself too strict of standards for my production server. Currently I can handle 75% of r...
New
peck
Hi everyone. My team and I have been working on a fairly modest app based around video streaming and chat, but we’ve landed a customer t...
New
bradley
I really like the adapter patterns that ecto, nebulex, waffle, etc. use and would love find something similar for a key management servic...
New
unaware8150
Hello folks! So at work, we are seeing some situations where we have to define some “fixed” strings that are used across the codebase in...
New
Alvinkariuki
How Can I Optimise Compile Time Dependencies I have been building an elixir application for about 2 years now. Many modules and files ha...
New
leoschweizer
Hi, we run different LLM models across a cluster, with each node loading a configurable subset. Model-specific queues let nodes consume ...
New

Other Trending Topics Top

KristerV
Hey. Is there anyone here who creates agents in their apps? Not talking about using agents, but creating them. I’m finding it pretty diff...
New
mudasobwa
I fully migrated to my own harness from Anthropic/Gemini and I think it’s time to share it. Welcome DSH, the DeepSeek Harness, fully writ...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New
juhalehtonen
There has been a thread to discuss the Stack Overflow Developer Survey on this forum every year since 2018, so here’s yet another one for...
New
budgie
I love Elixir. It’s one of 2 programming languages I’ve ever fallen in love with. But I don’t use it anymore. Serverless was the promis...
New
ausimian
Emily is an Elixir library that runs Nx computations on Apple’s MLX. Install it as the default Nx backend and Nx, defn, Axon, Nx.Serving,...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews