gouthamvel

gouthamvel

I’m fairly new to elixir. Here’s the code:

defmodule MovAvi.Pool.Executor do
  defmodule Worker do
    use GenServer

    def start_link(args) do
      GenServer.start_link(__MODULE__, args, [])
    end

    def init(args \\ []) do
      uniq_id = :rand.uniform(500)
      IO.puts("Starting worker with uniq_id: #{uniq_id}")
      {:ok, {uniq_id}}
    end

    def worker_called(server, args) do
      GenServer.call(server, {:worker_called, args})
    end

    def handle_call({:worker_called, args}, _from, state) do
      IO.puts("worker_called #{args} #{inspect(state)}")
      :timer.sleep(500)
      {:reply, nil, state}
    end
  end

  use GenServer

  def start_link(args) do
    GenServer.start_link(__MODULE__, args, name: __MODULE__)
  end

  def init(args \\ [pool_size: 2, pool_overflow: 0]) do
    {:ok, pool} =
      :poolboy.start_link(
        worker_module: args[:worker_module],
        size: args[:pool_size],
        max_overflow: args[:pool_overflow]
      )

    {:ok, pool}
  end

  def wait_for_tasks(tasks) do
    GenServer.call(__MODULE__, {:wait_for_tasks, tasks})
  end

  def run_with_task(id) do
    GenServer.call(__MODULE__, {:run_with_task, id})
  end

  def run(id) do
    GenServer.call(__MODULE__, {:run, id})
  end

  def handle_call({:wait_for_tasks, tasks}, _from, state) do
    tasks |> Enum.each(&Task.await(&1))
    {:reply, nil, state}
  end

  def handle_call({:run_with_task, id}, _from, pool) do
    task =
      Task.async(fn ->
        :poolboy.transaction(pool, fn worker ->
          Worker.worker_called(worker, id)
        end)
      end)

    {:reply, task, pool}
  end

  def handle_call({:run, id}, _from, pool) do
    :poolboy.transaction(pool, fn worker ->
      Worker.worker_called(worker, id)
    end)

    {:reply, nil, pool}
  end
end

{:ok, executer} =
  MovAvi.Pool.Executor.start_link(worker_module: MovAvi.Pool.Executor.Worker, pool_size: 2)

Enum.map(0..5, fn id ->
  MovAvi.Pool.Executor.run(id)
end)

IO.puts("=== running run_with_task ===")

Enum.map(6..10, fn id ->
  MovAvi.Pool.Executor.run_with_task(id)
end)
|> MovAvi.Pool.Executor.wait_for_tasks()

I’m playing around with :poolboy and ran into an issue. With normal run the GenServer is blocked till the worker :poolboy.transaction is completed this is expected. Also only 2 workers are created as mentioned.

But when I use run_with_task, :poolboy creates new worker for every id. I’m confused why this is happening.

I’m expecting run_with_task to create all Task and the Task should be blocked for :poolboy to allocate workers.

Any insights and help is appreciated. Also If you think there’s a better way to write the code do let me know.

Thanks

Showing Posts 1 to 2

dom

dom

Executor.init receives [worker_module: MovAvi.Pool.Executor.Worker, pool_size: 2] as args, so args[:pool_overflow] returns nil, not 0. Consider making the default arg an empty list and using a default per item instead like args[:pool_overflow] || 0.

(In fact the default arg for init will never be used, since the callback used by OTP is init/1, not init/0)

gouthamvel

gouthamvel OP

Thanks :smile:

For some reason I was thinking defaults will fill missing keys. Sort of merge args with defaults.

Everything works as expected.

— All posts loaded —

Where Next? Top

Trending in Questions Top

RSP87
I’m working on a project that simulates the bumbl example in the programming phoenix book. It acts almost like an email client. We have a...
New
nseaSeb
Hello, I know there is an approach for handling lists that allows for optimized traversal, but I can’t recall the specific method (somet...
New
kpanic
Hi everyone, I am toying with the idea of building a “match maker” for giving personal help to people that wants to start coding. I sta...
New
brecabral
Documentation While reading the Scoped Routes section, I noticed that the documentation currently refers to a problem without explainin...
New
velrest
So my question is quite simple and i have found no conclusive answer on forum, google or AI. Should we use :erlang.float for Integer to ...
New
asweet-confluent
I recently noticed that Elixir’s Logger defaults its primary log level to :debug when no :logger, :level application configuration is pre...
New
apz
I’m new to elixir and just tried to install the elixirLS extension for VScode(ium) and it is throwing some errors that I would like help ...
New

Other Trending Topics Top

GenericJam
Edit: 2026 May 15 - This post is archived. Mob is alive!! Main docs: mob v0.7.11 — Documentation A bit of explanation for the slightly c...
New
JesseHerrick
Hey, I’m Jesse and I’m the main contributor behind Dexter, a full-featured, lightning-fast Elixir LSP optimized for large codebases. It s...
New
mudasobwa
I am happy to introduce the very α version of the new programming language compiled to BEAM. Welcome Cure. It has literally three kille...
New
marciok
Hi there! We created Gust: A task orchestrator inspired by Airflow. For those who have never heard about Aiflow, it’s a Python-based wor...
New
mhanberg
Hi everyone! The first release candidate for the Expert language server project is now available! We’ve published a press release detai...
New
jimsynz
Beam Bots (or just BB for short) is a framework for building fault-tolerant robotics applications in Elixir using familiar OTP patterns. ...
New

We're in Beta

About us Mission Statement

Options

Thread Display Mode




Thread Preview

Skip Thread Previews