bglusman
pre-PR Review request for LiveDashboard Historical Data PR
Hey All!
I’ve had some previous discussions about it here before, and much thanks to @LostKobrakai and @doomspork for their help, but I’m on the verge of opening the contents of this PR as a “real” one upstream, and a) thought some pre-review from the community might save the maintainers time, and b) there’s still one subtle bug, I think in the JS code, that I can’t figure out with the charts not rendering correctly until a “live”/non-historical datapoint gets sent to the client.
So any reviews or thoughts, in the PR or here, would be appreciated! This PR is just against my fork’s master, if/when we get bug and any other feedback from community here addressed, I’ll open it for real upstream. Thanks all!
Most Liked
josevalim
Good progress!
I believe some of the points I have made on the initial PR still have to be addressed:
-
Storing the whole measurement + metadata is going to be expensive, therefore the historical API should not be requested to return said information. They should return the label and values only.
-
historical_data can be a MFA that applies to all events, instead of each event individually.
bglusman
For anyone else who’d like to try this in their project, eventually when above PR is merged I will publish this on Hex, but for now this is usable as a git dependency in your mix.exs, feedback on docs or code welcome:
https://github.com/bglusman/live_dashboard_history








