Problem with hooks for pre_commit

ArleyR · April 1, 2020, 3:32pm

Hello guys,

I’m doing an umbrella project with my partners and they configured a pre_commit. I did a rebase in my branch, but I have a problem to commit, I have this error:

I did mix deps.clean -all and check the git repository but I couldn’t found the error. Do you have any idea about this error?
Thanks a lot!

al2o3cr · April 1, 2020, 10:21pm

The message you’re getting (“expected :version to be a valid Version” from Mix) is emitted here:

github.com

elixir-lang/elixir/blob/9d56a019ee0fe9475a61583f26f815e4bdf5717b/lib/mix/lib/mix/tasks/compile.app.ex#L204


defp validate_app(app) do
  ensure_present(:app, app)
  Mix.raise("Expected :app to be an atom, got: #{inspect(app)}")
end


defp validate_version(version) do
  ensure_present(:version, version)


  unless is_binary(version) and match?({:ok, _}, Version.parse(version)) do
    Mix.raise(
      "Expected :version to be a valid Version, got: #{inspect(version)} (see the Version module for more information)"
    )
  end
end


defp ensure_present(name, nil) do
  Mix.raise("Please ensure mix.exs file has the #{inspect(name)} in the project definition")
end


defp ensure_present(_name, _val), do: :ok

Is the git hook adjusting the contents of your mix.exs somehow to include branch metadata? The value in the error "0.0.1+" is what I’d expect if the hook was trying to produce "0.0.1+1db4539" or similar but hit an error fetching the SHA. The “fatal: not a git repository” parts suggest that as well…